MQ2 CTD: /click confirmed buggy

[Teh_ish]

I'm running the "Another TS macro w/ Ini support" macro. Everything works, I've traced back the problem.. The moment I "/target clear" I get an "Everquest has crashed, submit info?" dialog.

PMP - Current variable - 'Param0'

FailIf - Skipping to end of {}

FailIf - Starting macroblock: /if "@Param0"~~# {

FailIf - Skipping(1): /finditem similar "$right($calc($strlen("@Param0")-1),"@Param0")"

FailIf - End at: } else {

FailIf - Else seen, running '{'

PMP - Current variable - 'Param0'

FindItem - Looking inside pack 0: 'Hand Made Backpack'

FindItem - Looking inside pack 1: 'Hand Made Backpack'

FindItem - Found 'Field Point Arrowheads' in primary inventory slot 3

ClientRect: 1280,1024

Mouse moved using mouseloc: inv 3

MQ2EQBugFix Module Unloaded

MQ2FPS Module Unloaded

MQ2ChatWnd Module Unloaded

MQ2ItemDisplay Module Unloaded

MQ2Map Module Unloaded

MQ2Labels Module Unloaded

[Teh_ish]

Worked with DKAA for a while trying to track this down, and he couldn't find anything. It consistently crashes me, and Wassup mentioned he was having troubles with /click as well.

For the record, the command being used is "/click left inv 3"

[wassup]

Worked with DKAA for a while trying to track this down, and he couldn't find anything. It consistently crashes me, and Wassup mentioned he was having troubles with /click as well.

For the record, the command being used is "/click left inv 3"

One CTD I got was /click left merchant done

Maybe its /click left?

[dont_know_at_all]

Microsoft sucks.

This is VS.NET 2003:

Code: Select all

    xor ebx, ebx

Code: Select all

; 992  : 	GetPrivateProfileString("VideoMode","Width","800",ScreenX,MAX_STRING,EQClient); 

  0153e	8b 35 00 00 00
	00		 mov	 esi, DWORD PTR __imp__GetPrivateProfileStringA@24
  01544	83 c4 1c	 add	 esp, 28			; 0000001cH
  01547	8d 94 24 40 60
	00 00		 lea	 edx, DWORD PTR _EQClient$[esp+43088]
  0154e	52		 push	 edx
  0154f	68 00 08 00 00	 push	 2048			; 00000800H
  01554	53		 push	 [color=red]ebx[/color]
  01555	68 00 00 00 00	 push	 OFFSET FLAT:??_C@_03BAAJCDMO@800?$AA@
  0155a	68 00 00 00 00	 push	 OFFSET FLAT:??_C@_05IBAMDCFI@Width?$AA@
  0155f	68 00 00 00 00	 push	 OFFSET FLAT:??_C@_09LIEAKBEG@VideoMode?$AA@
  01564	ff d6		 call	 esi

; 993  : 	GetPrivateProfileString("VideoMode","Height","600",ScreenY,MAX_STRING,EQClient); 

  01566	8d 84 24 40 60
	00 00		 lea	 eax, DWORD PTR _EQClient$[esp+43088]
  0156d	50		 push	 eax
  0156e	68 00 08 00 00	 push	 2048			; 00000800H
  01573	53		 push	 [color=red]ebx[/color]
  01574	68 00 00 00 00	 push	 OFFSET FLAT:??_C@_03PANGFEPN@600?$AA@
  01579	68 00 00 00 00	 push	 OFFSET FLAT:??_C@_06HCAKHJJK@Height?$AA@
  0157e	68 00 00 00 00	 push	 OFFSET FLAT:??_C@_09LIEAKBEG@VideoMode?$AA@
  01583	ff d6		 call	 esi

; 994  : 
; 995  : 	//need to change ScreenX and ScreenY to fit UI ini format, for example XPos800x600 
; 996  : 	sprintf(temp, "%sx%s", ScreenX, ScreenY); 

  01585	53		 push	 [color=red]ebx[/color]
  01586	53		 push	 [color=red]ebx[/color]
  01587	8d 8c 24 48 20
	00 00		 lea	 ecx, DWORD PTR _temp$[esp+43096]
  0158e	68 00 00 00 00	 push	 OFFSET FLAT:??_C@_05DDDBHGIL@?$CFsx?$CFs?$AA@
  01593	51		 push	 ecx
  01594	e8 00 00 00 00	 call	 _sprintf

[dont_know_at_all]

Fixed in CVS for both VS6 and VS.NET for MQ2.

[EqMule]

i still see this when issuing a /click left npctrade give anyone care to confirm or deny this?
edit: ScreenX and ScreenY variables conflict upon compiletime with a globaly defined ScreenX which is a dword, not a string, thus when we try to

Code: Select all

sprintf(temp, "%sx%s",ScreenX,ScreenY);

we will ctd...

fix (by changing to ScrX and ScrY) is on its way to cvs, I just need a second oppinion from one of the other devs first, but this is my theory...

[EqMule]

this is fixed now and in zip and cvs along with a few minor tweaks as well, see changes.txt in your release folder.

[xyilla]

Коро

[xyilla]

212.1

[xyilla]

очко

[xyilla]

CHAP

[xyilla]

Hush

[xyilla]

Walt

[xyilla]

62х8

[xyilla]

чита