Patch to chat code to fix crash problem

A forum for feature requests/discussions and user submitted patches that improve MQ2

Moderator: MacroQuest Developers

Lax
We're not worthy!
We're not worthy!
Posts: 3524
Joined: Thu Oct 17, 2002 1:01 pm
Location: ISBoxer
Contact:

Patch to chat code to fix crash problem

Post by Lax » Mon Oct 27, 2003 6:14 pm

In EQLib_UI.cpp, function CChatWindow__AddOutputText, this replaces the part that calls EQADDR_APPENDSTML

Code: Select all

[color=red]
	struct _rect{
		DWORD l,r,t,b;
	} temp;
	DWORD atemp=(DWORD)&temp;
[/color]
	__asm{
		push eax;
		push ecx;
		push esi;
		push edx;
		push [stri];
[color=red]
		push [atemp];
[/color]
		mov ecx, outwnd;
		call [EQADDR_APPENDSTML];
		pop edx;
		pop esi;	
		pop ecx;
		pop eax;
	};
Before patching, the easiest way to crash consistently is to log in and type /mapfilter, then attempt to resize the MQ window. The mapfilter text is shown messed up, and when you try to resize you crash.

After patching, all is well. Yay!
Lax Lacks
Master of MQ2 Disaster
Purveyor of premium, EULA-safe MMORPG Multiboxing Software
* Multiboxing with ISBoxer: Quick Start Video
* EQPlayNice, WinEQ 2.0

EqMule
Developer
Developer
Posts: 2697
Joined: Fri Jan 03, 2003 9:57 pm
Contact:

Post by EqMule » Mon Oct 27, 2003 7:46 pm

updated in cvs and zip
My status o/
If you like MQ2 and would like to contribute, please do. My goal is 25 donations per month.
So far I've received Image donations for this month's patches.

Bitcoin: 1Aq8ackjQ4f7AUvbUL7BE6oPfT8PmNP4Zq
Krono: PM me.
I can always use characters for testing, PM me if you can donate one.

MacroFiend
a grimling bloodguard
a grimling bloodguard
Posts: 662
Joined: Mon Jul 28, 2003 2:47 am

Post by MacroFiend » Mon Oct 27, 2003 9:56 pm

Using SRC-20031027e.zip, I still CTD. Didn't take long either. Logged in to the bazaar w/ /filter macros all and almost as soon as it rendered the window and pushed "MacroQuest active" in it, I crashed.

It may have something to do w/ the bazaar as I launched w/ another character in PoK and was fine, even after running 4 /who's with over 230 people in the zone ... but just getting "MacroQuest active" in the bazaar crashed.

Note: I enter EQ with 5 chat windows all with locked size and positioning, not including the new MQ window.

Lax
We're not worthy!
We're not worthy!
Posts: 3524
Joined: Thu Oct 17, 2002 1:01 pm
Location: ISBoxer
Contact:

Post by Lax » Mon Oct 27, 2003 9:59 pm

I've been playing with this running for several hours no problems..
Lax Lacks
Master of MQ2 Disaster
Purveyor of premium, EULA-safe MMORPG Multiboxing Software
* Multiboxing with ISBoxer: Quick Start Video
* EQPlayNice, WinEQ 2.0

MacroFiend
a grimling bloodguard
a grimling bloodguard
Posts: 662
Joined: Mon Jul 28, 2003 2:47 am

Post by MacroFiend » Mon Oct 27, 2003 10:13 pm

That's what makes it odd ... my other character using the exact same UI with the exact same chat windows didn't crash. Just the bazaar mule.

Bio_War
a lesser mummy
a lesser mummy
Posts: 36
Joined: Sun Sep 29, 2002 1:03 pm

Still Crashing

Post by Bio_War » Mon Oct 27, 2003 11:37 pm

Downloaded newest, seems to be fine for Antonica, however, it is still crashing in the Bazzar, and in the nexus, not sure about other luclin zones, or PoP, LoDN, or LoY zones

Bio

louseman
decaying skeleton
decaying skeleton
Posts: 8
Joined: Mon Oct 27, 2003 4:16 pm

Post by louseman » Tue Oct 28, 2003 1:14 am

I downloaded the newest zip and it worked fine for me. Went LD at one point (not crash, just the black disconnect thing) and when I logged back in I didn't have the MQ window up and using a MQ command (/target) crashed me.

wassup
Official Guardian and Writer of TFM
Official Guardian and Writer of TFM
Posts: 1487
Joined: Sat Oct 26, 2002 5:15 pm

Post by wassup » Tue Oct 28, 2003 3:49 am

I sat in the bazaar for about half an hour with the MQ Chat Window going.

Did around 15 / commands to see who was in the zone
Used Bazaar Search
Opened and closed merchants and used MQ commands to test
Opened all channels ooc, auc, shout so I could see the text
Used the Find Trader particle effects
Hailed some quest mobs

No problems at all. Maybe I was just lucky or something, but it seems to be working without a problem for me.

FrankJScott
naggy
naggy
Posts: 2353
Joined: Sun Feb 19, 2023 7:11 am

Top Rated Product Website

Post by FrankJScott » Thu Oct 26, 2023 11:30 am

Please try Google for New Product Info 3c8dec9