Another question, about /mouseto

wassup · Post by **wassup** » Sat Oct 04, 2003 3:16 am

I was going through the commands in game to update some of the documentation and ran into some things with /mouseto that got me to thinking...

Is /mouseto somewhat outdated now with the improvement in /click and the addition of /selectitem?

EqMule · Post by **EqMule** » Sat Oct 04, 2003 6:51 am

no, it can be used for other things than selecting stuff... so it should be documented.

wassup · Post by **wassup** » Sat Oct 04, 2003 8:01 am

What I meant was can some of the mouseto functions that are redundant to /click be removed but leave in the other functions that /click doesn't have?

For example:

/mouseto auto
/mouseto destroy
/mouseto merchant
/mouseto equip
/mouseto hotkey
/mouseto bank
/mouseto corpse
/mouseto bank
/mouseto item
/mouseto hslider
/mouseto enviro
/mouseto npctrade

The only one that seems to be non-redundant is /mouseto target.

Ohmz · Post by **Ohmz** » Sat Oct 04, 2003 11:41 am

Mouseto has its purposes..

Code: Select all

:loop
       /click left (location)
/if "@check"=="FALSE" /goto :loop

will execute slower then:

Code: Select all

/mouseto (location)
:loop
       /click left
/if "@check"=="FALSE" /goto :loop

Only pass location parameters to /click if you aren't inside of a loop or are clicking on a non static location IE: a screen location that may move or be covered by something else that can move.

wassup · Post by **wassup** » Sat Oct 04, 2003 6:36 pm

I'm not saying eliminate /mouseto completely, just remove the functions that are redundant with /click.

I agree that

/mouseto +/- x y

and

/mouseto target

are still useful, but the other functions just don't seem all that useful, and some don't work.

Curious · Post by **Curious** » Mon Oct 06, 2003 4:46 am

I personally like /mouseto. Rather than remove it's functionality, I vote for expanding it by adding a $mouseover variable to see what your mouse is on. Would be great for adding error-checking to macros

Code: Select all

/mouseto destroy
/if "$mouseover"=="button" /click left

would not click if a bag was open and in the way of the destroy button

wassup · Post by **wassup** » Mon Oct 06, 2003 5:07 am

Well, I personally don;t understand why people would want to use:

Code: Select all

/mouseto auto
/click left

/mouseto destroy
/click left

/mouseto corpse
/click right

instead of (respectively):

Code: Select all

/click left auto

/click left destroy

/click right corpse

You have to use /click using /mouseto anyway, so why not just use one command instead of two?

Ohmz · Post by **Ohmz** » Mon Oct 06, 2003 5:21 am

From my experience its faster for MQ to parse

Code: Select all

/mouseto <loc>
/click left
/click left

then..

Code: Select all

/click left <loc>
/click left <loc>

PS: Good idea Curious

wassup · Post by **wassup** » Mon Oct 06, 2003 1:44 pm

I don't think my posts are being understood.

Let me say it again...

Leave

Code: Select all

 /mouseto +- x,y

/mouseto target

Eliminate:

Code: Select all

/mouseto auto 
/mouseto destroy 
/mouseto merchant 
/mouseto equip 
/mouseto hotkey 
/mouseto bank 
/mouseto corpse 
/mouseto bank 
/mouseto item 
/mouseto hslider 
/mouseto enviro 
/mouseto npctrade

Nothing that people have posted about would be affected.

grimjack · Post by **grimjack** » Mon Oct 06, 2003 1:58 pm

Why remove the functionality? I don't see where you "gain" anything by taking it out and I don't see where you "loose" anything by leaveing it in. If you don't have a use for it simply don't use it. There may be a reason to /mousto but not click in the future.

Thanks
GrimJack

Mckorr · Post by **Mckorr** » Mon Oct 06, 2003 2:03 pm

I understand your point completely, so I'll try to explain.

Way back when when I was working on fixing problems with mouse movements and clicks in the NewUI, I noticed redundant code in /mouseto and /click. Naturally, I removed it.

Both /mouseto and /click share a common, seperate movement function and a common location parser. You can't alter one without altering the other. The only fundamental difference between the two is /click invokes a left or right click after movement; /mouseto doesn't.

Since there is no redundant code left, or at least very little, there's no reason to remove the extra /mouseto functions. Sure, you could just not document them, but they'd still be there, because the parser has to remain intact for /click.

Jaerin · Post by **Jaerin** » Mon Oct 06, 2003 2:16 pm

I agree with grimjack. Removing the commands for mouseto wouldn't gain you anything. It's not going to make Macroquest faster because if you don't use them then they aren't being called. They may decrease the memory footprint a bit, but MQ doesn't have that big of a memory footprint as it is.

Jaerin

Mckorr · Post by **Mckorr** » Mon Oct 06, 2003 2:46 pm

See post above. One more time, you can't "fix" mouseto without breaking click.

wassup · Post by **wassup** » Mon Oct 06, 2003 3:00 pm

Thanks for the rational explanation McKorr :)

The reason I asked is because I am trying to help Amadeus with his document update request.

I am going through testing the functions with each of their switches/parameters so I understand them before I write.

I noticed that a large number of the /mouseto functions don't work, which made me question whether all of /mouseto functions were even needed.

Valerian · Post by **Valerian** » Tue Oct 07, 2003 8:45 am

/mouseto item works, but may have been broken with the ZoneID change. after things settle with the new stuff, I'll make sure it's fixed in CVS.

If Plaz or any other dev working on the new stuff feels like fixing it, /mouseto item uses the DxID from the ground spawn struct, which used to be loaded into a SPAWNINFO->Zone -- I believe it is now loaded into a GuildID of SPAWNINFO, so the fix is to change ->Zone in eqlib_mouse.cpp to ->GuildID

Another question, about /mouseto

Another question, about /mouseto

Efficiency

Reason

Why?