Please look... Just trying to help

A forum for feature requests/discussions and user submitted patches that improve MQ2

Moderator: MacroQuest Developers

wassup
Official Guardian and Writer of TFM
Official Guardian and Writer of TFM
Posts: 1487
Joined: Sat Oct 26, 2002 5:15 pm

Please look... Just trying to help

Post by wassup » Fri Sep 26, 2003 4:07 am

I was going throughthe code and noticed this:

Code: Select all

// ***************************************************************************
// Function:    MyVarAdd
// Description: Our '/varadd' command
// Usage:       /varadd <v|p># <value>
// ***************************************************************************
.
.
.
	if (((szVar[0]!='v') && (szVar[0]!='p') && (szVar[0]!='l') && (szVar[0]!='a') && (szVar[0]!='t')) || (szVal[0]==0)) 
		GracefullyEndBadMacro(pChar,gMacroBlock, "Usage: /varadd <v#|p#|l#|t#|a(#,#)> <value>");
Comparing this to other code that is in the same file, should this be:

Code: Select all

// ***************************************************************************
// Function:    MyVarAdd
// Description: Our '/varadd' command
// Usage:       /varadd <v|p># <value>
// ***************************************************************************
.
.
.
	if (((szVar[0]!='v') && (szVar[0]!='p') && (szVar[0]!='l') && (szVar[0]!='a') && (szVar[0]!='t')) || (szVal[0]==0)) {
		GracefullyEndBadMacro(pChar,gMacroBlock, "Usage: /varadd <v#|p#|l#|t#|a(#,#)> <value>");
		return;
	}
Just trying to help, not raise the hackles :wink:

Plazmic
The One
The One
Posts: 800
Joined: Fri Jun 14, 2002 12:31 am
Contact:

Post by Plazmic » Wed Oct 01, 2003 2:41 am

Just saw this... I'll add it in my next set of changes, or someone else can CVS it sooner...
- Plazmic