Combining Grimjack Hunter Loot Script with Fippy Hunter.mac!

Macro requests from before the user variable changes that broke all macros

Moderator: MacroQuest Developers

Draekz
a hill giant
a hill giant
Posts: 263
Joined: Thu Aug 01, 2002 6:07 pm
Location: Winnipeg, Manitoba, Canada

Combining Grimjack Hunter Loot Script with Fippy Hunter.mac!

Post by Draekz » Mon Aug 04, 2003 7:09 am

Any chance someone would be able to post a full mac, that uses Fippy's original hunter.mac (it works great but the lootscript doesnt work), with Grimjacks loot script for his hunter script?

its 6am and i've been up 3 hours trying to combine the 2 macro's to work in sync (taking bits and pieces here and there) but cant seem to implement the new loot script with fip's hunter script.

The reason i want this is, I like the way he has the avoidance, home, loot locations and settings in a SEPERATE macro named East Commons. I want to develop more code based on that idea, to work in a lot of open zones (non dungeons) but cant really do it efficiently with just one script (therefore i can call others into the one when needed).

Anyway, thanks for any help!

Draekz

User avatar
grimjack
Macro Author
Macro Author
Posts: 525
Joined: Thu Nov 07, 2002 6:51 am
Contact:

Post by grimjack » Tue Aug 05, 2003 1:44 am

Replace his loot sub with this one. I have not tested this but it should work. As it is it will target the nearest corpse, move to it, and loot.

Code: Select all

sub Loot
   /varset LootSlot 0
   /target corpse
   /delay 2s
   /if $target()=="FALSE" /return
   :movingloop
   /if n $target(distance)>12 {
      /call autorun2 1
      /face nopredict
      /delay 1s
      /goto :movingloop
   }
   /call autorun2 0
   /if $target()=="FALSE" /return
   /loot
   /delay 2s
   :lootloop
   /if n $LootSlot>=9 /goto :doneloot
   /click left corpse $LootSlot
   /delay 1s
   /if "$cursor()"!="TRUE" /goto :doneloot
   :lootChecker
   /if "$cursor(name)"~~"$a(1,$CheckLoot)" {
      /delay 1s
      /click left auto
      /delay 1s
      /varadd LootSlot 1
      /goto :lootloop
   }
   /varadd CheckLoot 1
   /if "$cursor()"=="TRUE" {
      /if n $CheckLoot<$LootTotal /goto :lootchecker
   }
   /if "$cursor()"=="TRUE" {
      /delay 1s
      /click left destroy
      /delay 1s
   }
   /varadd LootSlot 1
   /varset CheckLoot 0
   /goto :lootloop 
   :doneloot
   /cleanup
   /varset LootSlot 0
/return
Thanks
GrimJack
Last edited by grimjack on Wed Aug 06, 2003 3:32 am, edited 1 time in total.
When they come to me, they're in trouble, or they want some. I bust people out of prison, hunt down vampires, fight alien gods -- All the fun jobs people are too squeamish or too polite to do themselves.

Call me a mercenary. Call me an assassin. Call me a villain. I am all that and more.

My name's John Gaunt, but out on the streets of Cynosure, I am called...
GrimJack

Draekz
a hill giant
a hill giant
Posts: 263
Joined: Thu Aug 01, 2002 6:07 pm
Location: Winnipeg, Manitoba, Canada

Post by Draekz » Tue Aug 05, 2003 8:23 am

Hmm well the loot code works pretty good! only thing is, i noticed i had to set a few /press esc's at the end of the code (before the /return) else it wouldnt escape the loot screen.

Besides that its awsome :D thanks!

A problem with the actual code itself tho, is that sometimes after looting, it spams the screen with:

There are no " around.

Any idea what thats from?

And one last minor bug, if i have to move even the slightest to get to some corpses, it just keeps me running in a straight line! Lol, usually i have to interfere and turn myself around, then it'll run back to the corpse and loot it. Any idea what i can change there?

Thanks!

Draekz

User avatar
grimjack
Macro Author
Macro Author
Posts: 525
Joined: Thu Nov 07, 2002 6:51 am
Contact:

Post by grimjack » Wed Aug 06, 2003 3:35 am

Reposted with 2 fixes. /face nopredict so it faces the corpse as it runs hehe. And /cleanup so it kills the loot windows ect. I'm not sure on the other quesiton. I will have to go through fippy's code. I would guess it's trying to aquire a target and not getting one? I'll look. Let me know if there is still problems with the loot code.

Thanks
GrimJack
When they come to me, they're in trouble, or they want some. I bust people out of prison, hunt down vampires, fight alien gods -- All the fun jobs people are too squeamish or too polite to do themselves.

Call me a mercenary. Call me an assassin. Call me a villain. I am all that and more.

My name's John Gaunt, but out on the streets of Cynosure, I am called...
GrimJack

Draekz
a hill giant
a hill giant
Posts: 263
Joined: Thu Aug 01, 2002 6:07 pm
Location: Winnipeg, Manitoba, Canada

Post by Draekz » Wed Aug 06, 2003 10:01 am

Hey thanks grim, didnt notice a reply here ;) will letcha know whats goin on when I test it again (damn patch)

Take it easy!

Draekz