4 March 2005 Update

JJ · Post by JJ » Fri Mar 04, 2005 7:16 pm

- Fixed buff slot counts

So far I've encountered ${Me.Buff[XXXX].ID} is now returning 1 or NULL only.

ieatacid · Post by **ieatacid** » Fri Mar 04, 2005 8:30 pm

It's working fine for me

JJ · Post by JJ » Fri Mar 04, 2005 8:32 pm

Gonna try a recompile again. Just recompiled 4 Mar update, then again with your new _SPELL and both still did the same thing . . .

EDIT: Well bummer. Oh well, I can live with it this way. I just changed my lich spell to my first slot so it will be in slot 0 (ID of 1) for it to be clicked off. Just a thought, think it might have to do with the fact that I don't own DoN? Although it didn't break until that last patch, not the DoN patch.

dont_know_at_all · Post by **dont_know_at_all** » Fri Mar 04, 2005 8:42 pm

The 03/04 zip has his _SPELL struct.

sbsp · Post by **sbsp** » Sat Mar 05, 2005 9:12 pm

I get the same thing

Agripa · Post by **Agripa** » Sun Mar 06, 2005 10:29 pm

I just compiled with the new zip and ${Me.Buff[XXXX].ID} is giving me the same problem where it only returns 1 or NULL.

I am also having a problem where the last line in any include file is being executed twice:

test.mac

Code: Select all

Sub Main 

   #include test.inc

/return

test.inc

Code: Select all

/echo First Line of test.inc

/echo Middle Line of test.inc

/echo Last Line of test.inc

returns:

Code: Select all

[MQ2] First Line of test.inc
[MQ2] Middle Line of test.inc
[MQ2] Last Line of test.inc
[MQ2] Last Line of test.inc

Edit: I have not had problems with including files directly into code until now but the manual implies that this should not be done so I will just encapsulate the code in a Sub.

Lax · Post by **Lax** » Sun Mar 06, 2005 11:12 pm

Make sure there's a carriage return at the end of the file (e.g. a blank line).

dont_know_at_all · Post by **dont_know_at_all** » Mon Mar 07, 2005 12:24 am

Include file problem fixed next zip...

Agripa · Post by **Agripa** » Mon Mar 07, 2005 5:36 pm

Was the problem with ${Me.Buff[XXXX].ID} resolved? I have not seen anything in the forums. I still had the problem with all plugins disabled in the 20050304 release as well as a patched 20050227a release.

dont_know_at_all · Post by **dont_know_at_all** » Mon Mar 07, 2005 5:45 pm

${Me.Buff[XXXX].ID}

ID is the slot number. Are you looking for spell ID?

Agripa · Post by **Agripa** » Mon Mar 07, 2005 6:09 pm

The problem is ${Me.Buff[XXXX].ID} is always returning 1 if the buff exists and NULL if it does not. I did not mean to hijack this thread with the include file issue so I brought the original subject back up.

ieatacid says above that it is working for him so I wonder what the difference is in his setup.

Agripa · Post by **Agripa** » Mon Mar 07, 2005 7:07 pm

dont_know_at_all found the problem with ${Me.Buff[XXXX].ID}. It was affecting short buffs as well.

MQ2Utilities.cpp:

Code: Select all

bool GetShortBuffID(PSPELLBUFF pBuff, DWORD &nID)
{
	PCHARINFO pChar=GetCharInfo();
-	unsigned long N=(pBuff-&pChar->ShortBuff[0])/sizeof(SPELLBUFF);
+	unsigned long N=(pBuff-&pChar->ShortBuff[0]);
	if (N<12)
	{
		nID=N+1;
		return true;
	}
	return false;
}
bool GetBuffID(PSPELLBUFF pBuff, DWORD &nID)
{
	PCHARINFO pChar=GetCharInfo();
-	unsigned long N=(pBuff-&pChar->Buff[0])/sizeof(SPELLBUFF);
+	unsigned long N=(pBuff-&pChar->Buff[0]);
	if (N<0x19)
	{
		nID=N+1;
		return true;
	}
	return false;
}