Combine.mac - Unsticky plz -

[serberus]

Minor change to the combine.mac to delay for 1.1 seconds every combine, may work with other delays but I think the minimum is 1 second so i've used 1.1 for safety.

The only change to the macro is the insertion of the '/delay 11' line as shown below, works for me now.

Code: Select all

      :Combine 
        /sendkey up ctrl 
        /delay 11
        /click left $v20 combine 

Serberus

[Cokoanut]

I can't get it to work. It takes the 4 items, puts them in the container, and then the macro ends. It won't hit combine. Anybody else having this problem?

[david6789]

I am very new to this so please forgive my noobness.
You would just subsitute $p1, $p2, $p3, etc. for the items you really want ie field point, wooden arrow shaft, etc.??
Do I have to substitute the name of the container any where, like place in there "fletching kit"?

Just looking for some guidense here, I am interested in Tinkering, fletching, and jewelry crafting.

Thanks
Dave

[L124RD]

Salutations,
pick up your container. /identify. it will tell you the type of combiner that the combiner is, use that when calling the macro (/macro combine.mac (combiner) "whe!" "whe!" "doh!" "I'm not homer")

[Bonker]

How can I get the macro to locate combiners that use multiple words in identifying themselves.

I /identify the jeweller's kit and get "Jeweller's Kit"; same thing with deluxe sewing kit.

When I type:

/macro combine jeweller's kit "malachite" "gold bar"

the macro cannot find the combiner "jeweller's" (does not recognize kit) and ends. I've also tried to enclose the combiner in quotes but it still only looks for the first word.


Bonkers
Any ideas?

[lifewolf]

How can I get the macro to locate combiners that use multiple words in identifying themselves.

I /identify the jeweller's kit and get "Jeweller's Kit"; same thing with deluxe sewing kit.

When I type:

/macro combine jeweller's kit "malachite" "gold bar"

the macro cannot find the combiner "jeweller's" (does not recognize kit) and ends. I've also tried to enclose the combiner in quotes but it still only looks for the first word.


Bonkers
Any ideas?

Use Quotes around items/terms with more than one word. Such as...

/macro combine "Jeweler's Kit" "Fire Opal" "Enchanted Silver Bar"

Also you could even use..

/macro combine [jewel OR jeweler's OR kit] [fire OR opal] [enchanted OR silver OR bar]

As long as the macro can find the text you typed for whatever parameter in the name of the item you want it to combine (or container to use) AND enough of the item/container name so it wont combine erronous materials.

Such as using fish and wing for making fishrolls in a spit will also attempt to combine your fishbone earing and a batwing.

[dafyd]

I have a couple questions re this :

1) is this supposed to only make 1 item at a time or is it supposed to go on till it has no, further material?

(It seems to me to be only combining 1 item at a time, then leaving that item on my cursor.)

2) how easy would it be to place the resulting combine into a specific container for further combine ie

10 spirit of the wolf potions into a bearskin potion bag for combining again?

[serberus]

I've updated the combine.mac, there were a few things that bothered me so I changed them, specifically:

-If you had two items with similar names, e.g. 'soda' and 'soda water', it would frequently pickup the wrong one, even if you layed out your bags correctly (because it auto drops the produced item infront of the other items).

All items are now specific unless you prefix them with a #, for example
/macro combine oven "#meat"
will pick up any item with meat in it
/macro combine oven "wolf meat" will only pick up wolf meat, even if a "wolf meat kabab" is infront of it

-changed it so when you used containers such as "Make Poison" it now actually finds them and doesn't just search for "make", the container needs to be in speech marks if it has a space in it

-it would leave items in the container if it had already put them there, then couldn't find the next item and subsequently exited, it now cleans the pack before it leaves, prevents leaving your blue diamond gear in the forge etc.

-it should be faster than before, it doesn't use delays heavily, it just keeps on trying to do something until it realises it's done it, this could lag your computer badly, I also "#turbo"ed the macro, which could be removed if it's causing too much lag for you.

-items shouldn't get stuck on the mouse anymore, or not as much as they did, that's part of the above, it keeps looping until the pack is clear and the cursor is clear (after a small delay)

Code: Select all

| - Combine.mac 
| 
|Supports up to 9 items to combine in container 
| Usage is /macro combine "container" "item 1" "item 2" "item 3" Item 4" etc 
|   i.e. /macro combine tinkering "firewater" "bat wing" "metal shaft" 
| 
| Update: Now supports environmental containers, i.e. forge, pottery etc. 
#turbo

Sub Main 

   /cleanup 
   /call FindCombiner "$p0" 
   /if $v10<=7 /call OpenInv 
   /if $v10==8 /call OpenEnv 
   /if $v10==99 { 
                 /echo "Cannot find container-Aborting" 
                 /end 
                } 

   :MakeItem 
      /sendkey down ctrl 
      /if "$p1"~~# {
         /finditem similar "$right($calc($strlen("$p1")-1),"$p1")"
         /goto :Continue
      }
      /finditem "$p1"
      :Continue
      /if $find()==FALSE /goto :Done 
      /click left $v20 0 

      /if "$p2"=="" /goto :Combine 
      /if "$p2"~~# {
         /finditem similar "$right($calc($strlen("$p2")-1),"$p2")"
         /goto :Continue2
      }
      /finditem "$p2"
      :Continue2
      /if $find()==FALSE /goto :Done 
      /click left $v20 1 

      /if "$p3"=="" /goto :Combine 
      /if "$p3"~~# {
         /finditem similar "$right($calc($strlen("$p3")-1),"$p3")"
         /goto :Continue3
      }
      /finditem "$p3"
      :Continue3
      /if $find()==FALSE /goto :Done 
      /click left $v20 2 

      /if "$p4"=="" /goto :Combine 
      /if "$p4"~~# {
         /finditem similar "$right($calc($strlen("$p4")-1),"$p4")"
         /goto :Continue4
      }
      /finditem "$p4"
      :Continue4
      /if $find()==FALSE /goto :Done 
      /click left $v20 3 

      /if "$p5"=="" /goto :Combine 
      /if "$p5"~~# {
         /finditem similar "$right($calc($strlen("$p5")-1),"$p5")"
         /goto :Continue5
      }
      /finditem "$p5"
      :Continue5
      /if $find()==FALSE /goto :Done 
      /click left $v20 4 

      /if "$p6"=="" /goto :Combine 
      /if "$p6"~~# {
         /finditem similar "$right($calc($strlen("$p6")-1),"$p6")"
         /goto :Continue6
      }
      /finditem "$p6"
      :Continue6
      /if $find()==FALSE /goto :Done 
      /click left $v20 5

      /if "$p7"=="" /goto :Combine 
      /if "$p7"~~# {
         /finditem similar "$right($calc($strlen("$p7")-1),"$p7")"
         /goto :Continue7
      }
      /finditem "$p7"
      :Continue7
      /if $find()==FALSE /goto :Done 
      /click left $v20 6

      /if "$p8"=="" /goto :Combine 
      /if "$p8"~~# {
         /finditem similar "$right($calc($strlen("$p8")-1),"$p8")"
         /goto :Continue8
      }
      /finditem "$p8"
      :Continue8
      /if $find()==FALSE /goto :Done 
      /click left $v20 7

      /if "$p9"=="" /goto :Combine 
      /if "$p9"~~# {
         /finditem similar "$right($calc($strlen("$p9")-1),"$p9")"
         /goto :Continue9
      }
      /finditem "$p9"
      :Continue9
      /if $find()==FALSE /goto :Done 
      /click left $v20 8

      :Combine 
        /sendkey up ctrl 

      :WaitCombine 
        /click left $v20 combine
        /delay 2
        /if $pack($v10,empty)==FALSE /goto :WaitCombine 

      :ClearCursor
        /click left auto
        /delay 5
        /if "$cursor()"=="TRUE" /goto :ClearCursor

   /goto :MakeItem 

   :Done 
    /sendkey up ctrl 
    /call CleanPack
    /cleanup 


/return 

Sub OpenInv 
   /varset v20 "pack $v10" 
   /cleanup 
   /click right inv $v10 
   /if $pack($v10,empty)==FALSE /call CleanPack 
/return 

Sub OpenEnv 
   /cleanup 
   /varset v10 e 
   /varset v20 enviro 
   /face item 
   /click left item 

   :WaitOpen 
   /if $pack($v10,open)==FALSE /goto :WaitOpen 

   /delay 5 
   /if $pack($v10,empty)==FALSE /call CleanPack 
/return 


Sub CleanPack 
   /sendkey down shift 
   /varcalc v2 $pack($v10,slots)-1 

   /for v1 0 to $v2 
   /click left $v20 $v1 
   /click left auto 
   /next v1 
   /sendkey up shift 
/return 


Sub FindCombiner 
   /varset v10 99 
   /for v99 0 to 7 
      /if "$pack($v99,combine)"==$p0 /varset v10 $v99 
   /next v99 
   /if $v10==99 { 
                /itemtarget $p0
                /if n $distance(item)<=20 /varset v10 8 
                } 
/return $v10

[SkackDuck]

I am trying to use a brew barrel to make an item, using your latest macro.

I am at a brew barrel, I type...

/macro combine "brew barrel" "water flask" "allspice" "shotglass" "brown algae"

I target the brew barrel, face it, open it...

then get the message "You must place items in this object in order to create somthing new."

So it looks like for some reason it is not putting any items in the barrel.

The same thing happened with the macro on page one of this thread.

Any ideas?

Win XP pro SP1, IRC-20021201, in EQW, being sure the cursor is set for EQ.

[SkackDuck]

It also still cannot find "Make Poison" nor "Mortar and Pestle"