The (Mostly) Complete Raiding Druid Package v7.23

Cr4zyb4rd · Post by **Cr4zyb4rd** » Sun Nov 28, 2004 5:00 pm

Also fixed the .Range check for all spells so that it references your spellbook instead of just checking the first spell that comes up in the DB.

I see this, but then you go on to do ${Spell[foo].Mana} and such, risking the same type of problems (if not for your own macro, then for anybody that copies your code). My suggestion is you make explicit defines at the top of the macro for MySnarespellMana MySnarespellDuration or somesuch (afcleric does something like this..i've found it annoying)...or you could go with MySnarespellID and use Spell[ID] for everything. The first uses a bit more memory and (IMHO) makes things a bit more cluttered in general while offering the best execution time, whereas IDs might seem obscure to a macro novice. Both offer fairly significant execution speed improvements over the double-lookup every time you Me.Book[Book[foo]].Bar

A_Druid_00 · Post by **A_Druid_00** » Sun Nov 28, 2004 5:13 pm

Awesome, thanks for the tip. I'll go ahead and rework it tonight after raiding, hell maybe even during!

MacRogue · Post by **MacRogue** » Sun Nov 28, 2004 6:44 pm

Just wondering cause its something that happened to me using the macro, does the assistma have a corpse check built in? i had the macro trying to assist off my corpse one night but that was a few versions back

A_Druid_00 · Post by **A_Druid_00** » Sun Nov 28, 2004 7:08 pm

MacRogue wrote:Just wondering cause its something that happened to me using the macro, does the assistma have a corpse check built in? i had the macro trying to assist off my corpse one night but that was a few versions back

Try changing:

Code: Select all

  /if (!${Spawn[${MA1}].ID}) /goto :AssistMA2

To:

Code: Select all

  /if (!${Spawn[pc ${MA1}].ID}) /goto :AssistMA2

That should do it. Just make sure to do the same thing for the MA2 and MA3 check.

Cr4zyb4rd · Post by **Cr4zyb4rd** » Sun Nov 28, 2004 9:25 pm

set the MA/SA etc ID at the time they're set (echo ${Spawn[ID].Name} at that time, to give the user feedback and tripple check to make sure they're right) and ONLY use the ID to refer to them. If they die/zone get a new ID. *always always always* use IDs when dealing with spawns. Any other way is just asking for trouble.

MacRogue · Post by **MacRogue** » Sun Nov 28, 2004 9:57 pm

Cr4zyb4rd wrote:set the MA/SA etc ID at the time they're set (echo ${Spawn[ID].Name} at that time, to give the user feedback and tripple check to make sure they're right) and ONLY use the ID to refer to them. If they die/zone get a new ID. *always always always* use IDs when dealing with spawns. Any other way is just asking for trouble.

Ok and for those who know nothing about macroing how is that done? =)
(whats the proper formatting?)

Cr4zyb4rd · Post by **Cr4zyb4rd** » Sun Nov 28, 2004 10:17 pm

Ok and for those who know nothing about macroing how is that done? =)
(whats the proper formatting?)

Well, I assumed a_d would do it, what with it being his macro and all

If you want to see an example, look at afcleric. It goes through great pains to make sure the MT is targetted.

I wish /assist took an ID as argument, because the only way now to 100% guarentee you're assisting the right person is to do "/target joe ; /delay some_semi-random_ammount ; /assist", but to do it would require either detouring and messing with eqgame's assist function, or "spoofing" an assist packet to the server.

A_Druid_00 · Post by **A_Druid_00** » Mon Nov 29, 2004 7:05 am

Yeah, I'll look at how AFCleric does it. The only reason I did it the way I did was because I couldn't get it to stop screwing up when the MA/SA/TA's ID changed, it was in my original version.

A_Druid_00 · Post by **A_Druid_00** » Thu Dec 02, 2004 4:35 pm

Ini file has been added. Layed some of the groundwork for Tank/CH healing too for groups. I'll probably add it into the next build; though I'm pretty spent on getting dobuffs and self buffing wokring right over the past few days.

MacRogue · Post by **MacRogue** » Fri Dec 03, 2004 2:07 pm

Sweet ya got the INI in =) i'll get to breaking things asap =)

A_Druid_00 · Post by **A_Druid_00** » Fri Dec 03, 2004 2:39 pm

Might want to grab the latest feedme and buffbeg inc files too if you use them at all. I've made some pretty big changes to both, ramdom buffbeg messages are the best!

A_Druid_00 · Post by **A_Druid_00** » Fri Dec 03, 2004 4:13 pm

Changed up the DoBuffIndoors and SelfBuffIndoors ini toggles. It's now 1 for Indoor/Outdoor spells and 0 for Outdoor only. Also made separate events for no mount zones and outdoor zones.

A_Druid_00 · Post by **A_Druid_00** » Sun Dec 05, 2004 9:41 pm

Fixed what I think is the last of my sit aggro logic issues. SitTimer wasn't being checked before memming spells for buff requests or self buffing. It now checks for the spell gem before casting, and waits for the Sittimer to hit 0 before sitting to mem it.

MacRogue · Post by **MacRogue** » Tue Dec 07, 2004 4:57 am

Well got the new one, getting a error...
/declare 'SnareSpell' failed. Name already in use.
RDDeclares.ini@105 (RDDeclares):/declare SnareSpell string outer
rd.mac@24 (Main)/call RDDeclares

Seee I broke it already =)
'
edit: Also when paused wont let me take anything out of my bags... whats doing that?

A_Druid_00 · Post by **A_Druid_00** » Tue Dec 07, 2004 7:57 am

Snarespell is only declared once in the macro, no idea why it's showing as being declared already. Unless you had it declared globally at some point, in which case all you'd have to do is log out and back in to fix that.

As far as not being able to take items out of bags, there's nothing in my mac that would be stopping that. I'll try it out at lunch this afternoon and see if I have the same issue.

I've also gotten DoTs and Debuffs moved to the ini now, will be posting it after some testing and fine tuning. I plan to add an epic 1.5 clicky toggle next which will trigger on any Named NPCs you fight if the 10 minute timer is up. After that I think I'm going to throw in some Spirit of the Wood logic followed by tank healing.