Genbot v13.3.2 [Updated 08/08/2004] Slim trim code rewrite!

Fippy · Post by **Fippy** » Fri Aug 13, 2004 1:38 pm

OK my buffs times were of a bit due to my Blessed Coldain Prayer Shawl since it increase most buffs by 20% i did a quick and dirty fix to botspell.inc to just multiply the spell duration by 1.2 (see the third line below.

Code: Select all

      /if (!${BuffDuration}) { 
         /if (${BuffType.Arg[1,-].Equal[spell]}) { 
            /varset BuffDuration ${Math.Calc[${Spell[${BuffCast}].Duration.TotalSeconds}*1.2]}s 
        } else /if (${BuffType.Arg[1,-].Equal[item]}) { 
           /varset BuffDuration ${FindItem[${BuffCast}].Spell.Duration.TotalSeconds}s 
        } else /if (${BuffType.Equal[alt]}) { 
           /varset BuffDuration ${AltAbility[${BuffCast}].ReuseTime}s 
        } 
      }

Charisa · Post by **Charisa** » Fri Aug 13, 2004 4:43 pm

The listing of files on this still lists personal.inc (which you said has now been moved into genbot.mac and botcommon.inc. You also still have botshortcut.inc here but botshorcut isn't referrenced anywhere in these files, has that been removed or is it just missing somewherre?

Charisa

Fippy · Post by **Fippy** » Fri Aug 13, 2004 5:43 pm

I think Vexix just forgot to remove them from the list. personal.inc is covered in botcommon.inc and genbot.mac, botshortcut.inc is not needed as its code is in the other .inc's now.

izusaga · Post by **izusaga** » Fri Aug 13, 2004 8:07 pm

Does this mean I'm the only one who's clericbot does all healing spells twice no matter what HP is at? Getting aggitated having cleric CH at 30%, having CH land, then having her immediately CH again at 100% health on tanks.. then having double SR's on casters. Not doing it to buffs, just heals, and no; lag-free enviroment, trust me.

Charisa · Post by **Charisa** » Fri Aug 13, 2004 8:34 pm

Mine has never done it, which version of genbot you using? I finally just got this one, I was running about a version or two ago until tonight.

Right now I'm head deep in figuring out how to get some of the VIP stuff to work with this as well as a converted forage macro. It shouldn't be hard to get it in there, just a case of figuring out where things go with the new layout :)

Anyhow that all said, I'll test out this version tonight to see if I have it duplicating heals.

Vexix · Post by **Vexix** » Fri Aug 13, 2004 11:35 pm

Thanks for the buff duration mod, Fippy. I'll put something similar tied into the .ini into the next release.

Yup, botshortcuts.inc and personal.inc are both gone. I've updated the first page to reflect that now.

Izusaga -- Yup, no problem with double heals here. :/ Just tested last night. Might be that struct thing Frabtik mentioned? Lemme know if you still have the issue with the next version of MQ2 that comes after this patch.

Frabtik -- I read over your mail again. Gotta add more punctuation and paragraphs, man.

I'll take a look at enrage when I get a chance and see what the issue is.

If I understand correctly, part of the reason that upgrading is a pain for you is that you change code within genbot outside of the botcommon.inc, personal.inc, etc, right? I've tried to make that kind of thing unnecessary with the Events code. Is there any particular place in the base genbot code you would like an event call added so you don't have to touch the base code?

By the way, I got a chance to test the new stopforheals toggle with a manastone, and it works fine. It wasn't helpful for faster spells, at least on my system with 3 chars boxed on one PC, but it does interrupt the spell and start up the heal if the original spell takes long enough. Only really saw it come into effect by casting a port spell and seeing it interrupted. Does it work better for others with faster comps?

Still haven't been able to test stopifhealed toggle. Working on getting another healer in the zone and then trying some tests.

--Vexix

A_Druid_00 · Post by **A_Druid_00** » Sat Aug 14, 2004 1:38 am

Haven't seen it perform too badly 2 boxing on a single comp. I just went through a lot of fine tuning on my 2 window setup this week though, so I think Genbot and EQ will behave a lot better than it has. Overall GB is a mighty fine piece of work for a generic bot macro. I'd have to say it does a decent job with my druid now that I have him set up efficiently. It's also awesome for tanks; because button mashing sucks ass.

gus · Post by **gus** » Sat Aug 14, 2004 4:25 am

Trying to update to this version now. I hope long term plan is to move all .ini options to the new "multiwordformat" from the old "MultiWordFormat" ? Right now it's an unsightly mixture of styles.

I use a set of sed scripts to configure .ini files for the classes I bot. I've got to update them with these new option names. :)

--gus

Vexix · Post by **Vexix** » Sat Aug 14, 2004 8:16 am

Aww. . . Unsightly?

Not sure whether to convert to the new multiword format. That change came about since I used the actual names for toggles to set the toggles in the .ini. The motivation to change over to lower caps was to let people know they didn't have to use caps for genbot. It's caps insensitive. Also, in the genbot doc, I use lower caps for all commands, so people don't think that's necessary. Then, I use TargetName type stuff for things that should be filled in by the appropriate value.

If it's not really a big deal to use lower caps so people don't type them when using commands, then I can put the MultiWord format back into the .ini. What are people's thoughts?

--Vexix

gus · Post by **gus** » Sat Aug 14, 2004 8:20 am

Ok, got it to work, did a couple LDoN adventures, seems fine. Switched over to advpath following, works nice with judice use of 'moveto me' to get bots in proper spot for anchor.

I tried to use the new single bot only feature "Bot command", but it only worked when I said it group, but not via "/i say". Also, single person IRC "/i msg Bot command' tells don't seem to work either. That's okay, as long as I can call out buffs at some point with "/i msg Bot buff ..." so the other's don't all spam the channel because they don't have the buff. Will see if I can work out proper event/chat handle modifications to make those work.

I gotta figure out a solution for the cleric going oom because of mistargeted group member heals, nearly wiped again today because of that.

--gus

gus · Post by **gus** » Sat Aug 14, 2004 12:18 pm

Daeas posted this on page 3... shortcuts are not working on named targets.

For example, if I say 'haste me' bot says 'I don't know what to cast on."

I tried following syntax in .ini

Code: Select all

[SHORTCUTS]
haste=snt Alacrity

This one after looking at the Shortcut sub:

Code: Select all

[SHORTCUTS]
haste=snt Alacrity NameS

Gets 'Spell: Alacrity me not found in your book'.

Will post fix if I can figure it out.

--gus

Vexix · Post by **Vexix** » Sat Aug 14, 2004 12:28 pm

Correct format is:

haste=snt Alacrity on NameS

Then call haste DudeName.

Changed a while back. Was that the issue?

What's going on with healing the wrong player? Haven't heard about that before.

--Vexix

gus · Post by **gus** » Sat Aug 14, 2004 12:44 pm

Doh, thanks Vexix, I just figured it out as 'on NameS' while debugging. Should get that in the GenDoc.txt, it's non-obvious

Healing is fine, there's issue with getting target of correct PC in group when one group memeber's name is substring of other group member's name. It's mostly my issue. I'll figure it out and post something.

Ahh, one other issue I noticed. Sometimes after melee is done and bot runs back to anchor spot, the bot will sit in one spot and spin like a top, one cycle every 1-2 seconds or so. Like he can't find his anchor, but is standing right on top of it? Or is trying to face particular direction and maybe the angle deltas over turn every time (shit too far, turn 360, shit too far, turn 360, ...)? Speculation on my part here.

To fix, I drive the bot and have him run forward until he takes control to run back to anchor.

--gus

gus · Post by **gus** » Sat Aug 14, 2004 1:22 pm

Ok, this'll let '/i msg' get processed. Remove the IRC event and replace with the following. Notice the neat use of the 2nd event arg.

Code: Select all

#event IRCMSG       "[#1#(msg)] #2#"
#event IRCSAY       "<#1#> #2#"

Code: Select all

Sub Event_IRCMSG(string IRCText,string IRCSender,string Command)
   /if (${String[ ${MasterList.Lower} ].Find[ ${IRCSender.Lower} ]}) {
      /call ExecCommand "${Command}"
   }
/return

Sub Event_IRCSAY(string IRCText,string IRCSender,string Command)
   /if (${String[ ${MasterList.Lower} ].Find[ ${IRCSender.Lower} ]}) {
      /call ExecCommand "${Command}"
   }
/return

--gus

gus · Post by **gus** » Sat Aug 14, 2004 2:05 pm

Update: Ignore this one for now. There's an issue with it. Need to work on it more.

Ok, tracked down the healing issue. Has to do with the 'RefineTarget' feature of spell casting. While the heal code does use a target of the form 'id ####', the refine code wants to convert it into a 'pc name' form, which is less than unique. What works for me is the following changed to RefineTarget sub

Change the line:

Code: Select all

      /varset RFTarget pc ${NearestSpawn[pc ${RFTarget}].Name}

To:

Code: Select all

      /varset RFTarget pc ${NearestSpawn[pc ${RFTarget}].Name} ${RFTarget}

Which creates a target of the form 'pc name id ####'. If you think about it, this is more a true "refine" where as the original code is more of a "replace".

--gus