Genbot Version 12 Ready

frabtik · Post by **frabtik** » Sat May 01, 2004 9:09 am

Don't think varcat is valid anymore, also I like having quotes around the spellnames better but haven't figured out how to get them in there yet.

Code: Select all

Sub Do-reportbuffs  
   /declare myBuffs string local Buffs: 
   /declare counter int local 
   /for counter 0 to 15 
       /varcat myBuffs " ${Me.Buff[${counter}]}" 
   /next counter 
   /call ChatOut 1 ${MasterName} "${myBuffs}" 
/return

Code: Select all

Sub Do-reportbuffs  
   /declare myBuffs string local Buffs: 
   /declare counter int local 
   /for counter 1 to 15 
       /if (${Me.Buff[${counter}].ID}) /varset myBuffs ${myBuffs} [ ${Me.Buff[${counter}]} ]
   /next counter 
   /call ChatOut 1 ${MasterName} "${myBuffs}" 
/return

LordGiddion · Post by **LordGiddion** » Sat May 01, 2004 9:38 am

Badger999: not sure where you having problems, make sure your MQ2 Zip is up to date, Lax fixed some problems with 2d array this week, and that maybe your problem.

spektralkat: I'll have to do more testing to kill the chaincast, sorry that it's still buggy.

frabtik thanks for the catch - to get the quotes try this

Code: Select all

Sub Do-reportbuffs  
   /declare myBuffs string local Buffs:
   /declare counter int local
	/for counter 0 to 15
   	 /if (${Me.Buff[${counter}].ID}) /varset myBuffs ${myBuffs} "${Me.Buff[${counter}]}"
   /next counter
   /call ChatOut 1 ${MasterName} "${myBuffs}"
/return

Fuergrissa · Post by **Fuergrissa** » Sat May 01, 2004 11:33 am

alots been fixed and working great, buff is still crashing here is the text

buff casts great but crashes when its passed to the bufflist,

Code: Select all

/varcalc failed, variable 'BuffList[1,3]' not found
botcore.inc@602 (Event_timer(string TimerName,string OldValue)): /varcalc BuffList[${counter},3] ${BuffList[${counter},3]}-1

TRex · Post by **TRex** » Sat May 01, 2004 11:36 am

Everytime the Bot calls a subroutine, is says "Subroutine xxxx wasn't found.

I checked the lastest versions, i am using the lastest compile.

omper · Post by **omper** » Sat May 01, 2004 11:51 am

also having that problem
with the varcalc thingy..

gus · Post by **gus** » Sat May 01, 2004 12:37 pm

The 'reload' command is not working at the moment.

Primarily because Param0, etc. are not being set when /macro is called via a macro. But my guess is that'll be going away soon.

Looking at the MQ2 source code (MQ2MacroType::GetMember in MQ2DataTypes.cpp), it would appear the ${Macro} TLO is not fully implemented yet, in particular ${Macro.Params}.

LG: Maybe add a Genbot TODO item for this so we can get it working when MQ2 has the implementation in place?

LG: Not that I use this feature, but I don't believe reload properly handles the case where the initial /macro start had multiple masters listed.

Gus

newb-n-training · Post by **newb-n-training** » Sat May 01, 2004 12:49 pm

Problem in botcore line 371:

Code: Select all

/chat [color=red]#[/color]${ChatInChannel} ${ChatText}

Had to remove the # in order for it to work.

Dulapore · Post by **Dulapore** » Sat May 01, 2004 12:59 pm

For the reload command, try out this in botcore.inc. I haven't tried it in game but it should work.

Code: Select all

nm, this idea wouldn't work.

If that doesn't work, perhaps make ${MasterName} global?

LordGiddion · Post by **LordGiddion** » Sat May 01, 2004 1:14 pm

Fuergrissa & omper Not sure why that's happening, the logic looks all right to me as far as I see the only way BuffList[1,3] isn't found is if the buff spell that is cast isn't returning a duration. It's gonna have to be something I test when I have time. Tell me is this bug happening 5 seconds after you cast the buff or is it sooner then that?

TRex I'm not sure why your having problems, what command is this happening with? Most commands seem to be working for others.

gus & Dulapore reload will require an implimentation of global vars. Not a big deal I'll make sure it gets in the next update

Nightshift · Post by **Nightshift** » Sat May 01, 2004 1:21 pm

LordGiddion wrote:

Nightshift: with your fix none of the timer logic works - but doesn't error - I fixed the actual error and it should work now.

I appologize, I fixed it correctly about 3 hours later and was so tired I fell asleep at my desk, just wanted to close my eyes. still learning and but not very fast.

NightShift

gus · Post by **gus** » Sat May 01, 2004 1:43 pm

The 'stop' command does not seem to be working for me when a bot is told to do a shortcut spell and no target is given (I've nothing targeted as well so it cannot /assist me). The ShortCut sub loops until a target is found and checks for ${BreakOut}. The bot refuses to respond to any more commands while it tries to process the shortcut command.

Problem seems to be that the 'stop' command was never actually processed by the bot. This is where my lack of understanding of how MQ2 does (or doesn't do) multi-threading comes into play. My debugging tells me that Event_chat never got called for the 'stop' command. Because genbot.mac never got a chance to call /doevent? Why not? Because MQ2 was busy calling the ShortCut sub?

What is supposed to happen? What is the threading/event model in MQ2 has for macros?

Sorry I'm not able to assist with this one more.

Gus

Nightshift · Post by **Nightshift** » Sat May 01, 2004 1:58 pm

LordGiddion wrote:Fuergrissa & omper Not sure why that's happening, the logic looks all right to me as far as I see the only way BuffList[1,3] isn't found is if the buff spell that is cast isn't returning a duration. It's gonna have to be something I test when I have time. Tell me is this bug happening 5 seconds after you cast the buff or is it sooner then that?

TRex I'm not sure why your having problems, what command is this happening with? Most commands seem to be working for others.

gus & Dulapore reload will require an implimentation of global vars. Not a big deal I'll make sure it gets in the next update

I just did a test after getting all the newest versions of genbot and I have the latest version of MQ.

This happens after a count of 5 seconds after the spell has been cast and will continue to say this until I end the macro.

The spell being cast is Shield of Blades, but I tested with several spells, all do the same thing.

If I can test it a certain way, let me know.

NightShift

newb-n-training · Post by **newb-n-training** » Sat May 01, 2004 2:09 pm

Was waiting to post after I fixed it but can't figure this one out. Very strange behavior:

Using AutoBehind, when the mob gets out of range, the bot occasionally won't get behind. However, if I notice the bot not behind the mob and I tap the fwd key once, the bot goes back into the getbehind mode and all's well for a while.

Not sure if there's a problem in Do-getbehind, Do-behind, or perhaps some sub which should be calling them but isn't.

Still workin on this one but wondered if anyone else experienced the same issue.

Working off old Botcombat ... testing again with 12.22

LordGiddion · Post by **LordGiddion** » Sat May 01, 2004 2:18 pm

gus I'll check it out, I might need to add a /doevents to one of the loops so that chat processing happens, or I might need to set it to auto breakout if it loops too many times.

Nightshift thanks for the info, that will help me find the problem not sure when I can look at it though.

newb-n-training thanks for the info, I may have broken some of the math when I did the update I'll have to see if I can figure it out

Fuergrissa · Post by **Fuergrissa** » Sat May 01, 2004 2:19 pm

Fuergrissa & omper Not sure why that's happening, the logic looks all right to me as far as I see the only way BuffList[1,3] isn't found is if the buff spell that is cast isn't returning a duration. It's gonna have to be something I test when I have time. Tell me is this bug happening 5 seconds after you cast the buff or is it sooner then that?

I am using cleric/warrior combo and asking for resolution and armor of faith, also get it when i ask for aanya's quickening from enc.

i get 5 seconds after cast and it repeats error message again and again untill i end or it ends itself. let me know if i can put any Echos in for you to test, also IF ANYONE has "Buff" working please post to confirm, is it a global issue of just a few of us.

Genbot Version 12 Ready

Mostly working

my previous post, ingnore it.

i concur