About to explode...

[Droodie]

My treasured kick.mac doesnt work anymore. It is a ten liner doing the simplest things. DO you have a target? If yes, then ARE you in combat, if yes then FLYING KICK and DISARM.

I pretty much suck at programming and ruthlessly stole the parts of code needed. This is how I figure the macro should look like since the data to param change thingy happened. The if statements below are taken from the rogue macros posted in macro depot, but when I run this I get parse errors and "is not a numeric" blah blah errors.

If anyone would just tell me what is wrong and show me how it should be, I would be ever so happy as manually pushing the flying kick button is slowly killing my left wrist.

Code: Select all

Sub Main
	:Mainloop
		/newif ${Bool[${Target}]}==1 {
			/newif $(Me.Combat)==1 {
        			/newif $char(ability,"Flying Kick")>0 /doability "Flying kick"
 				/newif $char(ability,"Disarm")>0 /doability "Disarm
			}
   		}
	/goto :Mainloop
/return

[dman]

Try

Code: Select all

Sub Main
  :Mainloop
     /newif ${Target.ID} && ${Me.Combat} {
        /newif ${Me.AbilityReady["Flying Kick"]} /doability "Flying Kick"
        /newif ${Me.AbilityReady[Disarm]} /doability Disarm
     }
   /goto :Mainloop
/endmacro

[Zazoot]

Code: Select all

Sub Main 
   :Mainloop 
      /newif ${Bool[${Target}]}==1 { 
         /newif [color=red]$(Me.Combat)==1[/color] { 
                 /newif [color=red]$char(ability,"Flying Kick")[/color]>0 /doability "Flying kick" 
            /newif [color=red]$char(ability,"Disarm")[/color]>0 /doability "Disarm 
         } 
         } 
   /goto :Mainloop 
/return

i could be mistaken but isnt /newif meant to be used with the new datatypes and /if for the old ones

right?

try this :

Code: Select all

Sub Main 
   :Mainloop 
      /newif ${Bool[${Target}]}==1 { 
         [color=red]/if[/color] $(Me.Combat)==1 { 
                 [color=red]/if[/color] $char(ability,"Flying Kick")>0 /doability "Flying kick" 
            [color=red]/if[/color] $char(ability,"Disarm")>0 /doability "Disarm 
         } 
         } 
   /goto :Mainloop 
/return

[Zazoot]

just use what dman suggested because eventually the old $() stuff will be gone :)

[Lax]

/newif is simply put a replacement for /if. it doesnt care if you're using old or new, but you will not be able to do string comparisons with it in the old system.

[wassup]

You had some things wrong with how you were trying to use the new system.

I am pretty sure this will work:

Code: Select all

Sub Main 
   :Mainloop 
      /newif ( ${Target.ID} && ${Me.Combat} ) { 
            /newif ${Me.AbilityReady[Flying Kick]} /doability "Flying kick" 
            /newif ${Me.AbilityReady[Disarm]} /doability "Disarm"
      } 
   /goto :Mainloop 
/return

Edit: Oops... sorry dman... I didn't even see your post...

[Droodie]

Thank you Wassup and all. It works perfectly, you guys are all primo elite! :D