Help with Instrument switching

Need some help with that macro you're working on or aren't quite sure how to get your macro to do something? Ask here!

Moderator: MacroQuest Developers

lpmko
orc pawn
orc pawn
Posts: 17
Joined: Thu Jun 20, 2002 11:00 pm

Help with Instrument switching

Post by lpmko » Mon Mar 08, 2004 6:18 pm

[code]
#Event Percussion "[MQ2] Percussion"
#Event String "[MQ2] String"
#Event Brass "[MQ2] Brass"
#Event Wind "[MQ2] Wind"
#Event Sing "[MQ2] Sing"


Sub Main
:MainLoop
/doevents
/delay 0
/goto :MainLoop
/endmacro

Sub Event_Percussion
/call FixInventory
/click left pack 7 4
/click left primary
/cleanup
/click left pack 7 3
/click left secondary
/cleanup
/return

Sub Event_Wind
/call FixInventory
/click left pack 7 6
/click left secondary
/cleanup
/return

Sub Event_String
/call FixInventory
/click left pack 7 5
/click left secondary
/cleanup
/return

Sub Event_Brass
/call FixInventory
/click left pack 7 7
/click left secondary
/cleanup
/return

Sub Event_Wind
/call FixInventory
/click left pack 7 6
/click left secondary
/cleanup
/return

Sub Event_Sing
/call FixInventory
/click left pack 7 2
/click left primary
/click left pack 7 3
/click left secondary
/cleanup
/return

Sub FixInventory
/if $invpanel==FALSE /press i
/click right inv 7
/if $equip(Primary)==TRUE {
/click left primary
/click left pack 7 0
/autoinventory
}
/if $equip(Secondary)==TRUE {
/click left secondary
/click left pack 7 1
/autoinventory
}
/if $item(7,2,name)!~"Symphonic" {
/finditem similar "Symphonic"
/click left pack 7 2
} else

/if $item(7,3,name)!~"Troubadour" {
/finditem similar "Troubadour"
/click left pack 7 3
}
/if $item(7,4,name)!~"Trueborn" {
/finditem similar "Trueborn"
/click left pack 7 4
}
/if $item(7,5,name)!~"Orcish Lute" {
/finditem similar "Orcish Lute"
/click left pack 7 5
}
/if $item(7,6,name)!~"Minotaur Horn" {
/finditem similar "Minotaur Horn"
/click left pack 7 6
}
/if $item(7,7,name)!~"Torin's" {
/finditem similar "Torin's"
/click left pack 7 7
}
/return[/code]

This is my switch weapon macro and it does not work very well...
I am getting errors every time i use the $item

ml2517
a grimling bloodguard
a grimling bloodguard
Posts: 1216
Joined: Wed Nov 12, 2003 1:12 am

Post by ml2517 » Mon Mar 08, 2004 7:43 pm

I didn't totally check all of the syntax that you were using but youru should be surrounding the $item(x,x,name) with quotes. Try this:

Code: Select all

 

#turbo 50
#Event Percussion "[MQ2] Percussion" 
#Event String "[MQ2] String" 
#Event Brass "[MQ2] Brass" 
#Event Wind "[MQ2] Wind" 
#Event Sing "[MQ2] Sing" 


Sub Main 
:MainLoop 
/doevents 
/delay 0 
/goto :MainLoop 
/endmacro 
/return

Sub Event_Percussion 
/call FixInventory 
/click left pack 7 4 
/click left primary 
/cleanup 
/click left pack 7 3 
/click left secondary 
/cleanup 
/return 

Sub Event_Wind 
/call FixInventory 
/click left pack 7 6 
/click left secondary 
/cleanup 
/return 

Sub Event_String 
/call FixInventory 
/click left pack 7 5 
/click left secondary 
/cleanup 
/return 

Sub Event_Brass 
/call FixInventory 
/click left pack 7 7 
/click left secondary 
/cleanup 
/return 

Sub Event_Wind 
/call FixInventory 
/click left pack 7 6 
/click left secondary 
/cleanup 
/return 

Sub Event_Sing 
/call FixInventory 
/click left pack 7 2 
/click left primary 
/click left pack 7 3 
/click left secondary 
/cleanup 
/return 

Sub FixInventory 
/if $invpanel==FALSE /press i 
/click right inv 7 
/if $equip(Primary)==TRUE { 
    /click left primary 
    /click left pack 7 0 
    /autoinventory 
} 
/if $equip(Secondary)==TRUE { 
    /click left secondary 
    /click left pack 7 1 
    /autoinventory 
} 
/if "$item(7,2,name)"!~"Symphonic" { 
    /finditem similar "Symphonic" 
    /click left pack 7 2 
} 
/if "$item(7,3,name)"!~"Troubadour" { 
    /finditem similar "Troubadour" 
    /click left pack 7 3 
} 
/if "$item(7,4,name)"!~"Trueborn" { 
    /finditem similar "Trueborn" 
    /click left pack 7 4 
} 
/if "$item(7,5,name)"!~"Orcish Lute" { 
    /finditem similar "Orcish Lute" 
    /click left pack 7 5 
} 
/if "$item(7,6,name)"!~"Minotaur Horn" { 
    /finditem similar "Minotaur Horn" 
    /click left pack 7 6 
} 
/if "$item(7,7,name)"!~"Torin's" { 
    /finditem similar "Torin's" 
    /click left pack 7 7 
} 
/return