NEW FEAT: /whofilter invisible [on|off]

[MacroFiend]

This will allow you to toggle the display of invisible mobs in the /who lists.
Red are new lines, cyan are changed lines.

MQ.h

Code: Select all

	BOOL ConColor;[color=red]
	BOOL Invisible;[/color]
} SWHOFILTER, *PSWHOFILTER;

EQLib_Main.cpp

Code: Select all

	gFilterSWho.ConColor= GetPrivateProfileInt("SWho Filter","ConColor",0,Filename);[color=red]
	gFilterSWho.Invisible= GetPrivateProfileInt("SWho Filter","Invisible",0,Filename);[/color]

    gTelnetServer= GetPrivateProfileInt("Telnet Server","Enabled",0,Filename);

EQLib_Commands.cpp in SWhoFilter()

Code: Select all

		SetDisplaySWhoFilter(&gFilterSWho.ConColor,"ConColor",szToggle);[color=red]
	} else if (!stricmp(szArg,"invisible")) {
		SetDisplaySWhoFilter(&gFilterSWho.Invisible,"Invisible",szToggle);[/color]
	} else {[color=cyan]
		WriteChatBuffer("Usage: /whofilter <lastname|class|race|level|gm|guild|holding|ld|anon|lfg|npctag|spawnid|trader|afk|concolor|invisible> [on|off]",USERCOLOR_DEFAULT);[/color]
	}
}

EQLib_Commands.cpp in SuperWhoDisplay()

Code: Select all

			if ((pFilter->bGroup) && (!IsInGroup(pSpawn))) continue; [color=cyan]
			if (((!pFilter->bTargInvis) || (gFilterSWho.Invisible)) && (pSpawn->BodyType>0x40)) continue;[/color]
            if ((pFilter->bTrader) && (!pSpawn->pActorInfo->Trader)) continue;

[Mckorr]

CVS'd

[GothOpie]

when I set /whofilter invisible on, I'm still not able to /who on invis npc's
I checked the ini file, it shows:
[SWho Filter]
Invisible=1
I tried exiting MQ and EQ, logging back in, and still cannot /who them(using /who npc THEinvisNPC'sname)
tried the suggestion from http://macroquest2.com/phpBB2/viewtopic ... isible+npc
(/who npc range 1 2 invis) still no luck
tried about every varation I could think of using "npc", "invis" and/or "invisible", what am I doing wrong?

(and yes, trust me there ARE invis npc's where I'm at ;)
edit: forgot to mention, I just downloaded and compiled the newest MQ about 10 minutes ago

[MacroFiend]

Sorry ... that's my fault. I just looked at the logic of the statement again and it is wrong. I forgot I was dealing with inverse logic on these statements.

Code: Select all

if (((!pFilter->bTargInvis) || (gFilterSWho.Invisible)) && (pSpawn->BodyType>0x40)) continue;

should be

Code: Select all

if ((!pFilter->bTargInvis) && (!gFilterSWho.Invisible) && (pSpawn->BodyType>0x40)) continue;

[Homer]

This last change is not in the current CVS.

[MacroFiend]

I don't have CVS access, so I can't put it there directly. One of the devs has to update CVS.

[Mckorr]

It's not in the CVS because there is a parentheses missing :)

Edit: No there's not, I'm just blind today. Fixing it now, will be in dev CVS in a minute or two.

[MacroFiend]

With the OR, they needed to be grouped ... but w/ the &&'s it doesn't make a difference, so I removed the inner parenthesisesissiissiis.

[Mckorr]

I got it, I just kept miscounting. Normally I just cut and paste the code in, but for such a minor change was faster to type it and that through my count off. Just needed to go back over what you actually wrote as opposed to what I thought you wrote, if that makes any sense.

[Milten]

Sorry to bump such an old topic.. but:

/ npc guy => 0
/ npc guy invis => elem, muddite, vegerog
/whofilter invisible => off
/whofilter invisible on => on
/ npc guy => 0
/ npc guy invis => elem, muddite, vegerog

relogging doesnt change a thing...

P.S. I hope this somehow makes sense :)

[xyilla]

побе

[xyilla]

188.6

[xyilla]

совс

[xyilla]

TEST

[xyilla]

Папе