BUG: CTD on item inspection

A forum for feature requests/discussions and user submitted patches that improve MQ2

Moderator: MacroQuest Developers

MacroFiend
a grimling bloodguard
a grimling bloodguard
Posts: 662
Joined: Mon Jul 28, 2003 2:47 am

BUG: CTD on item inspection

Post by MacroFiend » Mon Nov 03, 2003 10:19 pm

Using SRC-20031103e.zip, I CTD when looking at an item link.

Since we haven't done much to that code other than add Lore Name, Haste % etc, my bet is that it is being caused by the changes made today to fix the other CTD issues ... though I'm not sure if there were struct changes that could have done this also.

These functions were working in the 11/02 build (after removing the filtering)

EqMule
Developer
Developer
Posts: 2697
Joined: Fri Jan 03, 2003 9:57 pm
Contact:

Post by EqMule » Mon Nov 03, 2003 10:44 pm

poor Lax, all he got from adding a new great feature is grief and pain ;)

hey Lax dont sweat it, we all love the chatwindow, and understand that since its taking its first struggeling steps, it can fall over sometimes, but its ok, we know it will be great when u get the bugs sorted out it allready is, buggy or not.
My status o/
If you like MQ2 and would like to contribute, please do. My goal is 25 donations per month.
So far I've received Image donations for this month's patches.

Bitcoin: 1Aq8ackjQ4f7AUvbUL7BE6oPfT8PmNP4Zq
Krono: PM me.
I can always use characters for testing, PM me if you can donate one.

MacroFiend
a grimling bloodguard
a grimling bloodguard
Posts: 662
Joined: Mon Jul 28, 2003 2:47 am

Post by MacroFiend » Mon Nov 03, 2003 10:58 pm

It is good work ... just a lot of debugging with so many things changing at the same time that all seem to be inter-related.

The item info shouldn't have anything to do w/ the CTD fixes ... but it could have something to do w/ the UI structs being moved in to their own header file ... or UI struct updates ... or something totally different.

Don't really know 'cause I can't filter out my last good code and get pieces added in until it breaks like I did the other night. Besides that, I didn't have any CTD issues until after the download w/ the EQLib_UIstructs.h was added.

wassup
Official Guardian and Writer of TFM
Official Guardian and Writer of TFM
Posts: 1487
Joined: Sat Oct 26, 2002 5:15 pm

Post by wassup » Mon Nov 03, 2003 11:44 pm

I don't know what's going on. I have yet to experience any of these CTD's that have come up the past few days.

Is it just VC6?

Plazmic
The One
The One
Posts: 800
Joined: Fri Jun 14, 2002 12:31 am
Contact:

Post by Plazmic » Tue Nov 04, 2003 12:01 am

VC6 IDE or nmake... I think they need to tweak the optimizations.

I was having an issue with item properties on a fully optimized build on VS.NET when it was just Lax's lore info, but I tracked it down to a badly optimized register that wasn't preserved during the trampoline (EQ's function didn't keep the register intact).

After I added all the stuff, I made sure it optimized right on VS.NET, but no clue what is going on with VC6
- Plazmic

User avatar
dont_know_at_all
Developer
Developer
Posts: 5450
Joined: Sun Dec 01, 2002 4:15 am
Location: Florida, USA
Contact:

Post by dont_know_at_all » Tue Nov 04, 2003 12:04 am

No, no. The other CTDs were real bugs. I think you had to have change your default text color for it to have shown up.

Plazmic
The One
The One
Posts: 800
Joined: Fri Jun 14, 2002 12:31 am
Contact:

Post by Plazmic » Tue Nov 04, 2003 12:07 am

and I'm talking about this item window crashing... since it happened to me on VS.NET and I fixed it by rewriting the function not to use that bad register....
- Plazmic

User avatar
dont_know_at_all
Developer
Developer
Posts: 5450
Joined: Sun Dec 01, 2002 4:15 am
Location: Florida, USA
Contact:

Post by dont_know_at_all » Tue Nov 04, 2003 12:40 am

Is it fixed for VS6?

Or do you more details so I can track it down for VS6?

Lax
We're not worthy!
We're not worthy!
Posts: 3524
Joined: Thu Oct 17, 2002 1:01 pm
Location: ISBoxer
Contact:

Post by Lax » Tue Nov 04, 2003 12:59 am

I dunno, when I see a problem I get it fixed asap ;) Real problem is other people tend to have these problems because of differences in vs 6 and .net :(
Lax Lacks
Master of MQ2 Disaster
Purveyor of premium, EULA-safe MMORPG Multiboxing Software
* Multiboxing with ISBoxer: Quick Start Video
* EQPlayNice, WinEQ 2.0

User avatar
dont_know_at_all
Developer
Developer
Posts: 5450
Joined: Sun Dec 01, 2002 4:15 am
Location: Florida, USA
Contact:

Post by dont_know_at_all » Tue Nov 04, 2003 1:15 am

I'm not buying it. I don't think there is that much difference if we manage to keep all the flags the same.

Which is why everyone should be using nmake.

Mckorr
Developer
Developer
Posts: 2326
Joined: Fri Oct 18, 2002 1:16 pm
Location: Texas

Post by Mckorr » Tue Nov 04, 2003 8:55 am

I haven't had any of these crashes, just the corrupted superwho.
MQ2: Think of it as Evolution in action.