Parsing tells for specific word, lockups

[AarynD]

Code: Select all

#chat tell 

Sub main 

| ----- Trigger Declares --------------------- 

| ----- Variables ---------------------------- 
/Declare teller   global
/Declare rodtf    global
/goto :Wait 
/return 

:Wait 
   /DoEvents 
/goto :Wait 

Sub Event_Chat
/varset rodtf $instr(ROD,$ucase("@Param2"))
/varset teller @Param1 
/if n @rodtf>0 {
  /echo @teller needs rod.
  /target @teller
  /sit off
|  /call cast "Rod of Mystical Transvergance"
  /cast 5
}
/doevents 
/return 

I've also tried this, which USED to work before the var changes and last patch, altho it would cause the IF statement to issue a msg about not finding comparison operator...

Code: Select all

Sub Event_Chat 
/if "$ucase(@Param2)"~~"ROD" {
/target @Param1
/sit off
/cast 5
}

This causes entire machine to lock up, depending on what i'm sent in tell. Any ideas? Parsing strings with vars seems to be a hit and miss thing in MQ

Would appreciate some help, if anyone sees a way to do this.

[Zxeses]

First, a few changes to the script ...

1. teller and rodtf dont need to be globals.
2. Bad code readability using /goto outside of the subs end, and not really needed.
3. Never Never Never call /doevents inside of an event, bad logic..

Code: Select all

#chat tell 

Sub main 

:Wait 
   /Doevents
   /delay 1
   /goto :Wait 

/return 


Sub Event_Chat(MsgType, MsgFrom, MsgData)

   /if n $strlen(@MsgData)>0 /if n "@MsgData"~~rod { 
      /echo @MsgFrom needs a rod. 
      /target PC @MsgFrom
      /stand
      /cast 5 
   }
/return 

[AarynD]

Script still not working, and causing lockups.

I rewrote simply to test what's going on. Doing this from work, and from memory, but pretty sure I'm accurate on what I was getting...

Code: Select all

Sub Event_Chat(MsgType, MsgFrom, MsgData)
/echo @MsgFrom | works fine
/echo @MsgData  | works fine
/varset uconvert $ucase("@MsgData")
/echo @uconvert | works fine
/varset npos $InStr(ROD,"@uconvert")
/echo @npos | returns -1, even if ROD is in the string
/return

The reasoning here is, I want to be able to detect the presence of ROD in a sentence, regardless of case, and regardless of how someone forms their request to me, so long as rod is in the tell somewhere.

If I code this:

Code: Select all

/if "@MsgData"~~"ROD"

then I get a macroquest error, stating there's not a valid comparison operator. So of the message to me is "I need a rod please.", it becomes /If "I need a rod please."~~"ROD", and the if statement isn't working correctly with a string with spaces in the first part of the comparison.

The problem compounds when someone sends certain chars in their tells. If I get a "<grin>" or a "=)" sent to me in a tell, the computer locks up, and I have to reboot. Every time.

Any other ideas?

[wassup]

Code: Select all

#chat tell 

Sub main 
   :Wait 
      /doevents tell
   /goto :Wait
/return

Sub Event_Chat 
   /if "@Param2"~~"rod" { 
      /echo @Param1 needs rod. 
      /target @Param1
      :WaitTarget
      /if $target(name)!=@Param1 {
         /delay 0
         /goto :WaitTarget
      }
      /sit off
      /delay 0
      /cast "Rod of Mystical Transvergance"
      :WaitCast
      /if $char(casting)==TRUE {
         /delay 0
         /goto :WaitCast
      }
    } 
    /doevents flush
/return

[Mckorr]

Parameters start from 0, not 1. So it would be @Param0 and @Param1. Currently you are checking against a parameter (@Param2) which will be undefined if you are only passing two parameters to the sub.