Group Roles corrupted after merc suspend

spanners · Post by **spanners** » Wed Apr 15, 2009 1:00 am

I've noticed that the Group attributes Puller, MainTank, MainAssist but not Group.Leader get corrupted with an off-by-one error when a merc that takes a high up group order (2nd spot for example) is suspended.

To test:

- Make a group, distribute the roles around.
- Check Group.<role> attributes are returning the right values.
- Unsuspend merc on a group member high up in the group order (first position shows this best - merc gets group position number 2).
- Check Group.<role> attributes are returning the right values.
- Suspend merc.
- Group.<role> attributes are now off by one for any group member that was below the merc in group order (position 3 or lower).

gimp · Post by **gimp** » Wed Apr 15, 2009 5:54 am

I noticed this myself yesterday when i had a full group and 1 player left, main assist ID was not updated correctly & broke the macros. camping / zoning "solved" the issue.

ieatacid · Post by **ieatacid** » Mon Apr 27, 2009 12:45 am

Fixed in next zip.

Thanks go to spanners for providing me with a group to test with.

spanners · Post by **spanners** » Mon Apr 27, 2009 2:07 am

Thanks for taking the time to fix it.

gimp · Post by **gimp** » Mon Apr 27, 2009 3:22 am

indeed, thanks alot!

gimp · Post by **gimp** » Tue Apr 28, 2009 7:06 am

ieatacid: if you have time,could you please post a diff for the fix?

ieatacid · Post by **ieatacid** » Tue Apr 28, 2009 4:04 pm

- Diff

- Entire new file

gimp · Post by **gimp** » Thu Apr 30, 2009 4:41 pm

thank you very much!