smithing

Soulzek · Post by **Soulzek** » Fri Oct 04, 2002 8:40 am

could someone make me a macro to make metal bits?
i tried editing current macros and replacing such and such with ingrediants, but i can never get ANY macro to work.

rizwank · Post by **rizwank** » Fri Oct 04, 2002 8:59 am

what goes wrong with the ones you have tried?

Soulzek · Post by **Soulzek** » Fri Oct 04, 2002 9:25 am

here is one i got from here, but it makes kite shields.i modified the items, thats it.again, i dont know anything about macro scripts so theres really no point in telling me whats wrong.
edit:codebrackets are lovely

Code: Select all

| - smith.mac - 
| 
| Please be near a forge open before you start this macro. 
| 
#include routines.mac 
#turbo 

Sub Main 

   /filter skills increase 

   /itemtarget Forge 
   /face item 
   /click left item 

      :Makesmith 
      /sendkey down ctrl 

      /finditem "water flask" 
      /if $find()==FALSE /goto :Done 
      /click left enviro 0 

      /finditem "small peice of ore" 
      /if $find()==FALSE /goto :Done 
      /click left enviro 1 

      /finditem "small peice of ore" 
      /if $find()==FALSE /goto :Done 
      /click left enviro 2 
      
      /sendkey up ctrl 
      /click left enviro combine 

      | Either small kite shield or smithy hammer comes back, so we always get 1 item 

      :WaitCombine 
         /delay 0 
/if "$cursor()"=="TRUE" /goto :AutoDropkiteshield 
      /for v1 1 to 5 
         /delay 2 
         /if "$cursor()"=="TRUE" /goto :AutoDropsmithyhammer 
      /next v1 


      /if "$cursor()"=="FALSE" /goto :WaitCombine 

      /click left auto 
   /goto :makesmith 

   :AutoDropsmithyhammer 
      /click left auto 

   :Autodropkiteshield 
      /click left auto 

   /goto :makesmith 

   :Done 
    /sendkey up ctrl 

    /click left enviro done 

/return 

/return

Samefudge · Post by **Samefudge** » Fri Oct 04, 2002 9:50 am

Well other than seeing a lot of extra text there in the actual code, try spelling it 'small PIECE of ore' not 'small PEICE of ore' and it may work as-is...

Edit: there are much cleaner and faster 2- and 3-component combine macros you can edit to make bits rather than the one you used.

LML · Post by **LML** » Fri Oct 04, 2002 1:05 pm

Im not sure, but it seems like this piece of code:

Code: Select all

:WaitCombine 
   /delay 0 
   /if "$cursor()"=="TRUE" /goto :AutoDropkiteshield 
   /for v1 1 to 5 
     /delay 2 
     /if "$cursor()"=="TRUE" /goto :AutoDropsmithyhammer 
   /next v1 
   /if "$cursor()"=="FALSE" /goto :WaitCombine

It may work with kite shields, but if you use it with metal bits and fail a combine, cursor will be empty and will produce a endless loop

Anyway, the mispelled word will crash the macro also for sure