Tradeskill Combiner - New UI

[secrettoo]

This tradeskill macro will make any recipe. Just bring up the tradeskill UI, select the recipe from the list box, then run the macro. There are lots of macros that do tradeskills, but this is just the one I wrote while no other ones worked with the new UI. So take your own pick.

- It will keep doing the recipe until it runs out of a component.
- It echo's skill ups to the MQ2 window with the tradeskill name and skill number.
- Works with UI changes from 17th May zip onwards.

SecretToo

-------------------------------------------

Code: Select all

| Tradeskill macro to perform Combine and Autoinv one a selected recipe
| Usage: Bring up Tradeskill Window, select Recipe, then run the macro.
| SecretToo v1.1 -  2nd May 2004 - Initial version
|                   15th May 2004 - skill ups and cursor handling
|                   20th May 2004 - window idents fixed for 17th May zip
|

#turbo 10

#event EvtNoMoreStuff "#*#you don't have everything you need for this recipe#*#"
#event EvtSkillUp "You have become better at #1#! (#2#)"

Sub Main 

:mainloop
  /notify COMBW_CombineArea COMBW_CombineButton leftmouseup 
  /delay 1s
  /doevents
:autoequip
  /newif (${Cursor.ID}!=NULL) {
    /notify COMBW_CombineArea COMBW_AutoInvButton leftmouseup
    /delay 1s 
    /goto :autoequip
  }
  /doevents
  /goto :mainloop

/return


Sub Event_EvtNoMoreStuff(string Line)

  /echo Out of components!
  /popup Out of components!
  /squelch /endmac

/return


Sub Event_EvtSkillUp(string Line, string skillname, string skillnum)

  /echo Skill Raise! ${skillname} is now ${skillnum}. 

/return

[Mimatas]

This looks like it didn't require much effort to make... However, you put in more effort that I was willing to (I wanted the same thing, but laziness prevailed), so thanks a ton. I'm gonna give it a shot next time I work on tradeskilling.

[secrettoo]

You're welcome and thanks for the compliment :-) No it required very little effort, about 15 minutes, but it does the job very well and I thought it would help everyone here by posting it.

SecretToo

[Onezero]

This might help, code brackets are your friend.

Code: Select all

| Tradeskill macro to perform Combine and Autoinv one a selected recipe 
| Usage: Bring up Tradeskill Window, select Recipe, then run the macro. 
| SecretToo v1.1 - 2nd May 2004 - Initial version 
| 15th May 2004 - skill ups and cursor handling 
| 

#turbo 10 

#event EvtNoMoreStuff "#*#you don't have everything you need for this recipe#*#" 
#event EvtSkillUp "You have become better at #1#! (#2#)" 

Sub Main 

:mainloop 
/notify TradeskillWnd CombineButton leftmouseup 
/delay 1s 
/doevents 
:autoequip 
/newif (${Cursor.ID}!=NULL) { 
/notify TradeskillWnd AutoInvButton leftmouseup 
/delay 1s 
/goto :autoequip 
} 
/doevents 
/goto :mainloop 

/return 


Sub Event_EvtNoMoreStuff(string Line) 

/echo Out of components! 
/popup Out of components! 
/squelch /endmac 

/return 


Sub Event_EvtSkillUp(string Line, string skillname, string skillnum) 

/echo Skill Raise! ${skillname} is now ${skillnum}. 

/return

[Oid]

Code: Select all

code brackets are your friend.  Use them.  They are good.

[BrainDeath]

If either of the notify statements are working after the May 17 zip, I would like to know how you did it. I would think that

Code: Select all

/notify COMBW_CombineArea COMBW_CombineButton leftmouseup
and
/notify COMBW_CombineArea COMBW_AutoInvButton leftmouseup

would be required.

[secrettoo]

You're right, code fixed and reposted to stop the comments. I hadnt run it since the 17th May zip is the answer. I changed my other macros to use new window identifiers, but didnt change this one.

Works now anyway. Enjoy etc.

[Treehugger]

How would you add a line to destroy a certian item? Sometimes it's just not worth saving the item to sell to a vendor, the skillups are the only reward.

[amml]

use

Code: Select all

/destroy

instead of

Code: Select all

/notify TradeskillWnd AutoInvButton leftmouseup 

[Fuergrissa]

use

Code: Select all

/destroy

instead of

Code: Select all

/notify TradeskillWnd AutoInvButton leftmouseup 

NO NO NO , Sorry to jump in here but NEVER use a /destroy in any macro UNLESS you run a check on the cursor first, if you pick anything from your inventory without thinking what your doing its gone, the best way is to add an ini file to log what you make and ONLY destroy items that exist in the ini ONCE you have edited the ini file.
No offence Amml I know your intentions where good.

This should work, I have not tested as im about to go to bed, if it does not then let me know ill knock up a macro and test it for you.

Code: Select all

Sub CheckItem 
      /declare ItemSetting int local 
      /declare NotFound int local 
      /varset NotFound -1 
      /varset ItemSetting ${Ini[combine.ini,ItemList,${Cursor.Name},${NotFound}]} 
      /delay 5
      /if (${ItemSetting}==${NotFound}) { 
      /ini "combine.ini" "ItemList" "${Cursor.Name}" "1" 
      /varset ItemSetting 1 
      }
      /if (${ItemSetting}==1) { 
  :BagIt 
      /autoinv
      /delay 5 
      /if (${Cursor.ID}) /goto :BagIt
      /return
      } else { 
      /Call Destroy
      /return
      } 
      /return 
      
Sub Destroy
      /destroy
      /return

[amml]

so true, thx =)

[theoneandonly]

this seems like a stolen and modified version of Meatballs Vanilla Combine

[Fuergrissa]

this seems like a stolen and modified version of Meatballs Vanilla Combine

Virtually everyone starts by using other peoples macros and learning from them, using parts of them and modifying them to suit their means. the Correct term is Borrowing not STOLEN, if in the first place Meatballs combine macro was written from his/hers head rather than from looking at someone elses macro first and then using part of it to make his/hers.