Page 1 of 2
Problem with /who
Posted: Sat May 15, 2004 10:28 am
by s16z
Using May 14 2004 19:23:36 source, V6 SP6.
When I type /who, I get
Code: Select all
List of matching spawns
-----------------------------------
(0-100) pc was not found.
Using /who with an option just gives the same results, but replace pc with whatever option.
Posted: Sat May 15, 2004 11:01 am
by Oid
Hmm... already a topic about this, search is your friend
Posted: Sat May 15, 2004 1:34 pm
by Amadeus
Just out of curiosity, what did you search for to get that thread you mentioned? I searched for 'who' and '/who' and got nothing (which is strange since I would expect SOMETHING to come up).
Either that or search is too complicated for me ..lol (I usually read everythin and never use search...but I don't see this thread you mentioned in the bug forum).
Posted: Sat May 15, 2004 1:37 pm
by Amadeus
Well, I guess I found it ...IN THE WRONG DAMN FORUM.
s16z was not the one that deserved the flame (albeit it was a rather tame flame).
Either way, this discussion will now move to this thread ...where it belongs.
Posted: Sat May 15, 2004 2:27 pm
by Lax
ok, yes other people have this bug, and no I have no idea why (it does seem to be only with VS6 and even then, DKAA tested with VS6 and said it works 100%). The bug isn't actually with /who, according to some tests I had someone do last night. /who and the standard spawn search (aka part of /who that isnt /who, and part of /target, ${Spawn[search]}, ${NearestSpawn[n,search]}, /maphide, /mapshow, /mapfilter custom, etc) both changed.
Okay, that in mind. Does /target work correctly? Does /echo ${Spawn[npc name]} work correctly? If you answered NO to both of these questions, the problem isnt even /who
I'm going to do some testing since I dont really expect anyone reporting this problem to be able to handle it since it doesnt crash... but... if I dont find it you'll have to figure out how to look at debug spew
Posted: Sat May 15, 2004 2:42 pm
by Jerle69
I use VS6SP6; I'll see if it works for me, if not I'll tell you what's up. If it does work, I won't report back that there's a problem
Posted: Sat May 15, 2004 3:27 pm
by Lax
I'm testing with VS6, and i dont think i even have SP6 installed on it.. I took it right from the zip, in a clean directory, no custom plugins, no changes to ini files, nothing.. and /who works perfectly.
Posted: Sat May 15, 2004 3:34 pm
by JGC84
i'm having the same who issue, compiling w/ VS 6, SP 5 (maybe), only thing i've changed is the hud ini file... so unless thats effecting it.. ok: just unloaded the hud plugin, didnt change anything
Posted: Sat May 15, 2004 4:06 pm
by Oid
Bah! that wasn't even a flame, a polite suggestion! I didnt even say fuck!
Posted: Sat May 15, 2004 4:44 pm
by Amadeus
Someone posted that it works when debugspew is on, and doesn't when it's off.
Right now '/who <class>' isn't working for me (ie, 'who druid'); however, I'm raiding and can't debug right now.
Will fix tonight though if Lax hasn't got it by then since it's not working for me and can debug it.
Posted: Sat May 15, 2004 4:48 pm
by Amadeus
ok...nevermind, obviously this was changed when I wasn't looking. I guess you have to do 'who class druid' now.
I might put an if statement in there sometime to catch 3rd arguments that are class names later.
Posted: Sat May 15, 2004 5:40 pm
by Lax
I'll modify the spawn search parser to take player classes and player races without the "class" or "race" keywords. Post on another thread about that if you need to, leave this one for people who do /who and have it not display spawns
Someone having this problem PLEASE do a vanilla install of MQ and test it. Make a completely new directory, unzip and compile without making ANY changes (dont change the ini, dont add custom plugins, dont add custom code, NO changes). Then go into the game, and see if it works. If it DOES work, then the issue has to do with customizations (not necessarily your fault). If it DOES NOT work, then the issue has to do with the compiler. PLEASE do this test.
Dont post another post on this thread unless it is the outcome of this test.
Posted: Sat May 15, 2004 6:25 pm
by SwiftyMUSE
Ok, here is some results from testing...
There is a spawn list.
If the spawn fails to pass the spawntype it exits the search.
If it passes the spawntype, it failes on:
Code: Select all
if (pSearchSpawn->ZRadius<10000.0f && (pSpawn->Z > pChar->Z + pSearchSpawn->ZRadius) ||(pSpawn->Z < pChar->Z - pSearchSpawn->ZRadius))
return FALSE;
I am checking the specific values next and will update the post with more information.
Fix for /who issue
Posted: Sat May 15, 2004 7:02 pm
by SwiftyMUSE
in MQ2Commands.cpp change:
Code: Select all
if (pSearchSpawn->ZRadius<10000.0f && (pSpawn->Z > pChar->Z + pSearchSpawn->ZRadius) ||(pSpawn->Z < pChar->Z - pSearchSpawn->ZRadius))
return FALSE;
to:
Code: Select all
if (pSearchSpawn->ZRadius<10000.0f && ((pSpawn->Z > pChar->Z + pSearchSpawn->ZRadius) ||(pSpawn->Z < pChar->Z - pSearchSpawn->ZRadius)))
return FALSE;
in the BOOL SpawnMatchesSearch(PSEARCHSPAWN pSearchSpawn, PSPAWNINFO pChar, PSPAWNINFO pSpawn) function.
Lax, can you get the fix into dev cvs?
Thanks,
Posted: Sat May 15, 2004 7:59 pm
by Lax
Fixed for next zip, thank you