Strange behaviour of default fish macro...

[OnyxSkyDV]

I have modified the default fish macro to also forage so I can do both at the same time, but noticed some strange behavior, so I tried just the plain default fish macro, and got the same results.

When it gets to an item that should be destroyed, I can see it go click on the destroy button, then goes back to the autoequip area, but never actually destroys the item.... will go into a very fast loop, with macroquest spewing "[macroquest] you have caught a rusty dagger" repeatedly across the chat window.

It also will find the container that has a pole in it should I not have one in my primary slot, and open the bag, but will not equip it.

If I have an item on the cursor and do a "/click left destroy" it will get rid of it correctly, and I am not having the doubling problem since the new cvs with the updated locations file.

any ideas that I can try? All I can think of is that a time delay of some type needs to be added for it to actually hit the destroy button correctly....

Thanks!

OnyxSkyDV

[Valerian]

put a /delay 1 (or more) after every /click command, the macro is continuing before eq sees the click.

[OnyxSkyDV]

Thanks much! I will give it a shot and let you know how it worked out!


OnyxSkyDV

[Mckorr]

We currently move the mouse my directly modifying its location address, but we still click by DirectX. That makes the actual click a lot slower than the move.

Insert delays after the clicks to give EQ time to recognize the click before MQ runs on to the next line in the script. MQ is actually faster than the DirectX click function.

Valerian is working on a non-detoured (meaning non-DirectX) version of Click, but it's slow going. For now use delays. Start with "/delay 1s" and adjust for the speed of your computer.

[kagonis]

http://macroquest2.com/phpBB2/viewtopic ... 6053#16053

Do exactly what you need

[OnyxSkyDV]

Well, based on my guess and your recommendations, it was the timing that was throwing me.....

What I did was to take the line for /click left destroy and replaced them with a call to a new routine. /call destroyitem

Then I added a new section called destroyitem, which had the following:
/mouseto destroy
/delay 2
/click left destroy
/delay 2

Which seemed to fix that issue for me. need to tweak it a bit more, because I think those delays are too long, and maybe one more than needed delay statement.

I still have the issue where finditem will walk though my bags, and then open the bag that has the fishing pole, but never takes it from the bag to auto equip....

Any help with that would be great. Still looking through other macros to glean what I need.


Thanks much! :)

[BlueSkies]

Another quirk I've noticed is that when EverQuest (or EQW) is NOT the focus window (ie, you're doing something else while running a macro, like checking up on the MQ forum ), macros with /click will fail. Specifically, the /click never reaches the client. This is similar to the behavior of Xylobot, which also uses DirectX for click (and everything else -- but that's beside the point).
Which means, until they get the non-detoured /click working, you won't be able to do other things on your computer while macroing with macros that require /click.

Just a little note. :) Good luck with the script.

[wassup]

Well, based on my guess and your recommendations, it was the timing that was throwing me.....

What I did was to take the line for /click left destroy and replaced them with a call to a new routine. /call destroyitem

Then I added a new section called destroyitem, which had the following:
/mouseto destroy
/delay 2
/click left destroy
/delay 2

Which seemed to fix that issue for me. need to tweak it a bit more, because I think those delays are too long, and maybe one more than needed delay statement.

I still have the issue where finditem will walk though my bags, and then open the bag that has the fishing pole, but never takes it from the bag to auto equip....

Any help with that would be great. Still looking through other macros to glean what I need.


Thanks much! :)

Another idea I am using is to do a cursor check in a loop with a very small delay, if any:

Code: Select all

:ReClick
/click left <destroy auto etc...>
/if $cursor()==True /goto :ReClick

Something like this is overall more efficient I think than using /delay for a set amount of time. I have tried using /delay 5 or higher and becasue of lag I still end up missing the click.

Just something to consider.

[OnyxSkyDV]

Great idea! makes more sense to click till it works rather than guess at a predetermined time....

I'll be throwing this in my macro shortly. :)

OnyxSkyDV

[Amadeus]

There's something about the notion of a character sitting at the water clicking their hotbutton at lightning speed NON STOP that would disturb me if I were a running executable :)

The delay is better, imo.

[OnyxSkyDV]

Do you think there would be all that many clicks? Would putting a small delay in there, but maintaining the check be smarter? That way you are not doing a ton of fast clicks, but still having some redundency/error checking to help the macro work as desired?

Thanks!

Onyx

[Amadeus]

It's up to you, but personally I've never had a problem using a timer to time the clicks to coincide for when the button is ungreyed. If the fishing timer is x seconds, I usually put my timer for x+2 seconds to give a little leeway.

Losing those 2 seconds won't significantly reduce the amount of fish you get, at least I don't think so.

[OnyxSkyDV]

Ah, I see the misunderstanding... We are talking about a loop to continue to click on the destroy button, should it fail to click it the first time.

I agree completely, have it just click on the fishing button would be at the least wasteful of cycles, and quite possible a reason to draw attention from SoE.... However for the destroy click, it should work fine.

Thanks!


OnyxSkyDV