Buff check help

[judeman]

I am somewhat new to this but I have been studying and learning but I have ran into a problem that I cant solve. I have used search and everytihing else I could do but have ran into a wall. This is part of my macro where I check buffs and if I dont have them I tell my toons to cast them on me which I have them on Genbot. My macro is custom of course and the master macro for my 4 box setup.

What I want it to do is check buffs and if i dont have the called buff then my toons will cast them on me but I need to delay the amount of time before my mac continues to pull the mobs I have set up to pull. ( Notice the 14 second delay on Conviction and the other /delays) But if my SK has the buffs allready I want him to skip the delay for each buff and move on to the next one. Here is what I got so far. It works to a degree but is sloopy.
My self buffs work fine btw so no issues with them.



|--Edited out my characters names--|



|-------------------------------------------|
|Check Buffs Called before pull |
|-------------------------------------------|
Sub CheckBuffs
/echo Checking Buffs...
/doevents
/if (!${Me.Buff[Shroud of Discord].ID}) {
/call Cast "Shroud of discord" gem6 4s
}

/if (!${Me.Buff[cloak of luclin].ID}) {
/call Cast "Cloak of Luclin" gem8 8s
}

/if (!${Me.Buff[banshee aura].ID}) {
/call Cast "banshee aura" gem6 4s
}

/if (!${Me.Buff[Blessing of Devotion].ID}) {
/1 mycleric buff Blessing of Devotion on MYSK
}/delay 5s

/if (!${Me.Buff[Panoply of Vie].ID}) {
/1 mycleric buff Panoply of Vie on MYSK
}/delay 5s


/if (!${Me.Buff[conviction].ID}) {
/1 mycleric buff conviction on MYSK
} /delay 14s


/if (!${Me.Buff[Night`s Dark terror].ID}) {
/1 Mychanter buff Night`s Dark terror on MYSK
} /delay 5s


/if (!${Me.Buff[vallon's quickening].ID}) {
/1 Mychanter buff vallon's quickening on MYSK
} /delay 10s


/if (!${Me.Buff[Voice of Quellious].ID}) {
/1 Mychanter buff Voice of Quellious on MYSK
} /delay 14s

/if (!${Me.Buff[guard of Druzzil].ID}) {
/1 Mychanter buff guard of Druzzil on MYSK
} /delay 7s


/if (!${Me.Buff[dead man floating].ID}) {
/1 Mynecro buff dead man floating on MYSK
} /delay 10s

/delay 5s
/pet guard
/return

|-------------------------------------------------------------------|
|-------------------------------------------------------------------|

Any help would be most appricated.

Thanks
Judeman

[Neolesh]

first use code brackets, second

Code: Select all

/if (<Condition>) {
   /do something
   /delay
}

[judeman]

first use code brackets, second

Code: Select all

/if (<Condition>) {
   /do something
   /delay
}

So would this be a example of what it should look like?

Code: Select all

/if (!${Me.Buff[Panoply of Vie].ID}) {
         /1 mycleric buff Panoply of Vie on mySK
         /delay 5s
}

Hope I am not totally off here and thanks for your fast reply!


Thanks

[Neolesh]

Why don't you try it and see, and if it's not come back :)

[judeman]

Works like a charm and thanks. I was setting up as you posted your last reply. I had to play with some of the delays so now I get a all my buffs before the macro goes into the pull section of the macro.



Thanks
Judeman

[xyilla]

Bett

[xyilla]

Bett

[xyilla]

Dani

[xyilla]

Phil

[xyilla]

Myst

[xyilla]

комп

[xyilla]

Endo

[xyilla]

Blue

[xyilla]

Vali

[xyilla]

Educ