MacroQuest64

.

PeteSampras wrote:The songs can land on the long duration, but the long duration cannot land on the song. Thus why i added this line of code:

Code: Select all

if (!(tmpSpell->Level[7]==255?0:tmpSpell->Level[7]) && (!(pSpell->Attrib[1]==58)||!(pSpell->DurationWindow==1))) {

However, AAs cant always land on a disc if there is stacking issues or if the AA itself is counted as a disc and uses the combatability window like for ber/war and ranger trueshot line.

So in words, what does that line actually check? Why do you only check attrib[1]? Aren't there other illusions in slots2-12?

.

Btw, there are illusions using slots other than 1.

I think that's why he had the qualifier of "illusion that had a conflict"

Its always the kids that sufer when the grownups fight! =p

so your saying...

!(tmpSpell->Level[7]==255?0:tmpSpell->Level[7]) checks if its a bard song (this will not work for spells that are multi-classed that include bards)
!(pSpell->Attrib[1]==58) checks if it is an illusion
!(pSpell->DurationWindow==1) checks if it is ???

warlock45 wrote:I think that's why he had the qualifier of "illusion that had a conflict"

Its always the kids that sufer when the grownups fight! =p

And I was pointing out that "yet to see" is not a good way to determine how to code something. Check to make sure all the data fits your test (when possible) or it will fail and you will have to make changes over and over again.

.

rswiders wrote:so your saying...

!(tmpSpell->Level[7]==255?0:tmpSpell->Level[7]) checks if its a bard song (this will not work for spells that are multi-classed that include bards)
!(pSpell->Attrib[1]==58) checks if it is an illusion
!(pSpell->DurationWindow==1) checks if it is ???

Pete, your still writing obscure code and not answering what each part is trying to do. Since I know parts are wrong, I'm just trying to understand what each part of the check is responsible for so that it can be included properly.

.

There aren't bard songs that are multiclass. There are aa/disciplines shared by classes and will show the minimum level for a bard to use. Check out Fearless Discipline (#4587).


And thanks for answering the questions. I appreciate it.

.

Discs are buffs that have their own special window.

Sorry for dragging up an old post...

I'm slowly in the process of rewriting my old macros and am trying to figure out the best method for performing a heal over time check now that they appear in the song window.

${Spell[Holy Elixir].Stacks} always returns true, but ${Spell[Holy Elixir].StacksWith[Supernal Elixir]} returns false. Should this be the case or should I be doing this an entirely different way?

Thank you in advance.

....off topic a bit, but I just realized that with hots moved to the song window, is there any way to even know if someone else has a hot on them? This seems detrimental to hot healing....

why not just google it