Genbot Version 12 Ready

xander · Post by **xander** » Fri May 07, 2004 2:36 am

botspell.inc(110-116)

   :SelfBuffLoad 
      /if (${SelfBuffList.Arg[${ArgNum},[color=red]|[/color]].Length}) { 
         /varset CommandParam ${SelfBuffList.Arg[${ArgNum,[color=red]|[/color]}]} 
         /call AddSelfBuff "${CommandParam}" 
      } 
      /varcalc ArgNum ${ArgNum}+1 
   /if (${SelfBuffList.Arg[${ArgNum}].Length}) /goto :SelfBuffLoad

The pipes are causing havoc, trying to comment out the code. Not sure how to put them in. If I Change the character to another one (like a ~ for instance), I still get a don't know NULL spell.

ml2517 · Post by **ml2517** » Fri May 07, 2004 4:57 am

Did you try them in quotes? Not sure if its supported with the optional delimiter but I'd think it would be:

Code: Select all

   :SelfBuffLoad 
      /if (${SelfBuffList.Arg[${ArgNum},"|"].Length}) { 
         /varset CommandParam ${SelfBuffList.Arg[${ArgNum,"|"}]} 
         /call AddSelfBuff "${CommandParam}" 
      } 
      /varcalc ArgNum ${ArgNum}+1 
   /if (${SelfBuffList.Arg[${ArgNum}].Length}) /goto :SelfBuffLoad

LordGiddion · Post by **LordGiddion** » Fri May 07, 2004 7:27 am

think I have the fix for self buff

Code: Select all

:SelfBuffLoad
   	/if (${SelfBuffList.Arg[${ArgNum},|].Length}) {
   		/varset CommandParam ${SelfBuffList.Arg[${ArgNum,|}]}
   		/call AddSelfBuff "${CommandParam}"
   	}
   	/varcalc ArgNum ${ArgNum}+1
   /if (${SelfBuffList.Arg[${ArgNum}].Length}) /goto :SelfBuffLoad

change to

Code: Select all

:SelfBuffLoad
   	/if (${SelfBuffList.Arg[${ArgNum},|].Length}) {
   		/varset CommandParam ${SelfBuffList.Arg[${ArgNum,|}]}
   		/call AddSelfBuff "${CommandParam}"
   	}
   	/varcalc ArgNum ${ArgNum}+1
   /if (${SelfBuffList.Arg[${ArgNum[color=red],|[/color]}].Length}) /goto :SelfBuffLoad

forgot the | symbol in 1 place - as far as them commenting code - it only appears that way in your editor. I use them as seperators in lots of places.

I'll try to do more testing tonight - attempting to support this thing and pack my 5 bedroom house at the same time - 8 days left.

Nightshift · Post by **Nightshift** » Fri May 07, 2004 9:01 am

LordGiddion wrote:Nightshift: is the target, me, yourself, botname, or someother target all together?

Not sure I understand the question.

I did some more testing.

/tell botname buff <spellname> on <pcname> or yourself or me; the bot continually sends tells to the master saying "Don't know spell Buffs so failing to cast". It does however, recast the buff, but then continues to spam.

Looks like it isn't coming from the buff command but from the CheckSelfBuffs, but of course not sure on that, I noticed that in the INI it shows SelfBuffs=Buffs, since I hadn't set any self buffs. I set the self buff to Shield of Bracken, and now the text shows "Don't know the spell Shield so failing to cast"
NightShift

Fire · Post by **Fire** » Fri May 07, 2004 10:19 am

Hey LG, have you worked on the Anchor command yet? I was 4boxing my rogue last night, set an anchor for him and that worked ok, pulled a mob and after the fight was over, all the rogue did was run around in random directions, usually running backwards :p I might have been using the version before the latest update so i'll update those and check it again just to be sure.

Fire

LordGiddion · Post by **LordGiddion** » Fri May 07, 2004 10:51 am

Fire: try increasing Anchor radius, someone might have been standing where the rouge was trying to be so it kept runing obstical avoidance.

Nightshift: ok sounds like the spam was coming from selfbuffs then, I'll add code so it doesn't think the default string is a buff. Second make sure Botecore and botspell are current. There was a bug (I think i squished it and posted) that if your self buff had spaces in it, it didn't parse the whole name correctly. Make sure to also add the fixed I posted about last night.

Nightshift · Post by **Nightshift** » Fri May 07, 2004 11:13 am

LordGiddion wrote:Fire: try increasing Anchor radius, someone might have been standing where the rouge was trying to be so it kept runing obstical avoidance.

Nightshift: ok sounds like the spam was coming from selfbuffs then, I'll add code so it doesn't think the default string is a buff. Second make sure Botecore and botspell are current. There was a bug (I think i squished it and posted) that if your self buff had spaces in it, it didn't parse the whole name correctly. Make sure to also add the fixed I posted about last night.

I think I found the problem. Seems to work and isn't spamming.

botspell (110-118)

old code:

Code: Select all

:SelfBuffLoad
      /if (${SelfBuffList.Arg[${ArgNum},|].Length}) {
         /varset CommandParam ${SelfBuffList.Arg[${ArgNum,|}]}
         /call AddSelfBuff "${CommandParam}"
      }
      /varcalc ArgNum ${ArgNum}+1
   /if (${SelfBuffList.Arg[${ArgNum,|}].Length}) /goto :SelfBuffLoad
   
/return

new code:

Code: Select all

:SelfBuffLoad
      /if (${SelfBuffList.Arg[${ArgNum},|].Length}) {
         /varset CommandParam ${SelfBuffList.Arg[${ArgNum}[color=red],|][/color]
         /call AddSelfBuff "${CommandParam}"
      }
      /varcalc ArgNum ${ArgNum}+1
   /if (${SelfBuffList.Arg[${ArgNum}[color=red],|][/color].Length}) /goto :SelfBuffLoad
   
/return

Red shows where I changed the code.

This seems to fix the self buff issue but now it seems on the Buff command that iit conintually recasts whatever spell I ask it to buff when using /tellbotanem buff spellname on pcname or me or yourself.

Still looking...

NightShift

Nightshift · Post by **Nightshift** » Fri May 07, 2004 12:13 pm

Copied botcore and botspell, added the fixes since the last time those two were updated.

command:

/tell botname buff <spellname> on pcname or yourself or me all result in the following error.

Calculate Encountered unpasable text '${SelfBuffInt[1,1]>1'
botcore.inc@545 (Event_timer(string TimerName,string OldValue)):/if (${SelfBuffInt[${counter},1]>1) /varcalc SelfBuffInt[${counter},1]}-5
genbot.mac@57 (Main): /varset Breakout 0

Damn, hate it when I am not looking at it hard enough..

botcore line 545:

Code: Select all

/if (${SelfBuffInt[${counter},1][color=red]}[/color]>1) /varcalc SelfBuffInt[${counter},1] ${SelfBuffInt[${counter},1]}-5

Missing bracket..

Now that is isn't doing that anymore, no errors actually. It recasts the buff
over and over :)

What I found so far is that the casting over and over is happening in SpellSub in botspell.inc starting at line 137

Looking at that now to see if I can see anything that would make it loop continually as well as testing other commands that call spellsub.

Tested SelfBuffing, SN , SNT, BUFF. BUFF is the only one that continues to loop.after having cast the spell.

NightShift

SiatX · Post by **SiatX** » Fri May 07, 2004 1:20 pm

Nightshift, I added the } missing in line 545 in botcore.inc , and after doing /tell botname buf <spell> on <me> it casts spell, then goes into a loop /telling me:

"Dont know the spell NULL so failing to cast"

Look's to me he's searching for the selfbuff list, and failing at it.

Nightshift · Post by **Nightshift** » Fri May 07, 2004 1:37 pm

SiatX wrote:Nightshift, I added the } missing in line 545 in botcore.inc , and after doing /tell botname buf <spell> on <me> it casts spell, then goes into a loop /telling me:

"Dont know the spell NULL so failing to cast"

Look's to me he's searching for the selfbuff list, and failing at it.

There are a few other things to do as well, look at some of the previous posts. It is working for me at this point except for the lopping cast when using BUFF command.

NightShift

LordGiddion · Post by **LordGiddion** » Fri May 07, 2004 2:47 pm

Nightshift: Is this happening for ALL buff or only where the target is the bot itself?

bob_the_builder · Post by **bob_the_builder** » Fri May 07, 2004 2:51 pm

Everyone able to use multiple masters or just my issue?

LG said something about a "TLO" ... My friday ignorance is showing and I do not understand the anacronym.

Bob

Nightshift · Post by **Nightshift** » Fri May 07, 2004 3:17 pm

LordGiddion wrote:Nightshift: Is this happening for ALL buff or only where the target is the bot itself?

I have got to start saying things better :)

SelfBuff works fine. The Bot will selfbuff and recast the self buff without problems.

It only happens when using command BUFF only, it doesn't matter what the target is.

/tell botname buff spellname on pcname or me

Sorry, using yourself as the target, it doesn't recast over and over., only when me or pcname is used.

It recasts over and over.

I put /echo 1 after line 583 in botspell.inc.
I put /echo 2 after line 137 in botspell.inc.

output is 1,2,2,2,2,2,2,2 etc..

If I can test it a specific way, let me know.

NightShift

fez_ajer · Post by **fez_ajer** » Fri May 07, 2004 7:18 pm

bob_the_builder:

TLO = Top Level Object. It means the devs added a TLO into a recent zip which is required to be able to use multiple masters. Download the latest zip, clean, rebuild. All should be well.

all:

Some of the questions I'm seeing are probably results of either not having the latest files from the first post here or not having all of the bug fixes patched in since the release of the files on the first page. I believe the combination of the CommandParam mispelling and the pipe separators could cause some of the problems with (self)buff.

For some reason I'm not seeing them here with my patched up version.

Nightshift · Post by **Nightshift** » Fri May 07, 2004 7:32 pm

fez_ajer wrote:bob_the_builder:

TLO = Top Level Object. It means the devs added a TLO into a recent zip which is required to be able to use multiple masters. Download the latest zip, clean, rebuild. All should be well.

all:

Some of the questions I'm seeing are probably results of either not having the latest files from the first post here or not having all of the bug fixes patched in since the release of the files on the first page. I believe the combination of the CommandParam mispelling and the pipe separators could cause some of the problems with (self)buff.

For some reason I'm not seeing them here with my patched up version.

I'm not 100% that I have done every fix, but I have yet to find something I haven't done.

I hadded /echo after each /if .

My looping spell cast problem happens at line 145 , it loops right after that line is parsed and then returns to where it started in the BUFF command then right back to that point, over and over until I stop it.

I will continue to look..

NightShift