Genbot Version 12 MQ2Data Ready

A forum for you to dump all the macros you create, allowing users to use, modify, and comment on your work.

Moderator: MacroQuest Developers

User avatar
healbot
decaying skeleton
decaying skeleton
Posts: 8
Joined: Tue Apr 20, 2004 5:15 am
Contact:

trouble with my shamanbot

Post by healbot » Sun Apr 25, 2004 8:31 am

I'm sort of new at editing/tweaking macros, and could use a little help with this if possible

i'm running a 52 shaman slaved to my paladin, and this macro ends every time i run it due to an issue with cannibalization

getting the message:
Failed to parse: /if condition '(75<80 && 73>60 && 1524>1900 && @CannAATimer==0)' non-numeric encountered
Ending Macro: {
and since it's to do with Canni 5, i'm wondering if there is a way i can edit this so it's not looking for Canni 5, and will chain Canni 2 instead

V 9.x had a place in the genbot_shamanbot.ini that i edited to canni2, is there something i should add to the new genbot_shamanbot.ini to get him to do chain canni2?

looking at the code as i type this to see about commenting out the issue with canni5 for the time being

*edit* hmm, ok, got the macro to stay running instead of canceling itself, but the bot isnt responding to tells from the master.
Last edited by healbot on Sun Apr 25, 2004 8:43 am, edited 1 time in total.

spektralkat
orc pawn
orc pawn
Posts: 22
Joined: Sat Dec 20, 2003 5:25 am

Post by spektralkat » Sun Apr 25, 2004 8:36 am

Looks real good, couple things not working of course,,, guessing thats cuase we havnt built a personal.inc yet, what are the chances of getting an example of a functional personal.inc? hate to bother ya but Guess i'm the kind of gal that has to see functional code before i even begin to comprehend it and all the recent changes still have me lost

LordGiddion
a snow griffon
a snow griffon
Posts: 352
Joined: Sat Sep 13, 2003 6:12 pm
Contact:

Post by LordGiddion » Sun Apr 25, 2004 8:39 am

New Update:

xander: I tested INI rebuild and fixed the fails.
Fuergrissa: Mount has been fixed and your INI based Buff command didn't work because there is a new built in buff command which will auto re-buff read the main post for info check it out - it will probably do what you want even better then it used to, if you want to use your buff one of the 2 commands needs to be renamed (see natural language info in main post)
Spanky_Monkey: Your right on the default ini values fixed.
healbot: It was a problem with an undeclared timer, it should be fixed.
spektralkat: please read the last line of my first post, I won't post personal.inc because that is for Custom commands i.e. your own personal commands - if I wanted everyone to have a command I added to personal.inc I'd add it to the main code - You shouldn't need a personal.inc that is only if you want to add functions that the bot doesn't support as writen - most people don't need personal.inc at all. Read the GenbotDocs.txt post and see if that helps you get going.

User avatar
healbot
decaying skeleton
decaying skeleton
Posts: 8
Joined: Tue Apr 20, 2004 5:15 am
Contact:

excellent

Post by healbot » Sun Apr 25, 2004 8:57 am

Thanks Giddion
only thing is now i'm getting an error in

Code: Select all

Sub CheckCann 
   /if (!${Me.Moving}) { 
      /if (${Me.PctMana}<80 && ${Me.PctHPs}>=60 && ${Me.CurrentHPs}>1900 && @CannAATimer==0) { 
         /alt activate 47 
         /varset CannAATimer 3m 
      } 
      /if (${Me.PctMana}<95 && ${Me.PctHPs}>=40 && @CannTimer<=1) { 
         /call SpellSub "@CannSpell" 
         /varset CannTimer 4s 
      } 
   } 
/return 
Bot keeps spamming me with "Don't know the spell @CannSpell so failing to cast"

LordGiddion
a snow griffon
a snow griffon
Posts: 352
Joined: Sat Sep 13, 2003 6:12 pm
Contact:

Post by LordGiddion » Sun Apr 25, 2004 9:04 am

healbot: Thanks that was a typo problem, fixed I hope - get the new botspell

leaving-las-vegas
decaying skeleton
decaying skeleton
Posts: 3
Joined: Sun Apr 25, 2004 10:22 am
Location: Little Britain

Post by leaving-las-vegas » Sun Apr 25, 2004 10:30 am

Nice work LordGiddion :) seems to work great.

Did notice a couple of possible weirdies with Sit & aFollow, Basically my bot refuses to accept a command to sit & aFollow wants to target my pet instead of me.


l-l-v

LordGiddion
a snow griffon
a snow griffon
Posts: 352
Joined: Sat Sep 13, 2003 6:12 pm
Contact:

Post by LordGiddion » Sun Apr 25, 2004 10:48 am

leaving-las-vegas: ok I think I fixed Afollow to work better for you. Could you give a better explination of "weirdness" with Sit? Do you get any error message or anything?

leaving-las-vegas
decaying skeleton
decaying skeleton
Posts: 3
Joined: Sun Apr 25, 2004 10:22 am
Location: Little Britain

Post by leaving-las-vegas » Sun Apr 25, 2004 11:07 am

Not sure its gonna help much, there don't seem to be any errors being created when I ask the bot to sit, Simply won't sit.

I'm still v.green to the world of MQ but I'll have a play around and see what else I can dig up

LordGiddion
a snow griffon
a snow griffon
Posts: 352
Joined: Sat Sep 13, 2003 6:12 pm
Contact:

Post by LordGiddion » Sun Apr 25, 2004 11:14 am

Depending on what happens today I'm hoping to have ChainStun, ChainNuke, and a New SelfBuff & SpellGem Commands done.

SelfBuff will work like Buff but only for buffs the bot does on itself - won't use timers to recast the way Buff does. Will also be adding an Ini entry so you can program the bot to always maintain a set list of buffs on itself at all times.

SpellGem will set what spell gem the bot will use to mem spells when requested to cast a spell that isn't currently mem'd (currently the code is hardcoded to gem 8)

leaving-las-vegas
decaying skeleton
decaying skeleton
Posts: 3
Joined: Sun Apr 25, 2004 10:22 am
Location: Little Britain

Post by leaving-las-vegas » Sun Apr 25, 2004 11:36 am

OK, ran a few sanity checks on what I'd been doing just incase the afollow problem was affecting sit but it doesn't seem so, I can confirm there are no error messages related to the command.

Updated files and aFollow works like a charm now, Let me just clarify - I "/tell botname Sit" should be enough to get it to sit right?

This may help a little, asking the Bot to camp prompts the response that its camping out but it doesn't sit but also doesn't complain about it with any error

MrSmallie
a hill giant
a hill giant
Posts: 167
Joined: Fri Oct 11, 2002 11:18 am

Post by MrSmallie » Sun Apr 25, 2004 12:25 pm

Try it with the AutoStand option is disabled. Maybe the Forward key is being pressed which causes it to stand back up?
Me
[img]http://home.comcast.net/~mrsmallie/ches.JPG[/img]

xander
a lesser mummy
a lesser mummy
Posts: 33
Joined: Thu Apr 22, 2004 11:40 pm

Sitting

Post by xander » Sun Apr 25, 2004 12:34 pm

In regards to sit not working, think this is your problem.

Line 772 of botcore.inc

Code: Select all

/if (${Me.Standing}) /sit
This always evaluates to NULL for me. Try this:

Code: Select all

/if (${String[${Me.State}].Equal[STAND]}) /sit
Fixed it for me
Xander

xander
a lesser mummy
a lesser mummy
Posts: 33
Joined: Thu Apr 22, 2004 11:40 pm

Post by xander » Sun Apr 25, 2004 12:41 pm

Also looks like it needs done on line 683 of botcore.inc to make it sit after doing something.

EDIT: As a matter of fact, i had to do a global replace on this phrase. Is there some reason it was working for you and not us? It was in most of the files in one place or another. ${Me.Standing} is NULL for me.

Also, looks like there is no check to sit after cast when doing a shortcut from the .INI. (IE Sow me - doesn't sit automatically afterwards)
Xander

fez_ajer
a ghoul
a ghoul
Posts: 106
Joined: Fri Apr 23, 2004 6:44 pm
Location: If I was up your ass you'd know where I was...

I'll make my request here now ;)

Post by fez_ajer » Sun Apr 25, 2004 1:04 pm

The current Do-Assist does this:

Code: Select all

/if (@PetOnAssist==1) /pet attack
can we make it do something like this instead:

Code: Select all

/if (@PetOnAssist==1) {
    /if (${String[${Me.State}].Equal[SIT]}) /stand
    /call Delay 5
    /pet attack
    /call Delay 5
    /if (@SitAfterCast==1 && ${Me.State.Equal[STAND]}) /sit
    }
to prevents the dress-wearing pet slinger from getting whacked when they assist early.

fez_ajer
a ghoul
a ghoul
Posts: 106
Joined: Fri Apr 23, 2004 6:44 pm
Location: If I was up your ass you'd know where I was...

Anchoring...

Post by fez_ajer » Sun Apr 25, 2004 1:26 pm

Heya Lord,

Currently I use follow/stay an AWFUL lot when crawling a group of bots. I'm going to start using anchor more but have a quick question or two:

1) I don't see anchor getting canceled by anything but the startup code and a second call to Do-anchor. Shouldn't a follow kill the current anchor? I can't think of a reason why it shouldn't but I've never actually used it so I figured I'd ask...

2) Along with one, if follow kills the anchor should there be an option to stay to set it? (maybe I'm a hosebag, in fact, yah, I'm a hosebag, but I like the idea of saying 'stay here' and having them, well, stay there)

- Fez