sits.mac - slightly improved ts.mac

Clone39 · Post by **Clone39** » Mon Aug 04, 2003 5:45 pm

yeah i know about this sellitem macro, it comes with the CVS. But where should i put it?! I'm trying to see where in the macro it should be put so that when i run out of components it will call the sell item, but since i'm still in the macro learning process i cannot see a good place. I still can't read a macro that well.

thanks

Clone39

EqMule · Post by **EqMule** » Mon Aug 04, 2003 5:51 pm

dude, the /sell thing that comes as an /alias is good, but it can get so much better without the mouseclicks...

use my /sellitem code instead, and you wont need that /alias ...

I better tell ppl, IF you compile the /sellitem command, you need to remove the alias...

Code: Select all

/alias /sell delete

or whatever the syntax is...

fryfrog · Post by **fryfrog** » Mon Aug 04, 2003 10:26 pm

This is something I would not add to this script, its not meant to automatically make and do everything for you, just save you the repeated clicking that is involved with combining hundreds of items.

kagonis · Post by **kagonis** » Sun Aug 10, 2003 3:02 pm

First, fryfrog, I like your additions, they are really usefull :)
I have one thing that should be added, that will speed up the combines (you can set the delay as low as 2), without making it forget to drop the components:

In Sub Main:
Find:

Code: Select all

   :Begin
      /doevents

Replace with:

Code: Select all

   :Begin
      /call ClearCursor $FinishedProduct
      /doevents

Also the retry after fail combine thing, should have a max number of retrys before giving up. If you do a combine with 2 same components, ie: 2x Mandrake Root or 2x Spider Silk etc. and you end up with only 1 left, it will keep trying to restore forever..

kagonis · Post by **kagonis** » Tue Aug 12, 2003 5:08 am

Added a "Stop on Trivial" to make it end the macro and show statistics when an item has become trivial.
Usefull when skilling up an expensive skill.

Find:

Code: Select all

#define DesiredSuccesses v62

Replace:

Code: Select all

#define DesiredSuccesses v62
#define EndOnTrivial v63

Find:

Code: Select all

	| SET SHOWSTATS TO 1 TO SHOW STATS AND WARNINGS, 0 FOR OFF
	/varset ShowStats 1

Replace:

Code: Select all

	| SET SHOWSTATS TO 1 TO SHOW STATS AND WARNINGS, 0 FOR OFF
	/varset ShowStats 1
	| SET ENDONTRIVIAL TO 1 TO STOP THE MACRO WHEN ITEM BECOMES TRIVIAL
	/varset EndOnTrivial 0

Find:

Code: Select all

	/if n $ShowStats==1 /if n $SkillTrivialCounter==1 /echo THIS ITEM IS OR HAS GONE TRIVIAL!

Replace:

Code: Select all

	/if n $ShowStats==1 /if n $SkillTrivialCounter==1 /echo THIS ITEM IS OR HAS GONE TRIVIAL!
	/if n $EndOnTrivial==1 /if n $SkillTrivialCounter==1 /call EndCombines

kagonis · Post by **kagonis** » Tue Aug 12, 2003 7:12 am

Fix to the endless recovering from failed attempt..

Find:

Code: Select all

	/if n $CombineErrorCounter>=1 /if n $ErrorAtCombine<=$calc($SkillFailCounter+$SkillSuccessCounter+5) /varset CombineErrorCounter 0
	/goto :Begin
/return

Replace:

Code: Select all

	/goto :Begin
/return

Find:

Code: Select all

Sub Event_SkillSuccess
	/varadd SkillSuccessCounter 1

Replace:

Code: Select all

Sub Event_SkillSuccess
	/varadd SkillSuccessCounter 1
	/if n $CombineErrorCounter>=1 /varset CombineErrorCounter 0

Find:

Code: Select all

Sub Event_SkillFailure
	/varadd SkillFailCounter 1

Replace:

Code: Select all

Sub Event_SkillFailure
	/varadd SkillFailCounter 1
	/if n $CombineErrorCounter>=1 /varset CombineErrorCounter 0

fryfrog · Post by **fryfrog** » Wed Aug 13, 2003 3:31 am

That fix to the failed combines thing was so incredibly simple. Hard to believe I was trying to come up with some super complicated /if statement to do it. I included your other changes as well, haven't tested them but I have to assume that since you made them to yours that they work :)

Thanks.

DontShoot · Post by **DontShoot** » Wed Aug 20, 2003 10:16 am

just felt obliged to stop by and say what a wonderful job you guys did on this macro. Just skilled up a tradeskill to mastery in no time, going for GM later today.

Note: Don't use combine-type packs for carting inventory around. It messes things up. (I tried using fletching kits to carry stuff)

Slice · Post by **Slice** » Tue Sep 02, 2003 5:51 pm

I'm getting an error that it can't find the forge. Works fine with a sewing kit. This just started after the 26th patch, downloaded and recompiled the new MQ code today and went to do some smithing. Anyone else having a problem with environmental containers?

Slice

Consilium · Post by **Consilium** » Tue Sep 02, 2003 7:11 pm

Is $count working yet? I changed all my macros to use a work around. I wanted to try this macro but im thinking it won't work with the problems with $count.

Valerian · Post by **Valerian** » Tue Sep 02, 2003 10:19 pm

$count should be working.

Consilium · Post by **Consilium** » Tue Sep 02, 2003 10:23 pm

ok.. great.. just did an upgrade and everything works.

fryfrog · Post by **fryfrog** » Tue Sep 02, 2003 11:47 pm

Isn't /click still busted? Or are you guys all doing unfocused in EQW?

Slice · Post by **Slice** » Wed Sep 03, 2003 9:55 am

I'm using it unfocused in EQW. Consilium, when you say everything works great, are you using an environmental container?

Slice

Slice · Post by **Slice** » Wed Sep 03, 2003 9:55 am

dupe post

sits.mac - slightly improved ts.mac

$count

ok good now