MacroQuest64

Updated:
advbot.mac
advbot.inc

Improved the Selfbuff code to automatically buff your selfbuffs upon macro startup if they have SelfBuffIconCheck set to 1 and there is no icon seen with the name stored in your SelfBuffIconName entry. Previously the only way to start debuffing was to set the SelfBuffAtStart (Which is still valid and can be used) or to issue the 'selfbuff x' command.

This change will make it so you don't waste mana rebuffing self buffs if they are already on you with time left on them.

If you have SelfBuffAtStart it will still refresh them on startup regardless if you already have the buff.

Does this only work for channels such as Group, Say, OOC, Shout or is it possible to announce in a custom chat channel? I tried a few things such as channelname and channel# but I couldnt get it to work.

Also, is it just me or are heals broken in the curent version? Heals havnt been working for me in the last 2 versions since | Version 1.69
| Date:5/4/2004 7:00pm

EDIT: you removed the "debug" lines which kinda helped me tell what was going on, buts that ok. I stuck some others back in, but also he stoped responding to commands in a channel from masters. if I /echo <command> it works fine, but if a master types /1 groupbuff all, it never gets processed

EDIT: sorry for postsing so many times, playing with it as I post. He DOES respond when I tell him to groupbuff, but not to a channel command. Just prior to this last update the channel commands did work though and it would be nice if they could.

EDIT: Yea, not just you, heals are now broken for me also. But im only talking about heals automaticlly and not on the watch list. I have not tested specific command heals or the watch list as I dont use either feature. I just have the sham cast a Q every now and then when someones health is a bit low.

Hm, following through Portalbooks doesn't work for me.
Bot doesn't seem to click on Book. He waits 5 secs, then clears target.

Your problem with it not responding to commands you give to chat channels is simply the fact that you need to re-uncomment that #chat chat line at the top of the advbot.mac.

Right now no only group and raid are possible. I'll put that on my todo list.

I'll take a look at the heal/zone issues.

Updated:
advbot.mac

The heal problem should be fixed. Sorry, I'll have to look at the other stuff when I get home from work.

chat channels, actually my problem was even more embarressing the bot wasnt in the channel I created

But it DOES work for created channels. For Anncounce channel i set it equal to a channel name I created, and althoug I have announce off, i can type /1 groupbuff all and he will follow it. so custom chat channels do work :) just make sure the damn bot is in the channel haha

But yea, heals are still not working and they are also the part that creates the most notable slowdown when unpaused

EDIT: I didnt refresh to read your post before i posted. Ill check the new file for funcitonal healing.

another minor thing. Which is certainly tolerable but if you can fix it...
mobs at a 0 horizontal distance but very much above or below the bot, driv it crazy

You are going to have to clarify the horizontal, below/above thing. I do have a zradius setting in there because I wanted to avoid your bot targeting stuff in rooms above/below you if you were in a building or something. Is this what you think is going on? Is it affecting you when fighting on a hill or something?

Also, did you test the healing and is it working right? I ran a small test before I had to run to work and it appeared that I'd fixed it.

I just used healing and it was working just fine.

tested healing and while it is still the slowest of all the "tasks" it does indeed work.

Yes, I was meaning z radius. I havnt fought on a hill so I dont have that kind of information, but I was in a very tight dungeon and he kept trying to cast on mobs on the floor above. Perhaps the floors were just to close so they missed the z threshold you have. Ill test it out a bit more and see if I can get something exact for you to work with.

jumpyfrog wrote:tested healing and while it is still the slowest of all the "tasks" it does indeed work.

Slowest of all the tasks? Are you high? It has the highest priority of anything.

What are you doing? Turning on all functions and turning on follow or what? What is your HealCheckTime set for? Is anyone else getting this behavior that jumpyfrog is? Or is he wasting my time?


As far as the zradius thing it either:

A: Isn't working with the new parm system

or

B: I have it set just a bit too high and need to lower it a bit.

Im not trying to waste your time or even complain. I actually really like your macro, and use it. So dont take anything I say the wrong way. I am just noting what I observe and I apologize as I problably worded it poorly.

Healing is very response, yes. Heals land on time and quite often, so your priority does in fact check out. What I meant to say is that when I have events, heal and debuffy on, which are what I keep on. During normal, not intensive time, heal seems to take longer to execute its "check" than the debuff and events do. Like I said, seems to take longer. I havnt timed the function or anything, Its just an analysis from running the macro.

EDIT: To my previous pst on z buffering, after further testing it does work correctly. The place I was in just happen to have mobs above me but very close......think of it like a bridge where I am below and mobs are above but when yo uare below you wont agro anything, but the bot tries to cast above. In a normal dungeon environment where the floors have a greater z depth difference, it causes no problems.

only have healing and 1 group buff healing is working fine and its fast.

ok, here is what I meant to say...and I apologize for terribly blotching it.

Standard INI settings:
debuffs on -2s
heals on - 1s
events on -1s
Everything else standard and working properly

I added a echo of the current time at the beginning of the MAIN loop of advbot.mac this is what I meant by healing is the slowest:

Just sitting down. No combat, no buffing, no healing, 100% just sitting still in a corner:

[Fri May 07 19:54:59 2004] [MQ2] 19:54:59
[Fri May 07 19:54:59 2004] [MQ2] 19:54:59
[Fri May 07 19:55:12 2004] [MQ2] 19:55:12
[Fri May 07 19:55:12 2004] [MQ2] 19:55:12
[Fri May 07 19:55:25 2004] [MQ2] 19:55:25
[Fri May 07 19:55:25 2004] [MQ2] 19:55:25
[Fri May 07 19:55:37 2004] [MQ2] 19:55:37
[Fri May 07 19:55:38 2004] [MQ2] 19:55:38

As you can see here the avg time to execute the macro(1 loop) with those 3 things on is approx. 10-13 seconds, no need to be terribly specific as youll see.

Now exact sme thing, sitting in a corner, no buffing, no healing, no actions of any kind, exact same macro session just with healing paused:
[Fri May 07 19:56:28 2004] [MQ2] -[ Healing Paused. ]-
[Fri May 07 19:56:30 2004] [MQ2] 19:56:30
[Fri May 07 19:56:30 2004] [MQ2] 19:56:30
[Fri May 07 19:56:32 2004] [MQ2] 19:56:32
[Fri May 07 19:56:32 2004] [MQ2] 19:56:32
[Fri May 07 19:56:36 2004] [MQ2] 19:56:36
[Fri May 07 19:56:36 2004] [MQ2] 19:56:36
[Fri May 07 19:56:38 2004] [MQ2] 19:56:38
[Fri May 07 19:56:38 2004] [MQ2] 19:56:38
[Fri May 07 19:56:42 2004] [MQ2] 19:56:42
[Fri May 07 19:56:42 2004] [MQ2] 19:56:42

-See the difference? Removing healing makes the macro run, literally about 2x as fast, this healing is the slowest "check". Im not saying this is bad or your macro is bad, again I love it. Im just saying there is some either neccessary extra checking happenning in healing, or extra unneccassary(i know I cant spell) checking in healing. Either or is fine with me but I just wanted to point that out in case you do want to improve it.