/if statements on working

Iceassassin · Post by **Iceassassin** » Mon Jan 06, 2003 6:02 pm

Hmm.. My if statements don't work anymore.. Can anyone tell me whats wrong with this macro?

#include routines.mac

Sub Main
:loop
/call Heal

Sub Check
/if n $char(hp,pct)<100 /call Main
/if n $char(hp,pct)==100 /call End
/return

Sub Heal
/call check
/press 0
/delay 151
/goto :loop
/return

Sub End
/endmacro
/return

SingleServing · Post by **SingleServing** » Mon Jan 06, 2003 9:44 pm

Iceassassin wrote:Hmm.. My if statements don't work anymore.. Can anyone tell me whats wrong with this macro?

#include routines.mac

Sub Main
:loop
/call Heal

Sub Check
/if n $char(hp,pct)<100 /call Main
/if n $char(hp,pct)==100 /call End
/return

Sub Heal
/call check
/press 0
/delay 151
/goto :loop
/return

Sub End
/endmacro
/return

I don't think you can call main, never tried but it sounds totally wrong. You also never placed a /return in your main, try this

|*****************************************|

#include routines.mac

Sub Main
:Loop

/if n $char(hp,pct)<100 {

/press 0
/delay 151
/goto :Loop
}

/if n $char(hp,pct)==100 /return

|*****************************************|

I would use bbcodes for this macro but the < symbol is all fugered up

Zorg · Post by **Zorg** » Mon Jan 06, 2003 9:55 pm

Problem solved, not through SingleServing's smartass answer, but for some reason the board was displaying the codes for < and > instead of the characters themselves, and I failed to notice.

SingleServing · Post by **SingleServing** » Mon Jan 06, 2003 10:05 pm

Zorg wrote:I seem to be having a different problem related it if, /if "$foo(argument)"=="TRUE" will evaluate correctly, but /if $foo(argument)==TRUE doesn't.

The problem is, other people don't seem to be having the same problem. Scripts posted in the depot using the second style of /if are running for at least some people.

/if <n> <condition> <command>
Runs a command if the condition is true. (n makes the compare numeric)
Condition understands comparison operators

== Equal to
!= Not Equal to
> < Greater than; less than
>= <= Greater than or equal to; Lesser than or equal to
~~ contains operator (string only)

!~ does not contain operator (string only)

readme a lovely thing

Fippy · Post by **Fippy** » Tue Jan 07, 2003 4:44 am

Maybe you consider ss to be a smartarse but hes still correct /call Main is just plain wrong in many ways. So is a goto in a sub that goes into a different sub. It may well work for a while but its not easy to read and if you went on the write a 500 line script like that youd never be able to debug it.

/goto should only jump to a new place within the same sub

I realize your new to MQ scripting but flaming somebody for trying to help aint very nice. If you thinks somebody is an ass, ignore em.

this is the code you originally posted but editied to use proper flow control.

Sub Main
:loop
/call Heal
/if n $char(hp,pct)<100 /goto :loop
/return

Sub Heal
/press 0
/delay 151
/return

as you can see its a lot shorter and easier to understand.

SingleServing · Post by **SingleServing** » Tue Jan 07, 2003 8:20 pm

Zorg wrote:Problem solved, not through SingleServing's smartass answer, but for some reason the board was displaying the codes for < and > instead of the characters themselves, and I failed to notice.

I am a smart ass but at least I have good intentions. I did try to help you and event wrote a working macro for you to use. My suggestions were ment to help you and not to mock you. I am sorry if I made you feel smaller, that was not my intention.

Yes < and > are messed up when you put them inside BBcode =/

Malachi · Post by **Malachi** » Thu Jan 09, 2003 12:58 am

I know EXACTLY what the problem is.

It's a failure to use code brackets....hehe.

~malachi

SingleServing · Post by **SingleServing** » Thu Jan 09, 2003 2:22 am

Malachi wrote:I know EXACTLY what the problem is.

It's a failure to use code brackets....hehe.

~malachi

No code brackets is what causes the problem

< and >

is the same as

Code: Select all

< and >

AarynD · Post by **AarynD** » Thu Jan 09, 2003 3:55 pm

Actually, /call Main is a legitimate construct in other programming languages (ie, functions meant to be called recursively)... It's doubtful MacroQest supports it. In either case, the call to main in the above code was not the proper use of a recursive call, as there is no "exit" back out of the recursion loop.

- Aaryn

SingleServing · Post by **SingleServing** » Thu Jan 09, 2003 4:53 pm

AarynD wrote:Actually, /call Main is a legitimate construct in other programming languages (ie, functions meant to be called recursively)... It's doubtful MacroQest supports it. In either case, the call to main in the above code was not the proper use of a recursive call, as there is no "exit" back out of the recursion loop.

- Aaryn

Key word "other" MQ is written in VC++ =)

Fippy · Post by **Fippy** » Fri Jan 10, 2003 3:55 am

Oh my somebody started talking about recursion. Before anybody starts asking what that is please lock this thread. it make me insane when people try to explain recursion to somebody with no knowledge of programming constructs.

roguish · Post by **roguish** » Fri Jan 10, 2003 7:57 pm

recursion is when you call a routine, nothing works, you fix it you thought and your computer crashes, and you curse again and again

/if statements on working

/if statements on working

Re: /if statements on working

I know what it was.

Re: I know what it was.

/call Main

Re: /call Main