Bug Report for SOE

[Amadeus]

I'm going to write this up here. Then, if someone could post it on the official SOE boards (or multiple people) that would be great. Just say that you read it on some other boards and it looked interesting or something :)

I just don't want to post on the boards myself because then everyone will know who I am ..lol.

Anyway, this should make someone blush...

--------------------------------------------------------------

Dear SOE,

There is a glaring bug in your code that, although is not the sole cause of why ability links do not work, it's definitely contributing to why fixing it has not occured since release!

If you will notice in this bit of code from the 8/11/2005 executable:

Code: Select all

.text:0060792F                 mov     eax, [esi+0Ch]    
.text:00607932                 push    eax
.text:00607933                 mov     eax, [edi+1]  
.text:00607936                 push    eax
.text:00607937                 push    offset aAabilityUlS ; "\\aABILITY %ul %s:"

Everything looks good except that 'unsigned long' is %u ...not %ul. So, when you try to link an ability, you get this:

Code: Select all

\\aABILITY 1540760413l Winds of Renewal:Winds of Renewal\\/a

instead of what you want, which is this:

Code: Select all

\\aABILITY 1540760413 Winds of Renewal:Winds of Renewal\\/a

Unfortunately, the link still doesn't work when it's corrected, so you'll need to fix some other things too. But, my assumption is that someone just never noticed this mistake and gave up on fixing it! :)

[Amadeus]

I keep posting this ...but I can't help it ....it makes me giggle.

from test server patch notes:

- Abilities sent via chat links will now work correctly.