Self Automated Tradeskill Macros

bene0019 · Post by **bene0019** » Tue Nov 30, 2004 12:02 am

The fletching macro needs to be changed. the vendor doesn't carry the lower trivial ingredients anymore. I started with making CLASS 3 Wood Point Arrow instead.

I did baking from 54 (free skill up quests) to 191 in about an hour for about 250 plat

I did fletching from 54 to 200 in about 1 1/2 hours for about 850 plat.

I did brewing from 54 to 213 in about 2 hours for about 450 plat.

Going to get pottery up next then jewelcraft.

Sure wish I has the tailoring mac

rustedone · Post by **rustedone** » Tue Nov 30, 2004 6:12 am

ok havin some issues with the bazaar buying macro... its not distinguishing prices correctly... it is trying to buy items for ALOT more pp than it is being told.... also is there a way to set it so that maybe it will calculate how much pp u have available and how many of x item you can afford?.....

here is my code... let me know if something is wrong

Code: Select all

#include common/bazaarbuy.inc
#include common/buy.inc
#include common/gogetitem.inc

Sub Main 

   /declare ItemToBuy string inner
   /declare HighestPriceToPay int inner
   /declare TotalYouWant int inner
   :start

   /varset ItemToBuy "Mudflow Stone"
   /varset HighestPriceToPay 1000000
   /varset TotalYouWant 1
   /call BazaarBuy ${ItemToBuy} ${HighestPriceToPay} ${TotalYouWant}
|should buy mudflow stone for 1kpp
   /varset ItemToBuy "sphalerite"
   /varset HighestPriceToPay 1000000
   /varset TotalYouWant 1
   /call BazaarBuy ${ItemToBuy} ${HighestPriceToPay} ${TotalYouWant}
|should buy saphalerite for 1kpp
   /varset ItemToBuy "Tourmaline"
   /varset HighestPriceToPay 1000000
   /varset TotalYouWant 1
   /call BazaarBuy ${ItemToBuy} ${HighestPriceToPay} ${TotalYouWant}
|should buy tourmaline for 1kpp
   /varset ItemToBuy "sphalerite"
   /varset HighestPriceToPay 1000000
   /varset TotalYouWant 1
   /call BazaarBuy ${ItemToBuy} ${HighestPriceToPay} ${TotalYouWant}
|should buy sphalerite for 1kpp
   /varset ItemToBuy "Dust of Discord"
   /varset HighestPriceToPay 500000
   /varset TotalYouWant 8
   /call BazaarBuy ${ItemToBuy} ${HighestPriceToPay} ${TotalYouWant}
|should buy dust of discord for 500pp
   /varset ItemToBuy "Pyrilen Plasma"
   /varset HighestPriceToPay 1000000
   /varset TotalYouWant 1
   /call BazaarBuy ${ItemToBuy} ${HighestPriceToPay} ${TotalYouWant}
|should buy pyrilen plasma for 1kpp
   /varset ItemToBuy "slugworms"
   /varset HighestPriceToPay 200000
   /varset TotalYouWant 20
   /call BazaarBuy ${ItemToBuy} ${HighestPriceToPay} ${TotalYouWant}
|should buy slugworms for 200pp
   /varset ItemToBuy "Discordant Scoriae"
   /varset HighestPriceToPay 500000
   /varset TotalYouWant 20
   /call BazaarBuy ${ItemToBuy} ${HighestPriceToPay} ${TotalYouWant}
|should buy discordant scoriae for 500pp
/delay 600s
/goto :start

/return

ive tried taking the 0's out for the copper, silver, and gold... and all it does then is try to buy items that are far over priced.... currently it wont try to buy anything

PS ive used your other macro's override and they are awsome.... please release that tailoring one soon i would love to get my tailoring up

if i run this portion just like this....

Code: Select all

   /varset ItemToBuy "Dust of Discord"
   /varset HighestPriceToPay 500
   /varset TotalYouWant 8
   /call BazaarBuy ${ItemToBuy} ${HighestPriceToPay} ${TotalYouWant}
|should buy dust of discord for 500pp

it will find dust of discord selling for 4k each... not 500pp

rustedone · Post by **rustedone** » Tue Dec 07, 2004 3:33 pm

just an FYI if your gonna run the trade skill macro's and get "salvage" get it after you max your trade skill... because it leaves the item in the container

MeGoober · Post by **MeGoober** » Mon Dec 13, 2004 1:57 am

Go back one page and look at the code contribution I made on Tue Nov 16, 2004 at 2:03 pm concerning salvage. If you do that to any of his routines, they work great again.

It looks like we will never see tailoring...the last change on his own site was 9.25.04. Oh well...it sounded nice...

sapper69 · Post by **sapper69** » Fri Dec 17, 2004 10:39 pm

can't say I've seen the tailoring macro yet. Just curious if it's still being offered to those that donate to the cause.

MeGoober · Post by **MeGoober** » Sun Dec 19, 2004 4:16 am

I just compiled the new release and decided to head over to Abysmal Sea to update a few skills...the handler seems to respond differently now. When I go to buy components, it keeps buying and buying and buying...

I recompiled again thinking I have something wrong but same result. The files are the same and they were working previously so something with the current patch has changed. Not sure what to do.....

Before I spend a lot of time tearing into this, does anyone else see it? Is anyone running correctly with todays release? Just want to triple check my build before I start stepping thru the code. Thanx for any response.

Lacky · Post by **Lacky** » Mon Dec 20, 2004 6:22 am

There seems to be a problem with FindItemCount. It currently only returns how many slots of inventory the item is taking up. Thats the easiest way I can think to explain it this late....

So for instance if you had a stack of 20 water flasks it will return 1.
If you have 21 water flasks it returns 2.

The easiest fix atm for over's macros is to edit the macro so it buys 2 instead of 20 though as I recall it was still having issues and I just rewrote part of the buy.inc I have to work better (we will see if its any better tomorrow when I compare the two :)

Night hope that helps.

tcp22 · Post by **tcp22** » Mon Dec 20, 2004 9:32 pm

I am seeing the same issue where it buys and buys... will take a look and see if I can see what gives.

tcp22 · Post by **tcp22** » Mon Dec 20, 2004 9:40 pm

I tried:
http://macroquest2.com/phpBB2/viewtopic.php?t=8508

And it did not make any difference. I assume that this fix is no longer valid, anyone know for sure?

Cr4zyb4rd · Post by **Cr4zyb4rd** » Mon Dec 20, 2004 9:47 pm

There's an entire thread started after the recent patch based just upon this issue. The short version of the story is that it's a fairly non-trivial fix, but a new zip should be released soon that fixes the itemcounts and other problems related to stackables.

tcp22 · Post by **tcp22** » Mon Dec 20, 2004 10:27 pm

Thanks for the info, can you post a link to the thread that you mentioned?

Neolesh · Post by **Neolesh** » Mon Dec 20, 2004 10:33 pm

tcp22 wrote:Thanks for the info, can you post a link to the thread that you mentioned?

Use search for gods sake. and just a hint.. use FindItemCount as your search parameters! I am a genius

tcp22 · Post by **tcp22** » Mon Dec 20, 2004 11:00 pm

For gods sake, that worked like a charm! What a lazy knuckle head I am.
Anyways, I digress... thanks.

Simmon4fingers · Post by **Simmon4fingers** » Wed Dec 22, 2004 8:19 am

Has anyone else got any fixes for the Salvage return? I have done the previously posted clean container fix. However if there are multiple items returned it doesn't seem to work for me. Any Ideas?

Simmon4fingers · Post by **Simmon4fingers** » Wed Dec 22, 2004 2:29 pm

Well I think i have got it working now. Although it may be a ghetto fix rather than the soulution. In addition to adding the clear container subroutine in the docombine I add a ClearCursor just before it to clear one of the two items before the clear container subroutine ran.

If anyone has a better solution please let me know I'm obviously a noob fingering around in the code.

Self Automated Tradeskill Macros

Salavage Issue

After a donation

System Down

Problem with FindItemCount

Salvage Problem