small bug.. take a look at this Assist-Melee Macro

[eqjoe]

This works, however every OTHER time the event fires the target is NULL.

Anyone have an idea as to why?

Code: Select all

| Melee Assist Macro .
| Attack on Assist request 


#event AssistAF "Assist me"

Sub Main
 
 /varset v30 $p0
 


:Start

/delay 1
/doevents 
/goto :Start

/return

sub CombatAF
 :CloserAF 
   /if "$target(id)"!="$v1" /goto :EndAF 
   /if n $target(distance)>20 /sendkey down up 
   /if n $target(distance)<11 /sendkey down down 
   /if n $target(distance)<21 /sendkey up up 
   /if n $target(distance)>10 /sendkey up down 
   /doability 9 
   /doability 8 
   /doability 7 
   /face 
   /goto :CloserAF 
  
 :EndAF 
   /echo $v0 is dead 
   /sendkey up up 
   /sendkey up down 
   /attack off 
   /varset v0 0 
   /varset v1 0
/return

sub Event_AssistAF

   /assist $v30
   /echo assisting $v30 
| the next line echos "Fighting NULL. It is level 0." every OTHER time it runs
   /echo Fighting $target(name). It is level $target(level). 
   /varset v0 $target(name) 
   /varset v1 $target(id) 
   /face 
   /sendkey down up 
   /attack on 
   /call CombatAF
/return

[eqjoe]

Ok... Figured this one out.. it was simple enough.

The fix was to add a delay after the /assist and before the /varset.
Here is the working macro.

Code: Select all

| Melee Assist Macro . 
| Attack on Assist request 
| useage /macro af <name of person to assist>
| Bot assists when a tell or group tell is send to trigger event
|

#event AssistAF "Assist me" 

Sub Main 

/varset v30 $p0 



:Start 
/doevents 
/goto :Start 

/return 

sub CombatAF 
:CloserAF 
   /if "$target(id)"!="$v1" /goto :EndAF 
   /if n $target(distance)>20 /sendkey down up 
   /if n $target(distance)<11 /sendkey down down 
   /if n $target(distance)<21 /sendkey up up 
   /if n $target(distance)>10 /sendkey up down 
   /doability 9 
   /doability 8 
   /doability 7 
   /face 
   /goto :CloserAF 
  
:EndAF 
   /echo $v0 is dead 
   /sendkey up up 
   /sendkey up down 
   /attack off 
   /varset v0 0 
   /varset v1 0 
/return 

sub Event_AssistAF 

   /assist $v30 
   /echo assisting $v30 
   /delay 2
   /echo Fighting $target(name). It is level $target(level). 
   /varset v0 $target(name) 
   /varset v1 $target(id) 
   /face 
   /sendkey down up 
   /attack on 
   /call CombatAF 
/return 

[rizwank]

nice.

Id add like 4 triggers just so its less obvious if you are in a group or if vi is watching.