Cash Macro

Need help with a macro you are writing? Ask here!

Moderator: MacroQuest Developers

User avatar
peach
a hill giant
a hill giant
Posts: 156
Joined: Fri Sep 10, 2004 8:20 pm

Cash Macro

Post by peach » Mon Oct 11, 2004 8:41 pm

No, this isn't a "money making macro".... I tried to make a mac that takes your cash from your inv, puts it in bank, changes it, and than toss the plat in shared bank.

This was what I got first:

Code: Select all

Sub Main

|Put Platinum from Inventory to Bank
/shift /notify InventoryWindow IW_Money0 leftmouseup
/shift /notify BigBankWnd BIGB_Money0 leftmouseup


|Put Gold from Inventory to Bank
/shift /notify InventoryWindow IW_Money1 leftmouseup
/shift /notify BigBankWnd BIGB_Money1 leftmouseup

|Put Silver from Inventory to Bank
/shift /notify InventoryWindow IW_Money2 leftmouseup
/shift /notify BigBankWnd BIGB_Money2 leftmouseup

|Put Copper from Inventory to Bank
/shift /notify InventoryWindow IW_Money3 leftmouseup
/shift /notify BigBankWnd BIGB_Money3 leftmouseup

|Change
/notify BigBankWnd BIGB_ChangeButton leftmouseup

|Bring Platinum to Shared Bank
/shift /notify BigBankWnd BIGB_Money0 leftmouseup
/delay 5	
/shift /notify BigBankWnd BIGB_SharedBankLabel leftmouseup

/end
However, when you run it, if you have 0 in any of the inventory slots, and something in the bank slot, it will pick up the bank cash and move it to the next inventory slot. To try to fix this, I put this on every instance of where it moves money:

Code: Select all

|Put Platinum from Inventory to Bank
/shift /notify InventoryWindow IW_Money0 leftmouseup
/delay 5
/if (${Cursor.ID}) {
/shift /notify BigBankWnd BIGB_Money0 leftmouseup
}
This didn't work either. Apparently the delay or something was too much, because it would pick up the money and than deposit it in the slot right below it. Any ideas?

hiipii
a ghoul
a ghoul
Posts: 93
Joined: Sat Jun 19, 2004 5:01 pm

Post by hiipii » Tue Oct 12, 2004 1:16 am

${Cursor.ID} returns null with money so try

Code: Select all

/if (${Me.Platinum}) {
  |Put Platinum from Inventory to Bank 
  /shift /notify InventoryWindow IW_Money0 leftmouseup 
  /shift /notify BigBankWnd BIGB_Money0 leftmouseup
}
Then repeat for ${Me.Gold} ${Me.Silver} and ${Me.Copper}.
This is untested but almost positive it should work...good luck.

User avatar
peach
a hill giant
a hill giant
Posts: 156
Joined: Fri Sep 10, 2004 8:20 pm

Post by peach » Tue Oct 12, 2004 2:38 pm

looks like ${Me.Platinum} will work, however the /if would have to be between the inventory and bank statements, not before both.

User avatar
peach
a hill giant
a hill giant
Posts: 156
Joined: Fri Sep 10, 2004 8:20 pm

Post by peach » Tue Oct 12, 2004 3:04 pm

just tried running it, apparently ${Me.Platinum} only does the platinum that's in your inventory, not on your cursor

User avatar
Cr4zyb4rd
Plugins Czar
Posts: 1449
Joined: Tue Jul 20, 2004 11:46 am

Post by Cr4zyb4rd » Tue Oct 12, 2004 4:01 pm

yes, so you moving it in between the inventory and back statements was rather stupid, wasn't it? :)

dman
a hill giant
a hill giant
Posts: 181
Joined: Fri Dec 05, 2003 12:54 pm

Post by dman » Tue Oct 12, 2004 10:13 pm

Can't you hit the Change button in the bank window, pick up the platinum in your inventory, and drop it in the shared bank slot?
I didn't say you were at fault,
I said I was going to blame you.

User avatar
peach
a hill giant
a hill giant
Posts: 156
Joined: Fri Sep 10, 2004 8:20 pm

Post by peach » Tue Oct 12, 2004 10:16 pm

K. Got almost everything to work. The only problem is, ithe macro doesn't detect whether or not you have platinum in the bank, so it doesn't know whether to move it to the shared bank or not.

dman
a hill giant
a hill giant
Posts: 181
Joined: Fri Dec 05, 2003 12:54 pm

Post by dman » Tue Oct 12, 2004 10:24 pm

Code: Select all

${Me.Platinum}
${Me.PlatinumBank}
${Me.PlatinumShared}

User avatar
peach
a hill giant
a hill giant
Posts: 156
Joined: Fri Sep 10, 2004 8:20 pm

Post by peach » Tue Oct 12, 2004 10:39 pm

i believe it's working as intended, however, it seems i dupe the amount of pp i have because it goes so fast, and than i crash to server select (no it doesnt keep the pp). would adding delays fix this?

Code: Select all

Sub Main

/if (${Me.Platinum}) { 
  |Put Platinum from Inventory to Bank 
  /shift /notify InventoryWindow IW_Money0 leftmouseup 
  /shift /notify BigBankWnd BIGB_Money0 leftmouseup 
}

/if (${Me.Gold}) { 
  |Put Gold from Inventory to Bank 
  /shift /notify InventoryWindow IW_Money1 leftmouseup 
  /shift /notify BigBankWnd BIGB_Money1 leftmouseup 
}

/if (${Me.Silver}) { 
  |Put Silver from Inventory to Bank 
  /shift /notify InventoryWindow IW_Money2 leftmouseup 
  /shift /notify BigBankWnd BIGB_Money2 leftmouseup 
}

/if (${Me.Copper}) { 
  |Put Copper from Inventory to Bank 
  /shift /notify InventoryWindow IW_Money3 leftmouseup 
  /shift /notify BigBankWnd BIGB_Money3 leftmouseup 
}

|Change
/notify BigBankWnd BIGB_ChangeButton leftmouseup

/if (${Me.PlatinumBank}) { 	
|Bring Platinum to Shared Bank
/shift /notify BigBankWnd BIGB_Money0 leftmouseup
/shift /notify BigBankWnd BIGB_SharedBankLabel leftmouseup
}

/end

hiipii
a ghoul
a ghoul
Posts: 93
Joined: Sat Jun 19, 2004 5:01 pm

Post by hiipii » Wed Oct 13, 2004 1:11 am

definately want some delays in there even if its just /delay 1

User avatar
aj2k8
a lesser mummy
a lesser mummy
Posts: 56
Joined: Fri Sep 10, 2004 6:58 am

Post by aj2k8 » Wed Oct 13, 2004 10:24 am

How bout changing

Code: Select all

/if (${Me.Platinum}) { 
  |Put Platinum from Inventory to Bank 
  /shift /notify InventoryWindow IW_Money0 leftmouseup 
  /shift /notify BigBankWnd BIGB_Money0 leftmouseup 
} 
to

Code: Select all

/if (${Me.Platinum}) { 
  |Put Platinum from Inventory to Bank 
  /shift /notify InventoryWindow IW_Money0 leftmouseup 
  /destroy
} 

User avatar
Night Hawk
a grimling bloodguard
a grimling bloodguard
Posts: 590
Joined: Fri Aug 13, 2004 4:56 pm

Post by Night Hawk » Wed Oct 13, 2004 3:15 pm

Your cool now super coder.

User avatar
aj2k8
a lesser mummy
a lesser mummy
Posts: 56
Joined: Fri Sep 10, 2004 6:58 am

Post by aj2k8 » Fri Oct 22, 2004 5:14 pm

umm... just got around to reading this... Night Hawk, is that supposed to be a diss? jeez... I was just a bit high when I wrote that...

wolfbaby
a lesser mummy
a lesser mummy
Posts: 45
Joined: Mon Sep 06, 2004 5:34 am

Post by wolfbaby » Sat Oct 23, 2004 10:35 am

this is the code i'm in using

Code: Select all

/if (${Me.Platinum}>0) {
/shift /notify InventoryWindow IW_Money0 leftmouseup 
/delay 1s
/shift /notify BigBankWnd BIGB_Money0 leftmouseup 
/delay 1s 
}
/if (${Me.Gold}>0) {
/shift /notify InventoryWindow IW_Money1 leftmouseup 
/delay 1s
/shift /notify BigBankWnd BIGB_Money1 leftmouseup
/delay 1s 
}
/if (${Me.Silver}>0) {
/shift /notify InventoryWindow IW_Money2 leftmouseup 
/delay 1s
/shift /notify BigBankWnd BIGB_Money2 leftmouseup
/delay 1s 
}
/if (${Me.Copper}>0) {
/shift /notify InventoryWindow IW_Money3 leftmouseup 
/delay 1s
/shift /notify BigBankWnd BIGB_Money3 leftmouseup
/delay 1s 
}

wolfbaby
a lesser mummy
a lesser mummy
Posts: 45
Joined: Mon Sep 06, 2004 5:34 am

Post by wolfbaby » Sat Oct 23, 2004 10:37 am

i add delay cause the FUCKing LAG