Genbot v13.0.3 [Updated 06/15/2004] Buff Queues added!

Post your completed (working) macros here. Only for macros using MQ2Data syntax!

Moderator: MacroQuest Developers

Wishbringer
Contributing Member
Contributing Member
Posts: 230
Joined: Thu Nov 14, 2002 7:00 am

Post by Wishbringer » Tue Jun 15, 2004 12:03 pm

Is an issue of MQ itself. If i wrote /target Bob, i want to target Bob and not his pet....
Hm, btw that Bob i mean is a SK :lol:
So better order in MQ search routine should be changed: PC > Pet > NPC (or something like this)

Roentgen
orc pawn
orc pawn
Posts: 15
Joined: Fri Nov 28, 2003 9:15 pm

Post by Roentgen » Tue Jun 15, 2004 1:05 pm

ok nevermind on the autobehind post- I had follow mode 2 on which i guess is not good for combat mode.



The buff function seems to be tighter than previous versions and keeps up nicely, but I do notice if you are too far away then it doesnt try and ecast the buff when back in range and have to use buff function again.


Also, the monitoring system for watchtarget causes some conflicts. Since the healer basically is very quickly switching targets to watch the bot to be healed, If often casts the next spell in que on wrong target. For example, my cleric casts mark spells on incoming mob- but often hits the bot on watchtarget list.


Lastly, perhaps I dont understand the function verbosity but changing it doesnt do much that I can see. I have trouble with bot spam and it would be nice to have more control over what is returned and how. For example, The only things I really want to hear from bot is snare resist, slow resist, and when complete heal is starting to cast.



despite this aparent whining, I have had fun today tweeking the new version and its wonderful! Thanks for putting it out here for us.


Roentgen

gus
a lesser mummy
a lesser mummy
Posts: 70
Joined: Fri Apr 09, 2004 11:58 pm

Post by gus » Tue Jun 15, 2004 7:19 pm

With my hacked up faster /call and /if, on my AMD box I go from 95/200 with no macro, to 89/200 with Genbot started, and on my P2, I go from 18/200 to 16/200. Lax has apparently made the /if even faster, so next MQ2 release should hopefully work even better (assuming he gets /call improvement in as well).

I guess my point is that there's not much you can do as a macro writer to improve FPS (long term), because you only get to run at most 40 macro lines between each frame. If MQ2 is efficient enough that no matter what those 40 lines are (assuming we're not talking some funky ass plugin commands that suck and are really slow, etc.) they cannot possible drop your framerate too much, then it is almost completely outside your ability to make a macro better in terms of FPS.

Thus, your time/effort is best spent in making the most understandable macro code that does the proper thing at the lowest framerate someone decides to play at. Let's say that's 10 FPS (old hardware), which means you have 400 macro lines to do something within 1 second, that's a heck of a lot lines.

What I've learned in the last week or so, is that MQ2 is so damn fast and efficient, that a problem with FPS because a macro is running is likely a problem with MQ2 and not the macro.

I'll now shut the fuck up.

--gus

gistane
decaying skeleton
decaying skeleton
Posts: 4
Joined: Tue Jun 15, 2004 9:41 pm

Post by gistane » Tue Jun 15, 2004 9:45 pm

When i try and load the macro doing this
/macro genbot <name>
to load for the first time i get this error

/declare 'MasterCount' failed. Name already in use.
genbot.mac@(38) (Main): /declare MasterCount int local
/for loops must use an int variable
genbot.mac@(39) (Main): /for MasterCount 0 to ${Macro.Params}
The current macro has ended


Any ideas??

User avatar
Undies
a ghoul
a ghoul
Posts: 94
Joined: Mon Oct 20, 2003 9:12 pm

Post by Undies » Wed Jun 16, 2004 8:07 am

Is there any way currently to prevent bots running off after gating mobs?

If not I'll write something for my personal.inc file.

Vexix
Genbot Janitor
Posts: 245
Joined: Sat Apr 17, 2004 10:10 am

Post by Vexix » Wed Jun 16, 2004 11:35 am

Gus, thanks for the comments. I thought you had framerates of 124 without any macros running? If the difference is as small as you mention above, then you're right, and I'll just stick to making solid maintainable code. :)

Undies -- I put some anti-gate code into the next genbot release.

Gistane -- Um, do you have another macro you use with MasterCount declared as a global?

Roentgen -- I looked over the old buff code, and found out that it was casting retries faster after a failed debuff, such as out of range. I've updated the buff code to be similar to the old code for next release.

With the new code, buffs are still cast even if fighting. Should I stop the bot from casting buffs during melee, so it stores the buffs until after the battle?

The new casting code is actually pretty solid on targetting, even with healing. I used it for several hours with my druid with healing and dotting without a single miscast. You may have confused "sn" with "snt" as I did. if you want to /assist the maintank to get the target, use "sn". If you want to use the bots current target or specify a target, use "snt."

Regarding the ChatOut commands, you're right -- it's a bit random now. It sounds like you would like to volunteer to improve the genbot responses and verbosity rating. ;) I'm looking for someone to help create a system for what genbot commands should get what kind and what level of response.

As for the target pet thing, I may rewrite the target code to correct it. There's a lot of targetting code, though, so I'm not looking forward to it.

--Vexix
Last edited by Vexix on Wed Jun 16, 2004 7:00 pm, edited 1 time in total.

sj_digriz
a lesser mummy
a lesser mummy
Posts: 40
Joined: Wed Jun 02, 2004 9:10 am
Contact:

Post by sj_digriz » Wed Jun 16, 2004 12:39 pm

I'm confuxored on using buff,sn,snt on self only buffs that I don't want refreshed.

i.e. Improved Invis.

I want a shortcut

invis = buff improved invisibility

BUT, I don't want it in the rebuff queue. If I use sn or snt it craps out without target info and I don't want to have to target each bot, I was hoping to issue one invis into the chat channel and have the bots go to town.

I tried:

invis = snt improved invisibility on botname

this gave an invalid target error NULL NULL, I'm assuming because it is a no target spell.


any suggestions? Also, is there a way to clear the rebuff queue without restarting the macro?

gus
a lesser mummy
a lesser mummy
Posts: 70
Joined: Fri Apr 09, 2004 11:58 pm

Post by gus » Wed Jun 16, 2004 1:11 pm

Framerate depends on what zone I'm in and what I'm looking at, etc. :wink: What matters is the percentage change (about 10%). --gus

Roentgen
orc pawn
orc pawn
Posts: 15
Joined: Fri Nov 28, 2003 9:15 pm

Post by Roentgen » Wed Jun 16, 2004 1:47 pm

Vexix wrote:.

With the new code, buffs are still cast even if fighting. Should I stop the bot from casting buffs during melee, so it stores the buffs until after the battle?

The new casting code is actually pretty solid on targetting, even with healing. I used it for several hours with my druid with healing and dotting without a single miscast. You may have confused "sn" with "snt" as I did. if you want to /assist the maintank to get the target, use "sn". If you want to use the bots current target or specify a target, use "snt."

Regarding the ChatOut commands, you're right -- it's a bit random now. It sounds like you would like to volunteer to helpkeep the genbot responses. ;) I'm looking for someone to come up with a reasonable system for what buffs get what level of response.


--Vexix
No I figured out correct usage of SN versus snt in a hurry. Ill try to pay more attension when it is miscasting.


as for casting buffs during battle, I dont see a problem with it. in fact, if you made it so that battle was over, pulling would be slowed quite a bit. I think you already coded for priority of spells such as healing over buffs anyway so not likely to miss a heal due to rebuff. But i suppose a toggle command controlling buffs would not be an easy thing to add at this point.



As for the chat channels, I would most like to see .ini controlled chat verbosity. Perhaps for those who dont want to specify could offer 3 basic settings. 1) full verbosity 2)partial 3)only return resists. The perhaps could specify specifics in .ini for a specific spell set. For example

[spellset]
forlorn deeds=1
insanity=0
cripple=2

where variables are 0= no return from bot at all, 1= full response when start casting and if resisted 2= partial return- bot only communicates if resisted

I dont care if a nuke is resisted or to know if it starts casting- Itrust the script and know its casting. Slow I want to make sure is casting and when it lands. heal would be the same. like on complete heal, knowing when cast started lets me gauge if i need to disc or da in a tight spot. cripple I might just like to know it landed, etc. Might also help manage spam if could specify different areas for bot info to be returned. Example might be resists sent back in tells rather than group.

gistane
decaying skeleton
decaying skeleton
Posts: 4
Joined: Tue Jun 15, 2004 9:41 pm

Post by gistane » Wed Jun 16, 2004 10:28 pm

I finally got the macro to load.

My issues i have had though.

I sometimes tell the bot to /g follow and it says it will follow me but then just doesnt move. Only happens sometimes.

Also when i have died i try to change screens to the bot to take control to fight the mob or to run away but i cant? I normally have the bot follow me shouldnt it be made to stop trying to follow when you die? I have tried typing the command /g stay but it just doesnt respond then i end up dying on the bot as well because i have no keyboard commands to run away or fight etc properly.

Any ideas?

spektralkat
orc pawn
orc pawn
Posts: 22
Joined: Sat Dec 20, 2003 5:25 am

Lot of trouble with combat and targeting..

Post by spektralkat » Thu Jun 17, 2004 8:14 am

Seems since the 6/16 release there is some trouble with following, lots of trouble with botcombat ie many CTD, guessing it has something to do with how the bot aquires target.. from a distance moveto doesnt work it's almost like bot requires line of sight and old world targeting rules..

Trying to test and capture error meseges but i'm geting CTD and more often complete recrash requireing complete reboot... no idea whats going on here and not sure what i can tell ya to help ya out

Saelinye
a lesser mummy
a lesser mummy
Posts: 31
Joined: Thu Jun 03, 2004 8:17 am

Repost of Email sent

Post by Saelinye » Thu Jun 17, 2004 8:44 am

Vevix,

I hate to be a jerk, but as of the 6/16 patch... pc mastername no longer works.

If i do /tell druidbot snt shield of thorns on pc mastername

the bot casts on himself.. I then tried

/tell druidbot snt shield of thorns on me and of course.. casts on pet...
dunno what to do..

By the way.. as a side note, unrelated to Genbot... I have another macro doing this command :

/varset spell1 "Shield of Thorns"

/tell druidbot snt ${spell1} on ${Me.pet.name}


for some wierd reasson.. Master command does
/tell druidbot snt Shield of Thorns on Master_Warder

which is correct..but what druid sees on chat is
Master tells you: snt Shield of Thorn on Master_Warde

both variables seemed to have chopped off the last letters ... any ideas ?

Vexix
Genbot Janitor
Posts: 245
Joined: Sat Apr 17, 2004 10:10 am

Post by Vexix » Thu Jun 17, 2004 1:03 pm

Sael,

Sorry. Some quotes got into the code somewhere they shouldn't. Strip the "" marks from around the ${Macro.Return} in botspell.inc under the Do-snt section, like this:

Code: Select all

   } else {
      /call AssignCastTarget "${sntTarget}"
      /varset sntTarget ${Macro.Return}
   }

Roentgen,

Need more info on the cross casting to track it down. Is the message correct, but casts on the wrong person? Message incorrect but casts right? Do you have people on your watchlist who are not in the group? Exactly what command are you using? Are you using the command while the bot is casting a different spell, possibly a heal?

I have an idea for the priority on the spells. Basically, you should make a shortcut for each spell that sets the priority as you want it. I'll work to make sure the priorities are different.

Sj-Digriz

I tried invis=snt improved superior camouflage on name_of_bot_here
and it worked just fine. Um, ya aren't literally typing in "botname" instead of the actual bot charname, are ya? ;)

--Vexix

sj_digriz
a lesser mummy
a lesser mummy
Posts: 40
Joined: Wed Jun 02, 2004 9:10 am
Contact:

Post by sj_digriz » Thu Jun 17, 2004 1:42 pm

Vexix wrote:Sael,
I tried invis=snt improved superior camouflage on name_of_bot_here
and it worked just fine. Um, ya aren't literally typing in "botname" instead of the actual bot charname, are ya? ;)

--Vexix
Well, not botname...but I did have a typo :P. Guess I have to break out Mavis Beacon. I was just editing the cast portion so the typo remained hehe.

spektralkat
orc pawn
orc pawn
Posts: 22
Joined: Sat Dec 20, 2003 5:25 am

CTD after issuing attack comand to bot

Post by spektralkat » Thu Jun 17, 2004 2:59 pm

still getting crash to desktop after issuing attack comands to bot, very sporadic happens after running for a few min lasted up to 15 min before sk crashedthe last time,, was issuing a pure attack command nothing else going to go peek at the code see if i find anything