First Post, First Macro: Re: tradeskill

Have a macro idea but not sure where to start? Ask here.

Moderator: MacroQuest Developers

colt45
orc pawn
orc pawn
Posts: 16
Joined: Thu Jun 10, 2004 5:29 am

First Post, First Macro: Re: tradeskill

Post by colt45 » Thu Jun 10, 2004 6:15 am

So i spent all of yesterday clicking the combine button and reloading items into the tradeskill

window, then i, when i regained feeling in my numb fingers and wrist, downloaded and complied

MQ2. and a few hours later, with no knowledge of scripting, I'm attempting to pump out my

first script. I know it's not in the nature of the forum to be generous to those who are new [and stupid/arrogant],

but im NOT looking for handouts, and I don't want anyone to write the scripts for me, but here

goes for the first one. Let me know what I', doing right or wrong here, trying to comment everything though, to make it easier for the readers.

(sitting with new tradeskillwindow open)

Code: Select all

|-----------|
|Tradeskils
|Test #1
|Jun/10/04
|5:45 AM
|-----------|
|
|
| Note: have Recepie selected 
|    In new tradeskill Window
|    and adjsut LOC's for your window
|    sorry, I can't do more advanced
|    Scripts yet, so bear with me
|
|
|----------
| Broke it down into 3 subsections
| Sub Docombine moves mouse and clicks the 'combine button'
| Sub delaytimer is just a 5 second delay right now
| looked to robodawgs herobrew script for help with some info,
| not trying to steal his script, wanted to give him credit where it's due
| Sub DoAutoinv stashes everythign back in inventory
|

Sub Main
   /call DoCombine
   /delay 5
   /call DelayTimer
   /delay 5
   /call DoAutoInv
/endmacro

Sub DoCombine
   /click left 560,480
/return

Sub DelayTimer
   /delay 45
/return

Sub DoAutoInv
   :WaitCursor
   /if (${Cursor.ID} ) /autoinv {  
      /goto :WaitCursor
   } else /return 

Chill
Contributing Member
Contributing Member
Posts: 435
Joined: Fri May 07, 2004 5:06 pm
Location: Erie, PA

Post by Chill » Thu Jun 10, 2004 8:08 am

There are already about a bizillion tradeskill macros, are you really sure you want to reinvent a new one?

My first question, is why are you tradeskilling? For items for for skillups?

There are macros already that will keep track of your skill and even stop you when somehting becomes trivial. I wrote one that will tell my my success and fail rates. There are some that will do sub combines and such. Check the Macro Depot and do some searches man.

If none of these meet your needs, then I would suggest changing your /click left 560,480 to /notify COMBW_CombineArea CombineButton leftmouseup as a start so it doesnt break if you move the box.

User avatar
Fuergrissa
a grimling bloodguard
a grimling bloodguard
Posts: 607
Joined: Mon Dec 08, 2003 3:46 pm
Location: UK

Post by Fuergrissa » Thu Jun 10, 2004 9:39 am

apart from the good working macros already out there including Mine what happens when it returns after you autoinv your cursor.

Code: Select all

Sub Main 
   /call DoCombine 
   /delay 5 
   /call DelayTimer 
   /delay 5 
   /call DoAutoInv 
/endmacro 
and why

Code: Select all

   /delay 5 
   /call DelayTimer 
   /delay 5 
call 3 delays to do one job ? why not just use /delay 60 if you feel a need to have a delay for that long ?
[quote]"Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the Universe trying to produce bigger and better idiots. So far, the Universe is winning."[/quote]

colt45
orc pawn
orc pawn
Posts: 16
Joined: Thu Jun 10, 2004 5:29 am

Post by colt45 » Thu Jun 10, 2004 2:22 pm

thanks for the feedback, and to answer the first question regarding why i was scripting:
to see if i can, I'm just learning the basics of scripting and i hope to be able to script as well as a lot of the people here someday

Oid
a snow griffon
a snow griffon
Posts: 416
Joined: Thu Oct 17, 2002 3:26 am
Contact:

Post by Oid » Thu Jun 10, 2004 3:29 pm

click loc... is a bad idea. always.

But oh so fun!
Smokey the Lax says only you can prevent reproduction.