Genbot Version 12 Ready

[LordGiddion]

SiatX most likely you miss spelled the name it's not Tnarg's Mending with a single quote it's Tnarg`s Mending with an acent mark.

[LordGiddion]

Ok Did another update in this thread, I know I said I'd start a new thread but it's a small update that finishes off all the stuff that was partially implimented.
Botcore now 12.31
Botspell now 12.31

[Nightshift]

Command: buff <spellname> on <target>

bot will cast spell, will recast spell, then erros and will continure to cast spell over and ovewr until macor is ended.

error:
/varset failed, variable '0' not found
botcore.inc@535 (Event_timer(string TimerName,string OldValue)):/if ($(Macro,Return)==0 /varset $(BuffListTimes[$counter}]}.Duration.TotalSeconds}
genbot.mac@57 (Main):/varset BreakOut 0


each tiime it recasts the spell the above error comes up, the only change is the variable '0' changes to '-5' then '-10' etc..

NightShift

[fez_ajer]

botspell.inc (535)

Code: Select all

/if (${Macro.Return}==0) /varset [color=red]${[/color]BuffListTimes[${counter},1][color=red]}[/color] ${Spell[${BuffList[${counter},2]}].Duration.TotalSeconds}
/if (${Macro.Return}==1) /varcalc BuffListTimes[${counter},2] ${BuffListTimes[${counter},2]}+1
/if (${BuffListTimes[${counter},2]}>5) {
   /varset [color=red]${[/color]BuffListTimes[${counter},1][color=red]}[/color] 900
   /varset [color=red]${[/color]BuffListTimes[${counter},2][color=red]}[/color] 0
}

remove the stuff in RED

[LordGiddion]

fez_ajer: thanks for the catch on that 1, I'll fix it in my copy.

[fez_ajer]

botspell.inc (77)

Code: Select all

/declare SelfBuffList string [color=red]outer[/color]

botspell.inc (123)

Code: Select all

/if (${SelfBuffPass}>40[color=red])[/color] {

botspell.inc (364)

Code: Select all

/[color=red]call[/color] SpellSub "${SelfBuff[${counter}]}"

[Rassilon]

Code: Select all

/if (${Macro.Return}==0) /varset ${BuffListTimes[${counter},1]} ${Spell[${BuffList[${counter},2]}].Duration.TotalSeconds} 
/if (${Macro.Return}==1) /varcalc BuffListTimes[${counter},2] ${BuffListTimes[${counter},2]}+1 
/if (${BuffListTimes[${counter},2]}>5) { 
   /varset ${BuffListTimes[${counter},1]} 900 
   /varset ${BuffListTimes[${counter},2]} 0 
} 

This is in botcore.inc.

Thanks

[Nightshift]

botspell.inc
@570

Code: Select all

/if (${TargetName.Equal[yourself]} || ${TargetName.Equal[${Me.CleanName}]}

Not sure, but isn't this missing a ) or maybe it needs the ( at the beginning removed or something else all together?

NightShift

[magictiger]

Missing a ). /if requres () around conditions now.

[LordGiddion]

Bug fixes just updated, enjoy.
botcore now 12.32
Botspell now 12.32

[Nightshift]

Think I found another..

botcore.inc
@545

Code: Select all

/if (${SelfBuffInt[${counter},1][color=red]}[/color]>1) /varcalc SelfBuffInt[${counter},1] ${SelfBuffInt[${counter},1]}-5

add the red code.

Missing } (right bracket)

NightShift

[Nightshift]

Doing buff spellname on target, it seems work now.

but

It spams with "Don't know the spell Buffs so failing to cast"

The only place I see this is in botspell.inc @168

It also casts the buff twice when it is time recast the spell, the continues to spam the above.

NightShift

[fez_ajer]

botspell.inc (571)

Code: Select all

/varset CommandPar[color=red]a[/color]m ${SpellNameParam}

Missing an 'a'

[LordGiddion]

Nightshift: is the target, me, yourself, botname, or someother target all together?

[Charisa]

When I start the script up (with and without night's change above) I get the message Don't know the spell NULL so failing to cast" this appears to be in reference with the lines in the .ini to keep certain buffs on yourself. I tried with one spell and with two and same thing both times.

I also seem to have a problem with the selfbuff or buff <x> on <yourself> stuff not monitoring the buffs fading off and recasting. I'm not sure on timed spells yet.

Lastly I found an error in shortcuts.inc

I don't have anything that gives me line numbers easily but I think its line 181

Code: Select all

/if (${Targeting}>15) [color=red] then [/color]/return

change to:

Code: Select all

/if (${Targeting}>15) /return

Last but not least, more of a feature request, but is there any way we can implement the functionality of /memspell <slot> <gem> remotely for this script? Sometimes using a spellset isn't really practical, and being able to change the spells I have memmed would be nice. It might also be good to add the ability to dump the list of memmed spells out to chat so you can verify what is loaded.

Thanks :)