/memspell Bug

ml2517 · Post by **ml2517** » Mon May 03, 2004 1:08 am

/memspell has problem with certain spells when memming. I havn't narrowed it down exactly to why it doesn't work but as an example.

Works Fine:
/memspell 7 "Endure Cold"

Doesn't work:
/memspell 7 "Heroic Bond"

It doesn't appear that the slot number is the problem, it must have to do with the spell lookup or something.

It pretty much cripples the auto-mem capabilities of spellcast.inc as is, if you could take a look at it Lax I'd appreciate it.

ml2517 · Post by **ml2517** » Mon May 03, 2004 1:49 am

Interesting,
Just did a little troubleshooting on it and did these things:

/echo ${Spell[Heroic Bond].ID}
Resulted in: 1536

/memspell 7 1536
/memspell 7 "Heroic Bond"
Results: Both of which failed, as I'd imagined.

But then I memmed it by hand in gem slot 1 and did:
/echo ${Me.Gem[1].ID}
Resulted in: 1538

/memspell 7 1538
Result: Works fine.

So hopefully it might just be some sort of counter gone wrong or something since it was only 2 off? Anyways, hope it helps pin it down.

Lax · Post by **Lax** » Mon May 03, 2004 2:00 am

the problem is solved for next zip, and heres what the problem was...

/memspell "Heroic Bond"
is trying to mem spell 1536, which you do not have. There are two different "Heroic Bond"s, 1536 and 1538.

I changed the /memspell code to only try to mem spells that are in your book

ml2517 · Post by **ml2517** » Mon May 03, 2004 7:23 am

lol two different ones? Well that might explain it. Thanks Lax!

Could you by chance do the same thing for other functions?

Its likely that someone wouldn't be trying to do a spell lookup unless they had the spell right? IE: ${Spell[Heroic Bond].ID}

Lax · Post by **Lax** » Mon May 03, 2004 9:02 am

Unfortunately its not always that easy

ml2517 · Post by **ml2517** » Mon May 03, 2004 4:00 pm

Yeah I figured it'd be different. What I was thinking was this:

Have it search through for the name, store the ID for the first hit you get, check to see if you actually have the spell that it finds in your spellbook.

If the spell is found in your book then return that result. If it isn't found then move on to the next. If it gets through every one of the spells that are named identically and you don't have any of them in your spellbook then just return the info from the first hit that you'd stored.

This should make it act like it always has for the most part but return better results.

The only real issue I can see with this is if you actually had 2 things with the same name in your spellbook it'd only return the first one but that is probably out of the norm.

And yes, I make it sound easy but it probably isn't. Hehe. Thanks Lax.

Lax · Post by **Lax** » Mon May 03, 2004 4:26 pm

For things that are specifically associated with your spellbook it would be perfectly fine. For things that arent, e.g. random spell lookups, it would be inefficient to assume you have the spell out of the few thousand. If you find other instances where this needs to be changed in relation to your spellbook let me know