New TS interface /notify

[SwiftyMUSE]

Credit goes to the original author, whomever that might be... I copied and modified to make work using /click and am attempting to update to /notify code. I can't get the /notify code to work. Any suggestions?

Code: Select all

| TS.mac 

| General purpose macro for automating tradeskills with the new TS interface. 
| Usage:  /macro TS [action on success] [action on failure] [end on trivial] 
| Specified actions can be 0 (to destroy) and 1 {to keep) created items. 
| If end on trivial is 1, the macro will end when the items trivial.  (Defaults to 0) 
| This macro will /autoinventory by default, if no switches are provided. 

| Example usage: 
| /macro ts 1 0 0 
| This would keep successful combines, destroy unsuccessful combines, and continue 
| running when the items trivial. 

| Be sure to have selected your recipe before running the macro! 

#event NOITEM  "Sorry, but you don't have everything you need for this recipe in your general inventory." 
#event SUCC    "You have fashioned the items together to create something new!" 
#event FAIL    "You lacked the skills to fashion the items together." 
#event TRIV    "You can no longer advance your skill from making this item." 

Sub Main 
   /declare SUCCACTION   global 
   /declare FAILACTION   global 
   /declare ENDONTRIV    global 
   /declare TRIVIAL      global
   /declare MOUSECOORD   array 
    
   /varset SUCCACTION 1 
   /varset FAILACTION 1 
   /varset ENDONTRIV 0 
   /varset TRIVIAL 0
   /varset MOUSECOORD(0) $mouse(x) 
   /varset MOUSECOORD(1) $mouse(y) 
   
   /newif ${Defined[Param0]} /varset SUCCACTION @Param0 
   /newif ${Defined[Param1]} /varset FAILACTION @Param1 
   /newif ${Defined[Param2]} /varset ENDONTRIV @Param2 

   |/echo @SUCCACTION @FAILACTION @ENDONTRIV
   |/endmacro

   :doloop 
      /notify TradeskillWnd CombineButton leftmouseup
      |/click left @MOUSECOORD(0) @MOUSECOORD(1) 
      /doevents
      /newif ${String[${MacroQuest.GameState}].NotEqual[INGAME]} /endmacro
      /newif @TRIVIAL /endmacro
   /goto :doloop
/return 

Sub Event_NOITEM 
   /endmacro 
/return 

Sub Event_FAIL 
   /call SortItems @FAILACTION 
/return 

Sub Event_SUCC 
   /call SortItems @SUCCACTION 
/return 

Sub Event_TRIV 
   /newif @ENDONTRIV { 
      /varset TRIVIAL 1
   } 
/return 

Sub SortItems 
   :itemloop 
   /newif ${Cursor} { 
      /newif @Param0 { 
         /autoinventory 
      } else { 
         /destroy 
      } 
      /delay 0
      /goto :itemloop 
   } 
/return 

[Lax]

/notify was changed so you should actually do leftmouse instead of leftmouseup

edit:
leftmouseup should be fine, i forgot how i changed it when i posted this

[SwiftyMUSE]

Ok, I found the problem with /notify and /itemnotify I was having. It seems that I did not have SP5 for Visual C++ 6.0. After installing that latest service pack, it is now working when I recompiled the code. I MADE NO CODE CHANGES.

[Preocts]

Go figure. The service pack was never installed on my system either. Read this post, pulled the CD out, installed/recompiled and whatta-ya-know. /notify and /itemnotify work like a damn charm.

rswiders, I could hug you.

::does the happy-I-can-make-my-macro-100times-more-useful-dance::

[frabtik]

After many hours testing and searching I am about to lose something but I am having most all the the issues scattered throughout the forums with the tradeskill macros for the new ts interface. I have been trying to make a ts macro work since the new tradeskill system came out and I am quite frustrated. Recently I am finally finding info that actually pertains to the issue and it seems the solution most people are finding to work is this Service Pack 6 for VS 6.0 which is what I use. I have downloaded and installed this file recompiled MQ with the newest version and nothing has changed, the new ts macros basically do nothing. Testing with at the command line gives similiar results, does nothing or pushes the button down and doesn't release, varies depending if I use leftmouse or leftmouseup. If I try to modify the ts macro I used before that appears to mostly work other than the fact that opening the container stops at the new window, then it sits and keeps clicking the experiment button etc. Is there anyway to verify the Service Pack was successfully installed? This would help me to determine if it is an issue in compiling in which I would have to find some other way to deal with that or if it is something I am gonna have to find another way to get the combiner open. Had no luck using delays to manually open them and really hate having to code in coordinates but may have to if all else fails. Using a delay got my combiner open but the macro doesn't seem to find the combine button after filling up once. Anyone still having these issues after installing the Service Pack? Thanks, any help very much appretiated.

[Lax]

If you use "leftmouse" the button does not get released. I'll probably just remove it because nobody will figure out the real use of it anyway.

"leftmouseup" is what you want, and it does work.

[frabtik]

Ok anyway reinstalled service pack and MQ and seems fixed this time. Still doesn't help the issue with clicking the combine button. Mouse still moves over about 3 inches and clicks done on one of my packs. There a notify to click this button too?

[Lax]

of course.

/notify pack1 Combine_Button leftmouseup

/notify works on any and all buttons, thats what its there for

[frabtik]

You are insane, if everquest had support like this everyone would play it. I feel so kinda silly not being able to fix this and currently have put in click locs and got it working finally but I am sure there is a better way, probly with notify even. But since I got your attention maybe I did not explain myself quite correctly. This is the line that doesn't work. I put in the line you listed in the above msg and I get a couple errors. I will list them if needed but I imagine you know what they are already.
/click left enviro combine

[Lax]

/notify enviro Combine_Button leftmouseup