thismachasnoname.mac - Ultimate Minotaur Hero Brew Script

Macro depository for macros written before the user variable changes that broke all of them.

Moderator: MacroQuest Developers

chaos
decaying skeleton
decaying skeleton
Posts: 1
Joined: Sun Sep 15, 2002 1:12 pm

thismachasnoname.mac - Ultimate Minotaur Hero Brew Script

Post by chaos » Sun Sep 15, 2002 1:23 pm

Hiyas all -

This is my first non-trivial script so please be kind. I'm sure much of it could be done better .

This script works in Halas and DOES IT ALL. It sells all mino brews (and bottles) , buys all needed components and then brews them all together (and repeats). It got me to 200 (my max) in no time but I'm sure it will get you to 248 in no time too.

There are some caveats when using this script:

1. Not sure if it works for shorter races - merchants are behind tables, you need to see them. Get levitate maybe.

2. Must be done in halas. The one room with 3 brewing merchants and the brew barrel. It works nowhere else.

3. Have as many open slots in your inventory as you can. 8 empty 10-slot containers is perfect.

4. It is smart about knowing when you're out of stuff and doesnt leave junk in the brew barrel - but right now it simply sells back excess yeast, malt, etc after a brewing session. You may lose a few siilver per brewing session than doing this by hand.

5. It is smart about filling your inventory with as many casks as possible except for two slots to hold your final products

6. At lower levels (150+) you will run out of ingredients like yeast before you run out of casks. You might need to tweak how much it buys of each to be optimal. It should work as written now regardless though. At high levels, you run out of casks and sell back a few yeasts each time.

7. Keep an eye on it.. i give this to the world with no guarantee. I hope it works for you but if it sells you 8 tinker bags - oh well. It worked perfect for me.

8. I had plenty of trouble with the delays and I know there are better ways to do some of those things. These delays worked for me, some better checking for merchants being active could be coded

ENJOY!
Chaos

[[ Apparently L124RD thinks code is spelled coed... /boggle l124rd ]]
[[ who likes code brackets? L124RD likes code brackets...]]

Code: Select all

#include routines.mac 
| Written by CHAOS
| Ultimate Mino Brew Brewing script for HALAS ONLY

Sub Main 
   | Open merchant
   :StartHere

  	/call GotoTarg "Hetie Mcdonald"
	/delay 5
 	/call SellItem "Minotaur Hero's Brew"
	/delay 15
	/call Sellitem "bottle"
	/delay 15
	/call Sellitem "yeast"
	/delay 15
	/call Sellitem "malt"
	/delay 15
	/call Sellitem "water flask"
	/delay 15
	/call Sellitem "short beer
   	
	/delay 7
	/target "Hetie Mcdonald"
	/click right target

	/delay 15

	| buy water
	/click left merchant 3
	/delay 4
	/call BuyStuff
	/call BuyStuff
	/call BuyStuff
	/call BuyStuff
	/call BuyStuff
	/call BuyStuff
	/delay 4
	/press esc
	/press esc
	/delay 11

	/call GotoTarg "Brandyn McDonald"
	/target "Brandyn McDonald"
	/click right target
	/delay 15
	
	| short beer
	/click left merchant 0
	/delay 3
	/call BuyStuff
	/call BuyStuff
	/call BuyStuff
	/call BuyStuff
	/call BuyStuff
	/call BuyStuff
	/delay 5
	/press esc	
	/press esc	

	/delay 11

	| yeast and malt
	/call GotoTarg "Becka McGuzzlin"
	/target "Becka McGuzzlin"
	/click right target
|	/press u
	/delay 7
	
	| yeast
	/click left merchant 4
	/delay 3
	/call BuyStuff
	/call BuyStuff
	/call BuyStuff

	| malt
	/delay 4
	/click left merchant 3
	/delay 5
	/call BuyStuff
	/call BuyStuff
	/call BuyStuff
	/call BuyStuff
	/call BuyStuff
	/call BuyStuff
	/call BuyStuff
	/call BuyStuff
	/call BuyStuff
	/delay 5

	| casks

	/delay 6
	/click left merchant 9
	/delay 3
	:NotherCask
	/click left merchant buy
	/delay 3
	/if n $freeinv(space)>2 /goto :NotherCask

	/press esc
	/press esc
	/delay 9

	/itemtarget Brew Barrel
	/face item
	/call GotoLoc 223,-145
	/face item
	 /click left item 

	/call MakeBrew
	/delay 5
	/press esc
	/delay 2
	/press esc
	/delay 2
	/press esc
	/delay 3
	/goto :StartHere


/return

Sub BuyStuff
	/delay 3
	/sendkey down shift
	/click left merchant buy
	/sendkey up shift
/return

Sub MakeBrew
	:MakeMore
	/sendkey down ctrl
	/delay 3
	/if n $count("Malt")<3 {
		/echo Ran outta Malt
		/goto :Done
	} 
	/if n $count("Water Flask")<2 {
		/echo Ran outta Water
		/goto :Done
	} 
	/if n $count("Short Beer")<2 {
		/echo Ran outta Short Beer
		/goto :Done
	} 
	/if n $count("Yeast")<1 {
		/echo Ran outta Yeast
		/goto :Done
	} 
	/if n $count("Cask")<1 {
		/echo Ran outta Casks
		/goto :Done
	} 

	/finditem "Malt"
	/if $find()==FALSE /goto :Done
	/click left enviro 0

	/finditem "Malt"
	/if $find()==FALSE /goto :Done
	/click left enviro 1

	/finditem "Malt"
	/if $find()==FALSE /goto :Done
	/click left enviro 2

	/finditem "Yeast"
	/if $find()==FALSE /goto :Done
	/click left enviro 3
	
	/finditem "Water Flask"
	/if $find()==FALSE /goto :Done
	/click left enviro 4

	/finditem "Water Flask"
	/if $find()==FALSE /goto :Done
	/click left enviro 5

	/finditem "Short Beer"
	/if $find()==FALSE /goto :Done
	/click left enviro 6

	/finditem "Short Beer"
	/if $find()==FALSE /goto :Done
	/click left enviro 7

	/finditem "Cask"
	/if $find()==FALSE /goto :Done
	/click left enviro 8

	/delay 1
	/sendkey up ctrl
	/click left enviro combine
	/delay 6

	/click left auto
	/delay 3
	/click left auto
	/delay 3
	/goto :MakeMore

	:Done
	/sendkey up ctrl

/return

karanadruid
orc pawn
orc pawn
Posts: 12
Joined: Wed Sep 18, 2002 11:09 pm

Post by karanadruid » Wed Sep 18, 2002 11:27 pm

I know this probably sounds like a noob question, and well it is, but would it be possible so it just does the combines? And doesnt run around to merchants? Mainly asking because I am DE and kos in Halas so I figure the next best thing would be thurg. Tried editing it out myself but it didn't seem to work(first time trying anything on macroquest) Thanks in advance. :)

Gengis
a ghoul
a ghoul
Posts: 116
Joined: Wed Aug 14, 2002 7:46 pm

Post by Gengis » Wed Sep 18, 2002 11:33 pm

karanadruid wrote:I know this probably sounds like a noob question, and well it is, but would it be possible so it just does the combines? And doesnt run around to merchants? Mainly asking because I am DE and kos in Halas so I figure the next best thing would be thurg. Tried editing it out myself but it didn't seem to work(first time trying anything on macroquest) Thanks in advance. :)
:arrow: Check your MQ folder for Hero.mac

karanadruid
orc pawn
orc pawn
Posts: 12
Joined: Wed Sep 18, 2002 11:09 pm

Post by karanadruid » Wed Sep 18, 2002 11:39 pm

My bad, can't believe I didn't look there, thanks!

karanadruid
orc pawn
orc pawn
Posts: 12
Joined: Wed Sep 18, 2002 11:09 pm

Post by karanadruid » Thu Sep 19, 2002 1:07 am

Have a problem with hero.mac... whenever I try to run it, it well.. doesn't work for me unlike most other macros, when it goes to place the items in the contain it is dropping two shortbeer, One on the left side two slots down and one of the right side, then it moves the right side all the way down clicks combine ( since it DNC I get nothing ) and then the macro ends.. I am running old ui, tried in both full screen and hub.. the only difference is the hub screen did the same thing but with water.. Any that could tell me what I am doing wrong?
Last edited by karanadruid on Thu Sep 19, 2002 6:39 pm, edited 1 time in total.

User avatar
eqsolro
a ghoul
a ghoul
Posts: 113
Joined: Fri Sep 13, 2002 4:20 pm
Location: Germany

Post by eqsolro » Thu Sep 19, 2002 1:56 am

Hmmm as i remember - cklick functions wont work correct with new UI - like most $get/$item etc.

My first test driven me to spin, then i read - i wont work correct with NewUI ;)
Maybe thats it ? Please correct me if not !

drastic ape
a lesser mummy
a lesser mummy
Posts: 30
Joined: Fri Aug 23, 2002 4:43 am

Post by drastic ape » Thu Sep 19, 2002 3:42 am

I kept having trouble running the hero.mac that comes with MQ, my problem was that I kept moving the brew barrel after I opened it. That is a big no-no, and I didn't get it at first even though I read about it. If you are moving the brew barrel then you will have very wild results and the macro will abort or worse. Whenever you open a combiner that isn't in your inventory you must leave it in the default position or else MQ won't know where the slots or buttons are. Use the old interface, not sure if full screen matters or not but that's all I use.

boldor
a ghoul
a ghoul
Posts: 94
Joined: Tue Sep 10, 2002 11:46 am

Post by boldor » Thu Sep 19, 2002 1:15 pm

One other thing to note about running the macros, is to make sure that your Backpacks, when opened do not cover the combind area when it is open.

Best bet is to open your combinder then, one by one open you back packs so that they do not over lay the combinder :>

This was done using old UI.

Me

Magnus
a ghoul
a ghoul
Posts: 85
Joined: Sun Aug 11, 2002 3:50 pm

Post by Magnus » Thu Sep 19, 2002 2:48 pm

Open up a vendor for reference and place your packs accordingly...


Mag

karanadruid
orc pawn
orc pawn
Posts: 12
Joined: Wed Sep 18, 2002 11:09 pm

Post by karanadruid » Thu Sep 19, 2002 6:40 pm

My bad I meant old UI but wrote new ui.. also I am not moving any of the windows... Do my packs with the ingredients have to be opened up?

drastic ape
a lesser mummy
a lesser mummy
Posts: 30
Joined: Fri Aug 23, 2002 4:43 am

Post by drastic ape » Fri Sep 20, 2002 5:35 am

You don't need anything open except for the brew barrel. I always close everything I don't need to see during the process since the macro should just magically pull the stuff out of your inventory.

karanadruid
orc pawn
orc pawn
Posts: 12
Joined: Wed Sep 18, 2002 11:09 pm

Post by karanadruid » Fri Sep 20, 2002 6:32 pm

Ahh my problem was I had the brew barrel window overlaping my inventory window, I think someone metioned something like this earlier? Anyhow it's working now, thanks for the help all!

boldor
a ghoul
a ghoul
Posts: 94
Joined: Tue Sep 10, 2002 11:46 am

Any Chance for GetShorty

Post by boldor » Fri Sep 20, 2002 6:42 pm

Any chance to get this working for Shorties? Only got about 50-60 x 48 skill increases left for 248. Assuming I can get 1 increase per 50-60 combinds.

thanks
ShortieCan'tSeeOverCounter

Consilium
Contributing Member
Contributing Member
Posts: 100
Joined: Wed Oct 02, 2002 10:42 pm

had troubles

Post by Consilium » Thu Oct 03, 2002 6:05 am

LOL...

used this macro
had troubles with the inventory placement...
Like a fool I moved it to the left corner...
macro sold my imbued granite spaulders for 32 plats :oops: ...
had to turn back on newUI to see the item in the merchants window...
had to bring pocketdrood from Nexus with 2kpp to get em back....
Moral of he story;

macro works... placement of your inventory window very important :roll:

I recomend putting valuables in the bank while running new macros :lol:
-SH
+Student
digitalsavior.com

LML
decaying skeleton
decaying skeleton
Posts: 4
Joined: Thu Oct 03, 2002 7:16 am

Post by LML » Thu Oct 03, 2002 8:01 am

Hi all. Have been reading this forum for a while to learn the basics of the code, so the best way i've found is to look at others work. I like to make the code simple, so here goes my question:


Isnt the lines

/if $find()==FALSE /goto :Done

redundant since you already made a check with

/if n $count("XXXX")<1 {
/echo Ran outta XXXX
/goto :Done
}

Personaly i prefer the second check just because the first one doesnt prevent from filling up the brew barrel with stuff you will have to pick up manually later. Am i right or there is something that im missing?



PS Please excuse my english, its not as good as i would like
[url]http://spacefem.com/uselessquiz/index.shtml[/url]

[img]http://spacefem.com/uselessquiz/9.gif[/img]