/itemnotify now broken after 3/123 patch

[rootmoth]

It was working great for me prior to 3/23 build, but now it has no effect whatsoever when I use any itemnotify command. There is one exception actually. If I try to use "in pack2 4" it will throw an error if pack2 isnt open, but doesnt work when pack 2 is open.

I've tested /itemnotify against equipment slots, inventory slots, bag slots, merchant slots.

/sellitem also isnt working now when it did yesterday.

[rootmoth]

Isn't anyone else having trouble with /itemnotify? I was so happy when I learned how to use it, then it stopped working on 3/23. It still isn't working after the 3/25 patch, which I hoped would resolve it.

It just does nothing when used, and /sellitem fails as well. No error message, no CTD, just non-functional.

I am using VS.NET for compile, and I run on XPHOME. If there is any other data I can present, I would be happy to do so.

[Falco72]

Yes, I have the same problems, but I was trying to do some debugging before bother Lax (not that I have much hope with my C++ knowledge, but I am trying ).

[Amadeus]

Has Lax mentioned that it is working as intended? I know that when the CSIDLWND (sp?) struct changed in size from 0x148 to 0x150 it could have changed some of the UI structs.

I havn't looked at this code at all for /itemnotify or whatever, so I don't know if it uses UI structs at all. However, if Lax doesn't mention otherwise, I'll look at it tonight sometime.

[Lax]

No, it was known to not be working. I committed a fix to dev cvs last night

[rootmoth]

Thanks Lax! Works fine now.

One question though about /sellitem.

When I execute /sellitem $selecteditem(count) it fails on anything that isn't stackable. It just doesn't sell it.

Is there a way I can account for that? $selecteditem can't return stackable or not, and $cursor doesn't seem to be active while using a merchant. In the meantime I am using something like pseudo

Code: Select all

/sendkey down shift
/click left merchant sell
/sendkey up shift

I would be fine with that, but I prefer using the non mouse-moving code.

How do I discover the window names that I can use /notify on? Is there a similar command I could use to replace /click left merchant sell? something like

Code: Select all

/notify Merchant Sell leftmouseup

[FlashG]

I am still can't get /itemnotify to work. I am using the following syntax "/itemnotify rightear rightmouseup" to to a right click on a item. If I mis-spell the item name or the notification I get a MQ2 errror, other wise it seems to do nothing. I have 29march version, with all plugins installed except chatwindow, telnet, and dps. I still can use "/click right" while the cursor is over the item and the items casts fine.

Flashg

[tazmeister]

I saw something similar to this. However I was able to use for example

/itemnotify 13 leftmouseup

in place of

/itemnotify primary leftmouseup

I was thinking that maybe I just hadn't found an up to date list of slots, however it may be that the you currently cannot access a slot via its name.

However none of the slot names seem to work with itemnotify. The number of the slot works though. I would love to see the mapping of number to slot, but there aren't that many so its not too hard to try a few and get it.

13 is primary btw

As for the pack open issue, I see the samething. If the pack is not open it says "No container at 'pack#' open

On that note I see the same issue with /finditem. If the pack is not open already it cannot find an item.


*** removed a hypothesis that on further reading was wrong ***

And on that reading the suggested work around was too open all packs first. Which makes wonder if there might not be a better way. Since opening all packs at once could be a nasty performance hit, if only for a few seconds.

[Lax]

First off, you're on crack... second off, you're on crack.

Here's the list of slots /itemnotify uses

Code: Select all

	"leftear",
	"head",
	"face",
	"rightear",
	"neck",
	"shoulder",
	"arm",
	"back",
	"leftwrist",
	"rightwrist",
	"range",
	"hand",
	"mainhand",
	"offhand",
	"leftfinger",
	"rightfinger",
	"chest",
	"leg",
	"feet",
	"waist",
	"ammo",
	"pack1",
	"pack2",
	"pack3",
	"pack4",
	"pack5",
	"pack6",
	"pack7",
	"pack8",
	"charm",

Numbers will always work because they are designed to.. primary isnt in the list it uses simply because ... it isnt. /itemnotify mainhand

Thirdly, /itemnotify uses the item's "window" to do its dirty work. If you do not have the container open, there is no window. If you have the container open, there is a window. When it says there's no pack open, it's implying that it needs the container open. I dont *want* to search the array because /itemnotify can only act on the fucking window.

That is all, and now im going to lock this thread because the issue on the thread is resolved and you're posting something different on it.