HerosBrew.mac - Automatic brewing script

Onezero · Post by **Onezero** » Sat Jan 24, 2004 7:37 pm

Update. v0.0.3 now available. Read first post for details.

Bad Karma · Post by **Bad Karma** » Sun Jan 25, 2004 6:53 am

Zeit wrote:having a problem with the script at the combine level it buys everything perfect puts it all in the brew barrel but wont combine it gonna look at it more see if i can figure it out

At first I thought this was due to the locations.txt file. Checked that, and my UI files, and everything that MQ likes is right where it should be....my work-around was simply to change:

Code: Select all

        /click left enviro combine

to:

Code: Select all

        /click left 950 280

.

Works like a charm. (Just be sure to swap for the actual coordnates of your COMBINE button.)

Onezero's suggestion of switching to Default UI works, also....but I really don't like the Default UI. hehe..

Only problem I saw with this was the brew barrel poofing at random. Time to search the old posts again to find where I read about that last month or so....lol

Onezero · Post by **Onezero** » Sun Jan 25, 2004 9:33 am

Yup Karma excellent solution. I hate Default UI too.. more than you'll ever know o_O. So I just load it for the time that I'm brewing, and then reload my custom one when I'm done, but make sure to load each and Use the INI File otherwise window positions, etc are lost.

Zeit · Post by **Zeit** » Mon Jan 26, 2004 5:57 am

Default UI did the trick working like a champ now, cept everytime i leave the keyboard someone sends me a tell /cry also im pretty new to macroing how can i make it destroy whats on the cursor instead of putting it in the inventory?

MrSmallie · Post by **MrSmallie** » Mon Jan 26, 2004 9:12 am

Zeit wrote:Default UI did the trick working like a champ now, cept everytime i leave the keyboard someone sends me a tell /cry also im pretty new to macroing how can i make it destroy whats on the cursor instead of putting it in the inventory?

Umm..have you read the macro at all? It tells you what to do (in English)in the beginning.

Elric · Post by **Elric** » Mon Jan 26, 2004 10:18 am

Uh. Yeah.

I use my own UI, and I can still click on the windows just fine.

Matter of fact, the macro runs rather smoothly, and without much difficulty I already modified it to work with triple the amount of ingredients, sell the bottles, and razz the merchants.

Ghecko · Post by **Ghecko** » Mon Jan 26, 2004 11:20 am

Elric,

Beat me to the punch. I was thinking of adding a few lines to sell right before the first buy calls from the Gnome.

Going one step further, I may try to do a check before the buy cask calls and only buy the difference between required and on hand. If anyone has done this please let me know so I don't try to re-invent the wheel.

Elric · Post by **Elric** » Mon Jan 26, 2004 11:45 am

Good idea on the casks... but I just let it buy them now, since I hardly fail anymore. Stupid brewing went up overnight.

But right now I'm on a brewing spree, so no mac work.

Zeit · Post by **Zeit** » Mon Jan 26, 2004 11:47 am

Umm..have you read the macro at all? It tells you what to do (in English)in the beginning.

I'm certainly not a genious when it comes to macroing in fact the closest thing ive come to programming was configuring a cisco router ><. The way i read the usage you define it when you run the macro at the command line. This is what i've tried:

/macro herosbrew <destroy>
/macro herosbrew <destroy, 1>
/macro herosbrew destroy 1
/macro herosbrew destroy, 1
/macro herosbrew destroy

none seem to work for me however i looked thru the macro and changed

/click left auto

to

/click left destroy

messy.. i know but it gets the job done also made it buy more (X8) now im spending alot less time running around

and more time combining (yea i have 8 empty bags equipt to do this) Great macro kudos to Onezero!

Spanky_Monkey · Post by **Spanky_Monkey** » Mon Jan 26, 2004 12:14 pm

Using the /autoinv or /destroy commands is much quicker and cleaner than using mouse clicks.

Ghecko · Post by **Ghecko** » Mon Jan 26, 2004 12:15 pm

Zeit,

/mac herosbrew 1 1 "Be right with you. I am in the middle of tradeskills." 1

I use the above as an example because it uses every one of the "stock" features.

The first 1 toggles the destroy

The second 1 toggles on the autoreply

The "text" is the reply message

The last 1 tells the macro I have items in inventory and I want to start right at the brew barrel.

If you are starting clean, stand near the gnome and don't use the last 1.

I hope this helps

Zeit · Post by **Zeit** » Mon Jan 26, 2004 12:35 pm

I'll give it a shot Ghecko when this batch is done combining thanks

Using the /autoinv or /destroy commands is much quicker and cleaner than using mouse clicks.

hehe! ill post the code to it then you will see what i did that made it so messy just redundant but i wasnt sure what exactly what i could take away and make it still work so..
Original Code

Code: Select all

    :ClearCursor 
        /if n @Destroy==1 { 
            /click left destroy 
        } else { 
            /click left auto 
        } 
        /delay 5 

        /if "$cursor()"!="TRUE" /goto :MakeBrew 

        /goto :ClearCursor

My Version

Code: Select all

    :ClearCursor 
        /if n @Destroy==1 { 
            /click left destroy 
        } else { 
            /click left destroy 
        } 
        /delay 5 

        /if "$cursor()"!="TRUE" /goto :MakeBrew 

        /goto :ClearCursor

Ghecko · Post by **Ghecko** » Mon Jan 26, 2004 2:23 pm

Zeit,

Definitely use /autoinventory and /destroy

Using /click you are emulating mouse clicks so the appropriate window will need to be open so the proper button may be pressed. Likewise if you use /click left destroy you will need to make sure you have fast destroy set inside of EQ, otherwise you will get a pop confirmation when you try to destroy the item.

Code: Select all

:ClearCursor 
         /destroy 
         /delay 5 
         /if "$cursor()"!="TRUE" /goto :MakeBrew 
         /goto :ClearCursor

Will cycle and destroy items on the cursor untill the cursor is clear, but will remove your ability to choose to save items unless you go back and re-edit your code.

Ghecko · Post by **Ghecko** » Mon Jan 26, 2004 5:11 pm

El,

Thinking of something along the lines of what follows. Let's say you are making a double batch so 2 stacks of casks for a total of 40.

Code: Select all

/declare CasksNeeded local
/declare CasksMax local
/varset CasksMax 40
/varcalc CasksNeeded @CasksMax-$count("cask")
/target merchant_name
/click right target
/delay 2s
/selectitem "cask" merchant
 /buyitem @CasksNeeded
/delay 1s
/press esc
/press esc

Just some initial thoughts.

Onezero · Post by **Onezero** » Mon Jan 26, 2004 8:01 pm

Version 0.0.4 posted. Read first post for details.

Also, I'm pretty busy in RL now and don't have much time to work on this mac atm, so if someone wants to write that sellback code or any other suggested improvments and post them, I will add them to the original mac.

HerosBrew.mac - Automatic brewing script

quick thought