I'd say go for it, once tested....I'd also like to see the "stay behind target" code from the BST mac implemented, as it is more natural looking to the observer.
...Lasher?
TEST: genbot.mac w/ 3D Follow
Moderator: MacroQuest Developers
Tested this today and ran into something that was quite annoying...
Had 2box character on follow, somehow he zoned and when I switched over to it the keyboard was not accessible (not able to type any characters).
He was backing up and I could not stop him.
1. I tried pressing shift/alt/ctrl keys to see if one was stuck, no effect. Still couldn't type.
2. I sent /msg <name> stop... no effect
3. I sent /msg <name> sit... no effect
4. I sent /msg <name> camp... no effect
5. I clicked SIT button, upon which he stood back up and started backing up again.
Basically I was unable to stop it. I had to go to Task Manager and end the process.
I don't have time right now to trace the macro, but I suspect it had to do with him following me and then suddenly zoning, while having coordinates still stored to follow? Just a WAG.
Had 2box character on follow, somehow he zoned and when I switched over to it the keyboard was not accessible (not able to type any characters).
He was backing up and I could not stop him.
1. I tried pressing shift/alt/ctrl keys to see if one was stuck, no effect. Still couldn't type.
2. I sent /msg <name> stop... no effect
3. I sent /msg <name> sit... no effect
4. I sent /msg <name> camp... no effect
5. I clicked SIT button, upon which he stood back up and started backing up again.
Basically I was unable to stop it. I had to go to Task Manager and end the process.
I don't have time right now to trace the macro, but I suspect it had to do with him following me and then suddenly zoning, while having coordinates still stored to follow? Just a WAG.
Follow seems to work beautifully for me.
However, my first real time using genbot. I have my personal.ini file setup on my shaman (who dou's with his master "warrior"). I am having a problem with the buff spell list. I have all 8 of the shaman buffs I want to use setup in his personal.ini However when I send a tell to the shaman "/t shaman buff me" He memorizes and cast only 2 buffs and I see repeated /memspell set error's . The 2 buffs he does cast or on my list and they cast successfully, but they also only mem in the 8th slot.
Can someone suggest what I should do? Again the 8 buffs for a single person are setup in the personal.inc correctly. I send a tell to shaman to buff me. He memorizes and casts only 2 of the buffs (using spell slot 8 only, so each buff is one at a time) and the remaining 6 buffs are not cast and i see several eq /memspellset errors.
However, my first real time using genbot. I have my personal.ini file setup on my shaman (who dou's with his master "warrior"). I am having a problem with the buff spell list. I have all 8 of the shaman buffs I want to use setup in his personal.ini However when I send a tell to the shaman "/t shaman buff me" He memorizes and cast only 2 buffs and I see repeated /memspell set error's . The 2 buffs he does cast or on my list and they cast successfully, but they also only mem in the 8th slot.
Can someone suggest what I should do? Again the 8 buffs for a single person are setup in the personal.inc correctly. I send a tell to shaman to buff me. He memorizes and casts only 2 of the buffs (using spell slot 8 only, so each buff is one at a time) and the remaining 6 buffs are not cast and i see several eq /memspellset errors.
Re-grab advpath.inc.
I beat the hell out of the dead horse that is the door code again. I'm going to try not to touch it any more. Its about as good as its going to get.
The door code will now ignore door names that don't have "door" in them. This should stop it from going into the door routine when you target a non-door (bookshelves, boxes, portals etc.).
The zoning routine was changed to do a similar ignore of non portals.
Let me know how it all works. I'm going to take a look now at the getbehind code that Bad Karma requested be replaced.
Wassup: I think I found the freeze up problem you were having as well. Let me know if its fixed. I believe it was the fact that ctrl was stuck down. I send another ctrl up when you zone now.
I beat the hell out of the dead horse that is the door code again. I'm going to try not to touch it any more. Its about as good as its going to get.
The door code will now ignore door names that don't have "door" in them. This should stop it from going into the door routine when you target a non-door (bookshelves, boxes, portals etc.).
The zoning routine was changed to do a similar ignore of non portals.
Let me know how it all works. I'm going to take a look now at the getbehind code that Bad Karma requested be replaced.
Wassup: I think I found the freeze up problem you were having as well. Let me know if its fixed. I believe it was the fact that ctrl was stuck down. I send another ctrl up when you zone now.
I need some testers to try out this new version of botcombat.inc. It has the getbehind code from cronic that Bad Karma suggested. I had to hack it up quite a bit to get it working. Let me know if you like it and I'll replace the stock botcombat.inc with it.
Last edited by ml2517 on Tue Jan 13, 2004 10:59 pm, edited 1 time in total.
OK, the new Follow code seems to work nicely. I like this better since the 2 box character doesn't need to be grouped to start the Follow. Seems to be able to follow very well.
The only trouble I found was going around a pit. The recorded points probably didn't have enough of a resolution to not try to cut across a pit.
Excellent job on that Follow code.
The only trouble I found was going around a pit. The recorded points probably didn't have enough of a resolution to not try to cut across a pit.
Excellent job on that Follow code.
Not following...
Without digging into the code too much, an off the cuff recommendation...
When I ran the script initially just now, and I zoned, it moved me forward and targetted a door, and left it targetted.
1. I wasn't following anyone, just running genbot. Perhaps this could be fixed so if you're not in follow mode, it does nothing?
2. Targetting on objects, is that bad to leave on or can that be cleaned up and un-targetted? (assuming you are in "follow mode")
I had a chance to check the attack code only a wee bit, I'll check it more later today. Looks nice!
Edit: To be more specific, it did strafe left right, it did look a lot more natural. Personally, I'd have it be even more forgiving about what is "behind" a mob, and just have it be acceptable to be about 45 degrees from straight behind a mob... again this is just from observation, it appeared to be accepting a lesser deviance.
When I ran the script initially just now, and I zoned, it moved me forward and targetted a door, and left it targetted.
1. I wasn't following anyone, just running genbot. Perhaps this could be fixed so if you're not in follow mode, it does nothing?
2. Targetting on objects, is that bad to leave on or can that be cleaned up and un-targetted? (assuming you are in "follow mode")
I had a chance to check the attack code only a wee bit, I'll check it more later today. Looks nice!
Edit: To be more specific, it did strafe left right, it did look a lot more natural. Personally, I'd have it be even more forgiving about what is "behind" a mob, and just have it be acceptable to be about 45 degrees from straight behind a mob... again this is just from observation, it appeared to be accepting a lesser deviance.
Re: Not following...
Good point. I hadn't noticed this as a problem but I just took a look at the code and it could indeed be targeting things when you aren't in follow mode. I'll fix it when I get home tonight should be very easy.vaelin wrote: When I ran the script initially just now, and I zoned, it moved me forward and targetted a door, and left it targetted.
1. I wasn't following anyone, just running genbot. Perhaps this could be fixed so if you're not in follow mode, it does nothing?
2. Targetting on objects, is that bad to leave on or can that be cleaned up and un-targetted? (assuming you are in "follow mode")
Hmm I actually set this to be about as forgiving as it can be honestly. I was testing it on non-attackable mobs in PoK that were standing against walls. I had it so that it would go just a shade behind from the side. The idea was to keep the bot from freaking out when it couldn't get behind a mob that was on a wall or something. I can see there might be an issue if a mob is in a corner. I'll take a look at it and see if I can relax the angles if it sees that you aren't able to move behind the mob.vaelin wrote: Edit: To be more specific, it did strafe left right, it did look a lot more natural. Personally, I'd have it be even more forgiving about what is "behind" a mob, and just have it be acceptable to be about 45 degrees from straight behind a mob... again this is just from observation, it appeared to be accepting a lesser deviance.
Other than that though did it work ok? I wasn't really able to test it much.
It did accept a nice variance, don't get me wrong. I'd like to hack a bit at the code and see if it could be improved slightly; I haven't looked at the positioning code for the botcombat things. Most of the more obvious oddities about positioning scripts have been a few things....
"exact-ness" ... script wants to be <12 but >8 distance away, and the end result is a lot of back-and-forth action, when in reality, most melee just get behind and stick there unless they are either too far away, or no longer behind. (barring the occasional max-range fight)
Positioning ... doing odd stuff when the back of the mob is unreachable.
Bear in mind I didn't have a problem so much with the /target stuff (beyond it being possibly detectable) ... it was the "I'm zoned, now I'll move forward a few paces" bit. Both are somewhat odd... but it's shaping up to be a really slick addon.
"exact-ness" ... script wants to be <12 but >8 distance away, and the end result is a lot of back-and-forth action, when in reality, most melee just get behind and stick there unless they are either too far away, or no longer behind. (barring the occasional max-range fight)
Positioning ... doing odd stuff when the back of the mob is unreachable.
Bear in mind I didn't have a problem so much with the /target stuff (beyond it being possibly detectable) ... it was the "I'm zoned, now I'll move forward a few paces" bit. Both are somewhat odd... but it's shaping up to be a really slick addon.