My macro, very very very simple...new at this...

[ubatch]

Please tell me what you guys think of it. Let me know how to improve it, i KNOW it'll need it. Just a little something to make my wiz casting easier on me :)

Code: Select all

| This is Malkum's casting program.  Simple, yet effective.
|
| Let's just hope it works...
|
|
/echo "Malkast macro starting.  Be prepaired for some ownage!"

#turbo 20

Sub Main
/declare mobHP global
/varset mobHP == $target(hp,pct)

/if mobHP == 50 {
	/call mobHP50
}
/if mobHP == 15 {
	/call mobHP15
}
/return

Sub mobHP50
/if $char(state) == STAND {
	/cast "Sunstrike"
	} else {
	/stand
	/cast "Sunstrike"
}
/sit
/return

Sub mobHP15
/if $char(state) == STAND {
	/cast "Draught of Ro"
	} else {
	/stand
	/cast "Draught of Ro"
}
/sit
/return

[TI994a]

Well, first off, the vast majority of the time you run this macro, nothing will happen. Why? Because your target's HP would have to be exactly 15% or 50% for it to do anything. And since there's no looping mechanism in place, once you did the /macro malkast, it would run thru just 1 time, and you'd only have a 2% chance of the macro finding your target in one of those states.

Additionally, while it's easier to read the /if statements by putting in the spaces, traditionally /if has required no spaces between the arguments on either side of the comparison operator.

If your goal is simply to cast Sunstrike when the mob is at 50%, why not just press an Alt+# key to cast Sunstrike. It would be much simpler than having to type out an entire commandline of /macro malkast.

- TI

[Scary_Penguin]

Code: Select all

/if mobHP == 50 { 
   /call mobHP50 
} 
/if mobHP == 15 { 
   /call mobHP15

You may want to change this to

Code: Select all

/if mobHP>=50 { 
   /call mobHP50 
} 
/if mobHP>=15 && mobHP<=49 { 
   /call mobHP15

I think thats the right way to code it...

[koad]

im going to run with the assumption you want this to automate your wiz's role in your boxed setting ~ if that's the case you need a loop running to monitor your conditions to act on them:

a few things-
/varset doesnt need ==, just /varset pointer value(bold)
your dealing with a mobs life its more reliable to do a number comparison with the n switch in the /if for < > comparisons(red)
keep in mind with this setup, its going to call mobHP15 as long as the mobs life is < 15 (you prolly will be finishing it off with this nuke? not sure)
to minimize spam and executions, i added a casting check to my edited example

when you want to use the value of a variable, you need to put a @ before the pointer name so it parses to the value

Code: Select all

| This is Malkum's casting program.  Simple, yet effective. 
| 
| Let's just hope it works... 
| 
| 
/echo "Malkast macro starting.  Be prepaired for some ownage!" 

#turbo 20 

Sub Main 
/declare mobHP global 

:mainloop
[b]/varset mobHP $target(hp,pct) [/b]

/if $char(casting)==FALSE {
   /if [color=red]@[/color]mobHP==50 { 
      /call mobHP50 
   } 
   /if n [color=red]@[/color]mobHP<=15 { 
      /call mobHP15 
   } 
}
/delay 1 
/goto :mainloop

/return 

Sub mobHP50 
/if $char(state)==STAND { 
   /cast "Sunstrike" 
   } else { 
   /stand 
   /cast "Sunstrike" 
} 
/sit 
/return 

Sub mobHP15 
/if $char(state)==STAND { 
   /cast "Draught of Ro" 
   } else { 
   /stand 
   /cast "Draught of Ro" 
} 
/sit 
/return 

[ubatch]

It says that my if statement isnt correct, can someone help me?

Code: Select all

| This is Malkum's casting program.  Simple, yet effective. 
| 
| Let's just hope it works... 
| 
| 
/echo "Malkast macro starting.  Be prepaired for some ownage!" 

#turbo 20 

Sub Main 
/declare mobHP global 

:mainloop 
/varset mobHP $target(hp,pct) 

/if $char(casting) = FALSE{
   /if @mobHP==50 { 
      /call mobHP50 
   }
   /if @mobHP<=15 { 
      /call mobHP15 
   } 
} 
/delay 1 
/goto :mainloop 

/return 

Sub mobHP50 
/if $char(state) = STAND{ 
   /cast "Shock of Magic" 
   }else{ 
   /stand 
   /cast "Shock of Magic" 
} 
/sit 
/return 

Sub mobHP15 
/if $char(state) = STAND{ 
   /cast "Draught of Thunder" 
   }else{ 
   /stand 
   /cast "Draught of Thunder!" 
} 
/sit 
/return 

[ml2517]

Try this:

Code: Select all

| This is Malkum's casting program.  Simple, yet effective. 
| 
| Let's just hope it works... 
| 
| 
/echo "Malkast macro starting.  Be prepaired for some ownage!" 

#turbo 20 

Sub Main 
/declare mobHP global 

:mainloop 
/varset mobHP $target(hp,pct) 

/if $char(casting)==FALSE { 
   /if n @mobHP==50 { 
      /call mobHP50 
   } 
   /if n @mobHP<=15 { 
      /call mobHP15 
   } 
} 
/delay 1 
/goto :mainloop 

/return 

Sub mobHP50 
/if $char(state)==STAND { 
   /cast "Shock of Magic" 
   } else { 
   /stand 
   /cast "Shock of Magic" 
} 
/sit 
/return 

Sub mobHP15 
/if $char(state)==STAND { 
   /cast "Draught of Thunder" 
   } else { 
   /stand 
   /cast "Draught of Thunder!" 
} 
/sit 
/return 

[ubatch]

Thanks, what does the /if n do?

Another thing now, I have some logic errors I guess, at the end of casting the mobHP15 my character sits and stands really fast, trying to nuke but has no target or whatever...any ideas on that one? Dang this programming stuff sucks =P

[ubatch]

Ok I think ive got everything figured out, just going into a bigger and bigger macro =P I will let you guys know when i need more help...this stuff just takes a lot of trial and error :)

[ml2517]

I'm assuming you want to do something like this:

Code: Select all

| This is Malkum's casting program.  Simple, yet effective. 
| 
| Let's just hope it works... 
| 
| 
/echo "Malkast macro starting.  Be prepaired for some ownage!" 

#turbo 20 

|  Set this to the number of seconds you want to wait before sitting after your target is dead.
#define SITWAITTIME 10s

Sub Main 
/declare mobHP global 

:mainloop 
/varset mobHP $target(hp,pct) 

/if $target()==TRUE {
    /if $char(casting)==FALSE { 
        /if n @mobHP<=50 /call Nuke 
    } 
}
/if $char(state)==STAND /if $target()==FALSE {
    /delay SITWAITTIME
    /sit on
}
/delay 1 
/goto :mainloop 
/return 

Sub Nuke
/if $char(state)!=STAND /stand

/if n @mobHP<=15 {
    /cast "Draught of Thunder" 
    } else { 
    /cast "Shock of Magic" 
} 
/return 

[notadruid]

Perhaps this should be moved to Macro Help

[blueninja]

"/if n" does a numeric comparison as opposed to a string comparison.