Camp a single mob

[Yo]

Hello
Im kinda new.. and tryed made one file with some ready stuff. Its a Single camp spot : Gornit , a Hill giant in oot. With a druid plvling, ( using druid macro on other comp) Consists in find the mob, atack and folow autoloot, and back to spot and sit, after kill and get the money.

But When I kill the MOB . the macro ends... Whats wrong? Please?=)

[Poiuyt]

I'd suggest editting your character name out of that macro, pronto.

[FlashG]

Nice macro, I dont understand in the :AutoLoot sub line 2, 3 and 4 are confusing. Line 2=target gornit corpse. Line 3=if %target() is TRUE do line 4. Line 4= Target S corpse? Who or what is S corpse? This may not be a problem.

In the for loop you exit the loop to :continue in the middle of the loop. it bad prctice to jump out of a loop like that. This probably is not your problem.

In the :autoloot line 17 you test the $cursor and if not NULL you destroy the item. In Line 18 you test the cursor again for NULL, well you just detroyed what was on your cursor so the Line 18 will always be true and you jump out of the for loop to :continue. IMHO this is a problem.

In the autoloot line 19 you have a label :skipdestroy, I dont see where that lable is used? Not a problem but strange.

In Sub Rest I see a problem. First it apears that you are resting only if you are ABOVE 85% . Second the /goto :dontmove should appear on the previous line. This is a syntax mistake and a logic mistake. This may be the real problem

These are only ideas. It is very hard to Debug somone elses program and do not consider this post then friendly critisism. Ya, take it those /tell Wxxx out of the post too

[Guest]

"/if n $v31==1 /call GoHome"

Where is $v31 being set so it executes the sub call?

[Xaanin]

Code: Select all

Sub LootSub
   :AutoLoot
   /press esc
   /target Gornit's Corpse
   /if "$target()"!="FALSE" /goto :TargetMyCorpse
   /goto :AutoLoot

   :TargetMyCorpse
   /face
   /if n $target(distance)<15 /goto :CloseEnough
   /call AutoRun 1
   /goto :TargetMyCorpse

   :CloseEnough
   /call AutoRun 0
   /loot
   /Delay 30
   /for v1 0 to 5
      /Delay 5
      /click left corpse $v1
      /if "$cursor()"!="NULL" /click left destroy
      /if "$cursor()"=="NULL" /goto :continue
      :SkipDestroy
      /click left auto
   /next v1
   :continue
   /press esc
/return

That autoloot sub should be working. You really should remove your characters names before you post the macro, a hint for the future. The reason why the macro stopped after killing Gornit is because it was calling LootSub, but the Sub's name was AutoLoot, I've renamed it above to LootSub.

[Everguide]

Is there a way you could make a general version of this macro? For example you say what class you are and what creature you want to kill and it kills it?

Would be hard but very usefull