BUG: /itemtarget CTD

FreQuency · Post by **FreQuency** » Wed Nov 05, 2003 3:14 am

/itemtarget works fine a long as it recieves an item
Ex: /itemtarget *Green
will target a groundspawn if there are spawns
if there are none with matching *green i get a CTD

dont_know_at_all · Post by **dont_know_at_all** » Wed Nov 05, 2003 4:13 am

Confirmed that this is a bug sometimes. Chasing it down...

The crash is somewhere in eqgame. EQADDR_TARGET was dereferenced and the ACTORINFO pointer is loaded. EQADDR_TARGET points to EnviroTarget and we just zeroed it out in ItemTarget(). Guess what happens when the ACTORINFO pointer is dereferenced?

CVSed. Too lazy to zip:

Code: Select all

diff -w -u -r1.51 -r1.52
--- EQLib_Commands.cpp  5 Nov 2003 01:06:39 -0000       1.51
+++ EQLib_Commands.cpp  5 Nov 2003 09:51:33 -0000       1.52
@@ -246,6 +246,8 @@
         WriteChatBuffer(szBuffer,USERCOLOR_DEFAULT);
                if (stricmp(Arg2,"notarget") && EQADDR_TARGET) *EQADDR_TARGET =
&EnviroTarget;
     } else {
+        if (EQADDR_TARGET && (*EQADDR_TARGET == &Enviroarget))
+            *EQADDR_TARGET = NULL;
         sprintf(szBuffer,"Couldn't find '%s'.",szLine);
         strcpy(gLastError,"ITEM_NOTFOUND");
         WriteChatBuffer(szBuffer,CONCOLOR_RED);

EqMule · Post by **EqMule** » Wed Nov 05, 2003 8:38 am

and to lazy to testcompile?

gives errors, but I fixed in cvs, and updated zip as well

&Enviroarget)) missed a "T"

But great job on finding the bug!

I was looking for that ctd myself, but couldnt figure out why.