Need a simple (and/or working) tradeskill macro that I can u

Help section from before the user variable changes that broke all macros

Moderator: MacroQuest Developers

Amadeus
The Maestro
The Maestro
Posts: 2036
Joined: Sat Jun 29, 2002 3:51 pm

Need a simple (and/or working) tradeskill macro that I can u

Post by Amadeus » Mon Sep 29, 2003 8:34 pm

Honestly, I've looked through all the tradeskill macros on the board and none of them work for me, and frankly, they all seem damn complicated.

Can someone post something here that I can use with containers in the inventory and environment containers (can be seperate macros) that are SIMPLE and that I can modify for each of my recipes that WORK with the current CVS? With an explanation too please?


Honestly..I'm golden with the C++ but I suck with the actual macro parsing language ..lol.

User avatar
Curious
a ghoul
a ghoul
Posts: 88
Joined: Wed Aug 27, 2003 5:19 am

Re: Need a simple (and/or working) tradeskill macro that I c

Post by Curious » Tue Sep 30, 2003 5:16 am

Amadeus wrote:... none of them work for me...
What doesn't work? Seems like sits.mac is very popular ... what problem does it have?
...that are SIMPLE...
How simple do you want? hard-coded so you just type /macro rawsilkhelm or with command line switches?

Amadeus
The Maestro
The Maestro
Posts: 2036
Joined: Sat Jun 29, 2002 3:51 pm

Post by Amadeus » Tue Sep 30, 2003 10:46 am

I tried two or three of the latest ones published in the macro depot ....most were the complicated versions that supposedly allow you to combine anything.

I was trying with a brew barrel and nothing seemed to work.

MQSEQ
Hypocrite fag
Posts: 181
Joined: Fri Sep 19, 2003 5:18 pm

Post by MQSEQ » Tue Sep 30, 2003 12:21 pm

Look into your Macro directory and there is a Kiola.mac. This is a very basic script that you can modify to combine anything (once you know the correct combiner and ingredents)

Amadeus
The Maestro
The Maestro
Posts: 2036
Joined: Sat Jun 29, 2002 3:51 pm

Post by Amadeus » Tue Sep 30, 2003 7:30 pm

Hmm...yea, I tried that without much success.... Do I have to use the original UI or can I use a custom UI? ...is that my problem? I did make sure that no windows were overlapping however....

renagade8
orc pawn
orc pawn
Posts: 28
Joined: Sat Oct 19, 2002 9:17 pm

Post by renagade8 » Tue Sep 30, 2003 9:11 pm

i have found that i need to use the default UI for combine macros

-ren

MQSEQ
Hypocrite fag
Posts: 181
Joined: Fri Sep 19, 2003 5:18 pm

Post by MQSEQ » Wed Oct 01, 2003 7:24 am

I use a customized UI for exverything but the Inventory and Bags. The bags do have the title bars turned on.

I use the Kiola and modified Kiola with no problems. i would suggest using some of the basic commands and type them in manually in the telnet session to see if they work.

Commands to test:

/sit on
/stand
/cast 1 {if your a caster}
/press i

Pick up some food and with the Inventory window opened type:
/click left auto

Make sure all your bags are open, not overlapping then close and reopen everything. This must be done with the Brewing Barrell, Pottery Wheel, Kiln, etc. as well

Is there any error outputs in the telnet session when it fails to work?

fryfrog
a hill giant
a hill giant
Posts: 271
Joined: Fri Jun 20, 2003 5:37 am

Post by fryfrog » Wed Oct 01, 2003 7:54 am

While the sits.mac is pretty complicated, it should basically be a copy/paste into a file and then just run it the right way. My guess is that you probably just tried to use it the wrong way.

Personally I'd much rather be able to type "/macro sits 0 "#bread" "#milk" than have to go out and manually edit my macro every time i want to combine milk and bread or cheese and honey or what ever.

MQSEQ
Hypocrite fag
Posts: 181
Joined: Fri Sep 19, 2003 5:18 pm

Post by MQSEQ » Wed Oct 01, 2003 8:09 am

type "/macro sits 0 "#bread" "#milk"
Shouldn't it be:

type "/macro sits 0 "oven" "#bread" "#milk"

It was missing the combiner.

Amadeus
The Maestro
The Maestro
Posts: 2036
Joined: Sat Jun 29, 2002 3:51 pm

Post by Amadeus » Wed Oct 01, 2003 2:12 pm

Can someone copy their working version of sits here? There are like a dozen types of tradeskill macros in the depot and improvements and additions ....way too complicated to sift through when you're trying to find something that WORKS.

insanitywiz
a hill giant
a hill giant
Posts: 250
Joined: Mon Jul 08, 2002 7:50 am

Post by insanitywiz » Wed Oct 01, 2003 8:56 pm

Not to be rude but...how easy do you want it for gods sakes? There are easy, simple combining macros that you can modify both in the depot and some of as part of the download for the program! Use one, play around with it, if you have problems THEN post it and ask for help. Don't just ask for a free ride from the start.

Amadeus
The Maestro
The Maestro
Posts: 2036
Joined: Sat Jun 29, 2002 3:51 pm

Post by Amadeus » Wed Oct 01, 2003 9:33 pm

(Yes, this is where I flamed the previous poster.... I've cooled down now and decided it wasn't worth my energy.)
Last edited by Amadeus on Thu Oct 02, 2003 12:40 am, edited 1 time in total.

wassup
Official Guardian and Writer of TFM
Official Guardian and Writer of TFM
Posts: 1487
Joined: Sat Oct 26, 2002 5:15 pm

Post by wassup » Wed Oct 01, 2003 11:48 pm

insanitywiz wrote:Not to be rude but...how easy do you want it for gods sakes? There are easy, simple combining macros that you can modify both in the depot and some of as part of the download for the program! Use one, play around with it, if you have problems THEN post it and ask for help. Don't just ask for a free ride from the start.
Next time I would think before replying to one of the devs in such a manner.

For all the work they do I wouldn't think giving them some help when they need it is too much to ask.

Open mouth, insert foot....


Now... Amadeus What is it you are trying to do with tradeskills? I think I could whip something up relatively fast.

Amadeus
The Maestro
The Maestro
Posts: 2036
Joined: Sat Jun 29, 2002 3:51 pm

Post by Amadeus » Thu Oct 02, 2003 12:38 am

Well, I think I probably have discovered the problem in that I need to be using the 'default' UI. Unless you have something that you think would work with any kind of custom UI, I would be interested in seeing that. I hate the thought of having to go back and forth between my UI and the default one for tradeskills ..however, if that is how it must be, I understand.

Basically, what I would most like would be a simple macro that would allow me to use both environmental and inventory combiners with the ingredients hard coded so I could just "Switch" them out and create hard coded macros for any of the recipes that I want to use.

Something like this, which I used to use all the time before the click was broken the first time:

Code: Select all

| - Pottery.mac - 
| 
| Please be near a open pottery wheel before you start this macro. 
| 
#include routines.mac 
#turbo 

Sub Main 

   /itemtarget Pottery Wheel 
   /face item 
   /click left item 
   /click left enviro combine 
   :MakeKiola 
      /sendkey down ctrl 

      /finditem "Medium Bowl Sketch" 
      /if $find()==FALSE /goto :Done 
      /click left enviro 0 

      /finditem "Water Flask" 
      /if $find()==FALSE /goto :Done 
      /click left enviro 1 

      /finditem "Block of Clay" 
      /if $find()==FALSE /goto :Done 
      /click left enviro 2 


      /sendkey up ctrl 
      /click left enviro combine 

      :WaitCombine 
         /delay 5 
      /if "$cursor()"=="FALSE" /goto :WaitCombine 

      /click left destroy 
   /goto :MakeKiola 

   :Done 
    /sendkey up ctrl 
    /click left enviro done 
/return 
Or this:

Code: Select all

| - Kiola.mac -
|
| Please be near a brew barrel open before you start this macro.
|
#turbo
#event CombineFail "You lacked the skills to fashion the items together."
#event CombineSuceed "You have fashioned the items together to create something new!"

Sub Main

   /itemtarget Brew Barrel
   /face item
   /click left item
   /delay 25
   /sendkey down ctrl

   :MakeKiola

      /finditem "Water Flask"
      /if $find()==FALSE /goto :Done
      /click left enviro 0

      /finditem "Bottle"
      /if $find()==FALSE /goto :Done
      /click left enviro 1

      /finditem "Packet of Kiola Sap"
      /if $find()==FALSE /goto :Done
      /click left enviro 2

      /finditem "Packet of Kiola Sap"
      /if $find()==FALSE /goto :Done
      /click left enviro 3

      :DoCombine
      /varset v61 0 
      /doevents flush
      /varset t9 30s
      /click left enviro combine 
      :DropKiola
         /doevents
         /if n $t9==0 /goto :DoCombine
      /if n $v61==0 /goto :DropKiola
      /doevents flush
      /varset t9 0
      :WaitCursor
         /delay 0
      /if $cursor()!=TRUE /goto :WaitCursor
      /click left auto
   /goto :MakeKiola

   :Done
    /sendkey up ctrl
    /click left enviro done
/return

Sub Event_CombineFail 
   /varset v61 1
/return 

Sub Event_CombineSuceed 
   /varset v61 1
/return 
However, if my problem is just because I'm using a custom UI, I can understand that and I'll just have to accept that :)

wassup
Official Guardian and Writer of TFM
Official Guardian and Writer of TFM
Posts: 1487
Joined: Sat Oct 26, 2002 5:15 pm

Post by wassup » Thu Oct 02, 2003 1:41 am

I use a custom UI, which clicks my auto-equip without a problem, it's the containers that have to be the default UI xml file.

Just copy the default EQUI_Container.xml file to the custom UI folder, or a copy of the custom UI in another folder.

As far as the macro's you posted go, in the Pottery.mac

Code: Select all

      :WaitCombine 
      /delay 5 
      /if "$cursor()"=="FALSE" /goto :WaitCombine 
will cause a problem if you fail the combine. It will get stuck in an infinite loop.

Another thing I tend to do is just have all of the containers open before I start a macro. Opening an environmental container is alot easier to do manually than having to rely on the macro.


I modified the Pottery.mac macro to assume the Pottery Wheel is already open and to use an Event to detect a combine failure:

Code: Select all

| - Pottery.mac - 
| 
 
#turbo

#event CombineFail "You lacked the skills to fashion the items together."

Sub Main 

   :MakeItem
      /sendkey down ctrl 

      /finditem "Medium Bowl Sketch"
      /delay 2 
      /if $find()==FALSE /goto :Done 
      /click left enviro 0 

      /finditem "Water Flask" 
      /delay 2
      /if $find()==FALSE /goto :Done 
      /click left enviro 1 

      /finditem "Block of Clay"
      /delay 2
      /if $find()==FALSE /goto :Done 
      /click left enviro 2
      /delay 2


      /sendkey up ctrl 
      /click left enviro combine
      /delay 2
      /doevents

      :WaitCombine 
      /delay 5 
      /if "$cursor()"=="FALSE" /goto :WaitCombine 

      /click left destroy 
      /goto :MakeItem 

      :Done 
      /sendkey up ctrl 
      /click left enviro done 
/return 

Sub Event_CombineFail
   /sendkey up ctrl
   /doevents flush
   /goto :MakeItem
/return 
You might have to modify some delay values also depending on lag, computer speed etc...[/code]

Also, you can take a look at this macro I made and edit it for a particular recipe. Note that this macro uses a tool, so there is no need for a fail event since there will always be something on the cursor regardless of a fail or success:

http://macroquest2.com/phpBB2/viewtopic.php?t=2432