ts.mac - All Purpose Tradeskill Macro

[fryfrog]

Okay, last bump. I did some cosmetic work on the script. Instead of it saying you made 10.00 items it should only say you made 10 items. I also added one or two statistics to some of the output that I wanted to see (namely, it should say something like "2 skill ups out of 10 attemps!" each time you get a skill up. Well, it won't say exactly that it should be customized to what is happening currently... you know what i mean :)

[Clone39]

This looks like a very good macro only thing is i cant get it to work

i am using the default UI with no mod at all

here's what i do:

/macro ts keep spit "fresh fish" "jug of sauces" (to create fish filets)

as soon as i press enter the mouse starts moving around, seems like its clicking on items and clicking combine.. but thing is my inventory and my packs are not opened.

I can see in the code that there is a sub to check if spit and packs are open but it doesnt seem to work.

When i open the inventory and packs and spit myself, the macro is trying to get the items out of thin air.. it doesnt click on them but somewhere else in the screen (where there is nothing)

what am i doing wrong?!


as i said i use the default UI, i did make the cahnges in Mq.h.

I even pasted the macro in a different text editor just to make sure, but when i started the macro it gives me the error "Subroutine Main not found". I checked if i missed something while copy/paste and the sub main is there.

someone knows what i am doing wrong here ?!

thanks

Clone39

[fryfrog]

did you use my version or the one at the top? what kind of spit are you trying to use? try putting all the variables in "" as well. i use a collapsible spit, you have to specify the entire name "collapsible spit"

[Clone39]

yes i used your version.. the one at the bottom.

i am using a regular spit.. one that i bought on a merchant in freeport and is named "spit"

i did put try to put all the vars in " " still it does nothing but point in the air..

[fryfrog]

Did you open up your inventory and all your bags, arrange them so that NONE of them over lap and then open/close them all?

You will need to do that :)

[Clone39]

humm.. will try that.. didnt think of it..

ill get back to you on that one!!

thanks!!

[Consilium]

Great macro... I am implementing the clear cursor on combine fail part... if I get it working in my new macro I will post my tradeskill macro.

[fryfrog]

check out the sits, which is a "slightly improved ts". it has what you are talking about already included, as well as a host of other features.

[gonecrazy]

You can fix the destroy option in this macro by editing line 120 in the "ClearCursor" rotine.

It curently reads:

Code: Select all

/varset l1 "$a(1,$l0)" 

Change it to read:

Code: Select all

/if "$a(1,$l0)"!="" /varset l1 "$a(1,$l0)" 

This problem occurs as it loops through all of the itmes to make sure it dosn't destroy one of the components (good feature ) as it gets to the last "empty" compontest it chokes on the varset of a blank varible. This error on blank varible set seems to just have come about in the latest versions of macroquest. So checking before you set it, solves the problem.

[kagonis]

Awesome, thanks gonecrazy..
I'm a bit tired atm, so haven't gone through the code extensively, but according to my logic you shouldn't be getting any empty array variables there, due to the following code:

Code: Select all

	:CountComponents
		/varset a(1,$TotalComp) "$p$int($calc($TotalComp+2))"
		/varadd TotalComp 1
		/if n $int($TotalComp)>10 {
			/echo Syntax: /macro ts <0-X> <CombinerName> <Component> [Component]...
			/echo You can only add up to a total of 10 components.
			/endmacro
		}
		/echo Component $int($TotalComp): $p$int($calc($TotalComp+1))
		/if "$p$int($calc($TotalComp+2))"~~"$" {
			/goto :Begin
		} else /if "$p$int($calc($TotalComp+2))"=="" {
			/goto :Begin
		} else {
			/goto :CountComponents
		}

As you can see I'm allready doing the check for an empty string here, so it shouldn't be necessary to do the same check in a subroutine as well.
Anyway, haven't tested it, only skimmed the code, but my logic tells me that check shouldn't be needed, but my logic tend to be flawed when I'm tired ;)

[morphey]

Awsome macro!!! Thanks so much all that helped making this!

I am however having problems using enviromental combiners (other work like a charm), it either says "Item Forge targeted. Couldnt parse v2 8. Cannot find container << Forge >>" or crash eqw/eq when I try.

I have all windows opened up and saved etc.

Startline I try to use is "/macro ts "default" "Forge" "item" "item"

Same result in both EQw (with or without mouse free) and regular EQ in default UI.

Any idea what I do wrong?

[Hendrix2004]

Yeah, when i try to do the pottery wheel i get container not found

[morphey]

Got it working with enviromental containers after browsing board some more from earlier ts macros...

/macro ts "default" "eviro" "item1" "item2" etc

Havent been able to get the deletion of final product to work yet... get error and macro halt when I try

Anyhow AWSOME work!

[Hendrix2004]

this sits macro (slightly improved ts macro) works great. I havnt had any problems with it. The only thing i don't like about it is you have to set keep or destroy in the macro

[fryfrog]

I'm sure you are using kagonis's real version now right? It supports all of the stuff you wish for w/o any problems all from the command line :)