TS macro, issue with enviro container

Need help with a macro you are writing? Ask here!

Moderator: MacroQuest Developers

Bubbajoe
decaying skeleton
decaying skeleton
Posts: 1
Joined: Sun Mar 05, 2017 5:30 pm

TS macro, issue with enviro container

Post by Bubbajoe » Thu Mar 14, 2019 8:01 pm

Hello all! Newer to coding here!

Background:
I am currently writing a macro to manage one particular tradeskill recipe which has 2 sub-combines in an environmental container.

Issue:
I cannot seem to get my macro to hit the combine button in the experimental container of a pottery wheel. The most bizarre part, If i close the container, re-open it by hand, and then manually type the code (line by line) into the in game MQ2 chat window, it will combine just fine.

Attempted fixes:
I have poured over the wiki, forums, and discord and hours of adjusting and testing to try and wrap my brain around this with not much luck. There have been three different versions of the combine line I have tried using:
1)

Code: Select all

/combine ContainerWindow 
2)

Code: Select all

 /notify ContainerWindow container_combine leftmouseup 
3)

Code: Select all

 /notify ContainerCombine_Items Container_Combine leftmouseup 
Number 1 produces the popup by EQ saying I cannot hit combine when items are stacked in the container (which they are not stacked), while 2 & 3 just get ignored. I am wondering if it is the way I am opening the container possibly? Below are two of the subs... the end of the NavToWheel sub is where I open the container, and then it jumps into MakeJar. Any thoughts? Thanks in advance for any tips/pointers/enlightenment!


Code: Select all

	
Sub NavToWheel
	/echo DEBUG: Starting NavToWheel
	/itemtarget pottery
	/nav item
		/echo DEBUG: Moving to Pottery Wheel
		:running
			/delay 5
		/while (${Navigation.Active}) {		
			/goto :running
		}
	/echo DEBUG: I made it to the Pottery Wheel!
	/call OpenPacks
	/click left item
		/delay 1s
	/notify TradeSkillWnd COMBW_ExperimentButton LeftMouseUp
		/delay 1s
/return

Sub MakeJar

	/echo Debug: Attempting to making ${extract} Unfired Jars
	
	:unfiredloop
	/if (${Cursor.ID}) {
		/autoinv
			/delay 2
		/goto :unfiredloop
	}
		:returnloop
		
		/ctrl /itemnotify "Water Flask" leftmouseup
			/delay 10
			/itemnotify enviro1 leftmouseup
				/delay 10
		/ctrl /itemnotify "Medium Jar Sketch" leftmouseup
			/delay 10
			/itemnotify enviro2 leftmouseup
				/delay 10
		/ctrl /itemnotify "Block of Clay" leftmouseup
			/delay 10
			/itemnotify enviro3 leftmouseup
				/delay 2s
				
		/combine ContainerWindow

		
Last edited by Bubbajoe on Fri Mar 15, 2019 2:45 am, edited 1 time in total.

dewey2461
Contributing Member
Contributing Member
Posts: 1759
Joined: Sun Apr 17, 2005 1:53 am

Re: TS macro, issue with enviro container

Post by dewey2461 » Fri Mar 15, 2019 2:03 am

This is the code I've found works about 80% of the time.

Code: Select all

|-- We have the mats - lets get started
	/keypress ESC
	/if (${Cursor.ID}) /autoinv
	/if (${Cursor.ID}) /autoinv
	
	/varset S ${Ini[TS.INI,Make,In]}
	/echo Attempting to open container = ${S}
	
	/if (${S.Equal[Tackle Box]}) /varset S Fishing Table
	/if (${S.Equal[Fly Making Bench]}) /varset S Fishing Table
	/if (${S.Equal[Toolbox]}) /varset S Tinkering Table
	
	/itemtarget ${S}
	
	|-- Run to it
	/nav item
	/delay 2
	/delay 120s !${Navigation.Active}
	/face item nolook
	/click left center
	|-- TO DO : If we know the reciepe we should use TS window combine stuff but for now ...
	
	/delay 2s ${Window[TradeskillWnd].Open}
	/if (!${Window[TradeskillWnd].Open}) {
		/echo Couldn't open container
		/return
	}
	
    /invoke ${Window[TradeSkillWnd].Child[COMBW_ExperimentButton].LeftMouseUp}
    /delay 2s ${Window[ContainerWindow]}
	/delay 2
    
	/if (${Window[ContainerWindow]}) {
		:MakeNextOne
		/echo Starting Next One - Load up Envro
		/call ClearEnviro
		....

FrankJScott
naggy
naggy
Posts: 2385
Joined: Sun Feb 19, 2023 7:11 am

Recommended Suggestions For Deciding On Car Buying

Post by FrankJScott » Thu Mar 02, 2023 11:44 am

In reply to the guy inquiring about sell my car comparison, land cruiser 1990 for sale, i want to sell my car today, buy sale and trade cars, cars for sale private owner only, best sites to sell your car, I highly suggest this basics on car buying link or best private car selling websites, pay to junk my car, 2019 car for sale, honda accord 2007 for sale, online sites to buy used cars, old people selling cars, and don't forget this the full details for car buying advice alongside all mini cars for sale near me, trying to sale my car, scrap car for sale, sell my car without v5, best site for private seller cars, price my car to sell, not to mention this continue reading this for car buying link which is as good as get money for your old car, good second hand cars for sale, sell my car to junkyard near me, sell your car for cash near me, second hand small cars for sale near me, sell my junk car top dollar, . Also, have a look at this cool training for car buying site and don't forget we buy cars trade in, best place to sale your car, second hand small cars for sale near me, i want to sell my car to a dealership, car sale value estimate, i want to sell my car today for cash, on top of this here about car selling blog alongside all damaged car buyers near me, auto trader sell my van, peddle sell your car, junk your car for cash, places that junk cars for cash, cars cars for sale, and don't forget super fast reply on car selling info which is also worth a look on top of we buy old cars for cash, car sale value estimate, sell your salvage car, ford f150 for sale used, best way to sell my used car, sale my truck online, also. I also suggest this killer deal on car selling site and don't forget sell unwanted car for cash, sell my car on ebay, sell my broken car near me, junk your car quote, evans halshaw car valuation, best place to find cars for sale, and don't forget this find for car selling blog and don't forget old junk car for sale, 6000 cars for sale, sell damaged car, gumtree cars private sale, sell my car quick quote, myjunkcar, not to mention your input here on car selling info and don't forget the best junk car buyer, economical cars for sale, cash for my junk car removal, best way to sell a used car, cash for scrap cars near me, cargurus private seller, which is also great. Finally, have a look at this this hyperlink for car buying info with best website to sell car for free, buy junk cars for cash near me, junk yards that sell cars, sell used car, best private car selling websites, sell my car free pick up, for good measure. Check more @ Sources Tell Me For Top Mastiff Dog Advice 9a89a61

FrankJScott
naggy
naggy
Posts: 2385
Joined: Sun Feb 19, 2023 7:11 am

High Rated Product Website

Post by FrankJScott » Fri Aug 18, 2023 8:21 pm

Why don't you Google it! before you post