MQ2Utilities spell updates

Need help running MacroQuest2? Ask your questions about how to get things to work on your computer.

Moderator: MacroQuest Developers

PeteSampras
a snow griffon
a snow griffon
Posts: 322
Joined: Sat Dec 15, 2007 8:56 pm

MQ2Utilities spell updates

Post by PeteSampras » Tue Jan 02, 2018 12:35 pm

Eqmule: as fyi the following cases have been added in game that need updated in MQ2Utilities.cpp PCHAR ParseSpellEffects function:

Source: https://github.com/rumstil/eqspellparse ... ellData.cs

Code: Select all

                case 498:
                    // silimar to 266?
                    // base2 may be the the number of attacks?
                    return Spell.FormatPercent("Chance of Additional Primary 1H Attack", base1) + String.Format(" ({0})", base2);
                case 499:
                    return Spell.FormatPercent("Chance of Additional Secondary 1H Attack", base1) + String.Format(" ({0})", base2);
                case 500:
                    return Spell.FormatPercent("Spell Haste v2", base1);
                case 501:
                    // applied after 127/500 spell haste focus?
                    return String.Format("Decrease Casting Times by {0:0.##}s", base1 / 1000f);
                case 502:
                    // what is base2 used for?
                    return String.Format("Stun and Fear for {0}s", base1 / 1000f) + varmax;
                case 503:
                    // similar to 185 but with rear arc? stacking?
                    // base2 might be arc type. e.g. 0 = back
                    return Spell.FormatPercent("Rear Arc Melee Damage", base1 / 10f);
                case 504:
                    return Spell.FormatCount("Rear Arc Melee Damage", base1);
                case 505:
                    return Spell.FormatPercent("Rear Arc Melee Damage Taken", base1 / 10f);
                case 506:
                    return Spell.FormatCount("Rear Arc Melee Damage Taken", base1);
                case 507:
                    // Effectively Fc_Damage_%2. I know 461 is supposedly "Fc_Damage_%2," but for whatever reason it works nothing like SPA 124. 
                    // SPA 507 appears to work just like 124, except it appears to be applied after 461. - Sancus
                    return Spell.FormatPercentRange("Spell Damage v4", base1, base2) + " (Before DoT Crit, After Nuke Crit)";
                case 509:
                    // for wording comparison, the closest description to this is 401, 402
                    return String.Format("{0} Current HP by {1}% of Caster Current HP ({2}% Life Burn)", base2 < 0 ? "Decrease" : "Increase", Math.Abs(base2) / 10f, base1 / 10f);
                    //return String.Format("Decrease Caster Current HP by {0}%  And Return {1}% to Target", base1 / 10f, base2 / 10f);
                case 510:
return Spell.FormatCount("Incoming Resist Modifier", base1);

PeteSampras
a snow griffon
a snow griffon
Posts: 322
Joined: Sat Dec 15, 2007 8:56 pm

Re: MQ2Utilities spell updates

Post by PeteSampras » Tue Jan 02, 2018 12:38 pm

Also, the following code probably needs updated for .Stacks and SpellStacking function to work correctly:

Code: Select all

BOOL TriggeringEffectSpell(PSPELL aSpell, int i)
{
    LONG aAttrib = GetSpellNumEffects(aSpell) > i ? GetSpellAttrib(aSpell, i) : 254;
    return (aAttrib == 85    // Add Proc
        || aAttrib == 374     // Trigger Spell
        || aAttrib == 419);    // Contact_Ability_2
}
Should be:

Code: Select all

BOOL TriggeringEffectSpell(PSPELL aSpell, int i)
{
    LONG aAttrib = GetSpellNumEffects(aSpell) > i ? GetSpellAttrib(aSpell, i) : 254;
    return (aAttrib == 85    // Add Proc
        || aAttrib == 340 // cast best spell
        || aAttrib == 374     // Trigger Spell
        || aAttrib == 419    // Contact_Ability_2
        || aAttrib == 469  // trigger group spell
        || aAttrib == 470); // trigger highest rank spell
}

SwiftyMUSE
Developer
Developer
Posts: 1205
Joined: Tue Sep 23, 2003 10:52 pm

Re: MQ2Utilities spell updates

Post by SwiftyMUSE » Tue Jan 02, 2018 1:28 pm

I'll take a look at this.
PayPal: Donate to SwiftyMUSE
Bitcoin: 1LuQ6YcEAWxF3fm9yWMiro4K582je7364V
Krono: PM me

dont_know_at_all wrote:Gee, if only there was a way to correctly report a crash...

EqMule
Developer
Developer
Posts: 2697
Joined: Fri Jan 03, 2003 9:57 pm
Contact:

Re: MQ2Utilities spell updates

Post by EqMule » Tue Jan 02, 2018 2:20 pm

Ty
My status o/
If you like MQ2 and would like to contribute, please do. My goal is 25 donations per month.
So far I've received Image donations for this month's patches.

Bitcoin: 1Aq8ackjQ4f7AUvbUL7BE6oPfT8PmNP4Zq
Krono: PM me.
I can always use characters for testing, PM me if you can donate one.

FrankJScott
naggy
naggy
Posts: 2326
Joined: Sun Feb 19, 2023 7:11 am

Excellent Product Guide

Post by FrankJScott » Sat Aug 19, 2023 12:41 am

Why don't you Google it! before you post

FrankJScott
naggy
naggy
Posts: 2326
Joined: Sun Feb 19, 2023 7:11 am

New Situs Slot Gacor Website

Post by FrankJScott » Sat Aug 19, 2023 10:01 am

Menanggapi pria berbicara tentang daftar game judi, slot gacor terpercaya, daftar situs slot gacor terbaik, situs judi slot terbaik dan terpercaya no 1 di indonesia, situs pulsa gacor, login slot terpercaya, togel pragmatic, slot online terpercaya gampang menang, situs bola dan togel terpercaya, slot pragmatic resmi, situs gacor terpercaya, link slot online terpercaya, daftar judi slot resmi, daftar togel terpercaya di indonesia, situs judi slot terpercaya no 1, situs slot terbaik dan terpercaya, slot dana online, situs slot no 1, bonus togel online, slot online terbaru 2023, Saya menyarankan ini slot gacor tips for agen resmi togel online, jarwo slot gacor, rtp ratu, situs slot yang banyak diminati, game togel dan slot, situs slot gacor togel, situs judi slot terlaris, link yang gacor hari ini, slot gacor gampang, gacor indonesia, agen togel dan slot terpercaya, situs slot gacor terbaik, nama nama situs slot online, judi slot gacor gampang menang, daftar agen terpercaya, situs judi online indonesia, agen togel slot terpercaya, game slot yang paling gacor, situs togel terpercaya deposit dana, situs togel no 1 di indonesia, also. See More Excellent Situs Slot Site a1b86b3

FrankJScott
naggy
naggy
Posts: 2326
Joined: Sun Feb 19, 2023 7:11 am

Top Rated Business Trip Massage Website

Post by FrankJScott » Thu Aug 24, 2023 8:24 am

In reply to the people talking about massage marketing plan, target market of massage spa, foot spa business, serenity massage & wellness spa llc, fulton county massage clinic, massage llc, I highly recommend this updated business trip massage blog or new body massage clinic, starting a massage therapy business, a healing touch massage therapy spa llc, massage envy corporate email, serenity massage & wellness spa llc, mobile massage van business, on top of this top business trip massage forum as well as tracy pieper licensed massage therapist, power of touch massage & wellness llc, body massage clinic, massage business start up, mobile massage business for sale, ag massage company, as well as this excellent business trip massage tips which is also great. Also, have a look at this updated business trip massage forum and don't forget self employed sports massage therapist, jones massage company, massage marketing ideas, mobile massage therapy near me, ezekiel's massage studio llc, running a massage business, and don't forget this great business trip massage forum on top of thai orchid bodyworks llc, start up costs for massage business, spa and massage business sale, successful massage therapy business, coming home massage and more llc, massage shop for takeover, alongside all awesome business trip massage forum which is also worth a look. I also recommend this excellent business trip massage url and don't forget summa massage and wellness llc, massage spa for takeover, back to business massage, a+ therapeutic massage llc, private massage practice, massage practice builder, on top of this new business trip massage site on top of serenity massage & wellness spa llc, body massage business, building a massage therapy business, calming touch massage llc, massage clinic for sale, massage therapy business plan powerpoint, not to mention updated business trip massage advice as well as things needed to start a massage business, back to business massage, a healing touch massage therapy spa llc, holistic care company massage, therapeutic bodyworks llc, anointed hands massage and wellness llc, which is also great. Finally, have a look at this top business trip massage link with setting up a massage business at home, therapeutic bodyworks llc, loyal oak massage llc, mobile massage set up, sba spa and massage, healing hands therapeutic spa llc, for good measure. Check more @ High Rated Skiing Base Layers Website 2_50fba