FindItem/FindItemCount and Cursor Items

A forum for reporting bugs NOT related to custom plugins.

Moderator: MacroQuest Developers

Arglemente
decaying skeleton
decaying skeleton
Posts: 8
Joined: Sun Sep 17, 2017 12:25 pm

FindItem/FindItemCount and Cursor Items

Post by Arglemente » Fri Sep 22, 2017 10:34 am

Before this last patch, FindItemCount included items on the cursor.

This is no longer the case.

If you have 10 in inventory and 1 on cursor
${FindItemCount[=Vegetables]}
Will return 10. Previously it was 11. More importantly, if all are on cursor, count is 0.

However FindItem appears to still factor cursor in. if all of an item is on the cursor, count is 0, and found is still valid
${FindItem[=Vegetables]}

SwiftyMUSE
Developer
Developer
Posts: 1205
Joined: Tue Sep 23, 2003 10:52 pm

Re: FindItem/FindItemCount and Cursor Items

Post by SwiftyMUSE » Fri Sep 22, 2017 6:13 pm

I don't see any changes in the code that would make this the case. That being said, FindItem and FindItemCount should work the same way. I'll look at adding the cursor stuff to FindItemCount.
PayPal: Donate to SwiftyMUSE
Bitcoin: 1LuQ6YcEAWxF3fm9yWMiro4K582je7364V
Krono: PM me

dont_know_at_all wrote:Gee, if only there was a way to correctly report a crash...

Arglemente
decaying skeleton
decaying skeleton
Posts: 8
Joined: Sun Sep 17, 2017 12:25 pm

Re: FindItem/FindItemCount and Cursor Items

Post by Arglemente » Sun Sep 24, 2017 11:43 am

Thank you.

It's possible it changed a patch ago - I don't recall if I used my forage macro in the past month.

Either way, I have modified my script (a variation on YAFF someone posted here many years ago) to compensate, but things are definitely different "recently" (last patch or two).

The fact that FindItem and FindItemCount work differently with regard to the cursor is an inconsistency.

SwiftyMUSE
Developer
Developer
Posts: 1205
Joined: Tue Sep 23, 2003 10:52 pm

Re: FindItem/FindItemCount and Cursor Items

Post by SwiftyMUSE » Sun Sep 24, 2017 4:32 pm

I've sent EqMule the changes to be included in the next release.
PayPal: Donate to SwiftyMUSE
Bitcoin: 1LuQ6YcEAWxF3fm9yWMiro4K582je7364V
Krono: PM me

dont_know_at_all wrote:Gee, if only there was a way to correctly report a crash...

Arglemente
decaying skeleton
decaying skeleton
Posts: 8
Joined: Sun Sep 17, 2017 12:25 pm

Re: FindItem/FindItemCount and Cursor Items

Post by Arglemente » Mon Sep 25, 2017 12:40 am

That is amazing. Thank you.