GetItemLink (MQ2Main/MQ2Utilities.cpp) broken

[demonstar55]

Minor mistake in the string safety patch, but the Buffer passed in is the return Buffer

This is the current broken code.

Code: Select all

BOOL GetItemLink(PCONTENTS Item, PCHAR Buffer, BOOL Clickable)
{
	CHAR szCmd[MAX_STRING] = { 0 };
	strcpy_s(szCmd, Buffer);
	char hash[MAX_STRING] = { 0 };
	bool retVal = FALSE;
	((EQ_Item*)Item)->CreateItemTagString(hash, sizeof(hash));
	if (hash[0]) {
		if (Clickable)
			sprintf_s(szCmd, "%c0%s%s%c", 0x12, hash, GetItemFromContents(Item)->Name, 0x12);
		else
			sprintf_s(szCmd, "0%s%s", hash, GetItemFromContents(Item)->Name);
		retVal = TRUE;
	}
	DebugSpew("GetItemLink() returns '%s'", &szCmd[0]);
	return retVal;

I'm not 100% sure on the best solution in the name of safeness, but the at least with how it is now, szCmd needs to be copied back into Buffer. The Buffer should also be empty so doesn't need to be copied.

[SwiftyMUSE]

Sorry, I thought EQMule got the fix for this in already. We discussed it a while ago.

[EqMule]

Fixed this today, it will be released in the next zip.