Event chat

[mongo]

looking over some scripts, why all the IF statments for $p1 $p2 $p3 etc,

why not just /target $p1 $p2 $p3 $p4, no matter how long it is?

[grimjack]

looking over some scripts, why all the IF statments for $p1 $p2 $p3 etc,

why not just /target $p1 $p2 $p3 $p4, no matter how long it is?

Code: Select all

   /if n $strlen("$p1")<=0 { 
      /return 
   } else /if n $strlen("$p2")<=0 { 
      /target "$p1" 
   } else /if n $strlen("$p3")<=0 { 
      /target "$p1 $p2" 
   } else /if n $strlen("$p4)<=0 { 
      /target "$p1 $p2 $p3" 
   } else /target "$p1 $p2 $p3 $p4" 
   /tell $MasterName my target is %t 

With /target $p0 $p1 $p2 $p4
If I send a tell to the bot:

/tell bot target Vind

It will attempt to target "Vind " (This might not match for Vindicator due to the trailing 3 spaces). We want it to attempt to target "Vind" (This will match for Vindicator). I do it more for clean code than anything.

This is a better example of where it will break:

Code: Select all

   /assist $MasterName 
   /if n $strlen("$p1")<=0 { 
      /return 
   } else /if n $strlen("$p2")<=0 { 
      /tell "$MasterName" Casting $p1 on %T 
      /call SpellSub $p1 
   } else /if n $strlen("$p3")<=0 { 
      /tell "$MasterName" Casting $p1 $p2 on %T 
      /call SpellSub "$p1 $p2" 
   } else /if n $strlen("$p4)<=0 { 
      /tell "$MasterName" Casting $p1 $p2 $p3 on %T 
      /call SpellSub "$p1 $p2 $p3" 
   } else { 
      /tell "$MasterName" Casting $p1 $p2 $p3 $p4 on %T 
      /call SpellSub "$p1 $p2 $p3 $p4" 
   /stand 
   /if "$SitAfterCast"=="1" /sit on 
   /press esc 

This one passes a spell name to another part of the script. If I have it /call SpellSub "Ice Comet " ($p1 $p2 $p3 $p4). It will break the macro. I have to have it do /call SpellSub "Ice Comet" ($p1 $p2). Here is why it will break.

Code: Select all

   /varset SpellName "$p0" 
   /varset SpellSlot "$char(gem,"$SpellName")" 
   /varset CastTime "$spell("$SpellName",casttime)" 

$spell("Ice Comet",casttime) works
$spell("Ice Comet ",casttime) does not.

Thanks
GrimJack